All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@ti.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Axel Lin <axel.lin@gmail.com>,
	linux-kernel@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Felipe Balbi <balbi@ti.com>
Subject: Re: [PATCH RESEND] ARM: OMAP: omap_device: Include linux/export.h
Date: Thu, 03 Nov 2011 10:48:44 -0700	[thread overview]
Message-ID: <877h3hhzb7.fsf@ti.com> (raw)
In-Reply-To: <4EB2A987.2040805@windriver.com> (Paul Gortmaker's message of "Thu, 3 Nov 2011 10:47:35 -0400")

Paul Gortmaker <paul.gortmaker@windriver.com> writes:

> On 11-11-03 10:26 AM, Kevin Hilman wrote:
>> Axel Lin <axel.lin@gmail.com> writes:
>> 
>>> Include linux/export.h to fix below build warning:
>>>
>>>   CC      arch/arm/plat-omap/omap_device.o
>>> arch/arm/plat-omap/omap_device.c:1055: warning: data definition has no type or storage class
>>> arch/arm/plat-omap/omap_device.c:1055: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL'
>>> arch/arm/plat-omap/omap_device.c:1055: warning: parameter names (without types) in function declaration
>>>
>>> Signed-off-by: Axel Lin <axel.lin@gmail.com>
>> 
>> Thanks, will queue as a fix for v3.2-rc
>
> It is probably better if I track this, since export.h won't
> exist until Linus pulls the module.h-split tree, and I'm
> guessing that will be closer to the end of the merge window.

OK, sounds good.  Feel free to add:

Acked-by: Kevin Hilman <khilman@ti.com>

Thanks,

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND] ARM: OMAP: omap_device: Include linux/export.h
Date: Thu, 03 Nov 2011 10:48:44 -0700	[thread overview]
Message-ID: <877h3hhzb7.fsf@ti.com> (raw)
In-Reply-To: <4EB2A987.2040805@windriver.com> (Paul Gortmaker's message of "Thu, 3 Nov 2011 10:47:35 -0400")

Paul Gortmaker <paul.gortmaker@windriver.com> writes:

> On 11-11-03 10:26 AM, Kevin Hilman wrote:
>> Axel Lin <axel.lin@gmail.com> writes:
>> 
>>> Include linux/export.h to fix below build warning:
>>>
>>>   CC      arch/arm/plat-omap/omap_device.o
>>> arch/arm/plat-omap/omap_device.c:1055: warning: data definition has no type or storage class
>>> arch/arm/plat-omap/omap_device.c:1055: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL'
>>> arch/arm/plat-omap/omap_device.c:1055: warning: parameter names (without types) in function declaration
>>>
>>> Signed-off-by: Axel Lin <axel.lin@gmail.com>
>> 
>> Thanks, will queue as a fix for v3.2-rc
>
> It is probably better if I track this, since export.h won't
> exist until Linus pulls the module.h-split tree, and I'm
> guessing that will be closer to the end of the merge window.

OK, sounds good.  Feel free to add:

Acked-by: Kevin Hilman <khilman@ti.com>

Thanks,

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@ti.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Axel Lin <axel.lin@gmail.com>, <linux-kernel@vger.kernel.org>,
	Tony Lindgren <tony@atomide.com>, <linux-omap@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	Felipe Balbi <balbi@ti.com>
Subject: Re: [PATCH RESEND] ARM: OMAP: omap_device: Include linux/export.h
Date: Thu, 03 Nov 2011 10:48:44 -0700	[thread overview]
Message-ID: <877h3hhzb7.fsf@ti.com> (raw)
In-Reply-To: <4EB2A987.2040805@windriver.com> (Paul Gortmaker's message of "Thu, 3 Nov 2011 10:47:35 -0400")

Paul Gortmaker <paul.gortmaker@windriver.com> writes:

> On 11-11-03 10:26 AM, Kevin Hilman wrote:
>> Axel Lin <axel.lin@gmail.com> writes:
>> 
>>> Include linux/export.h to fix below build warning:
>>>
>>>   CC      arch/arm/plat-omap/omap_device.o
>>> arch/arm/plat-omap/omap_device.c:1055: warning: data definition has no type or storage class
>>> arch/arm/plat-omap/omap_device.c:1055: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL'
>>> arch/arm/plat-omap/omap_device.c:1055: warning: parameter names (without types) in function declaration
>>>
>>> Signed-off-by: Axel Lin <axel.lin@gmail.com>
>> 
>> Thanks, will queue as a fix for v3.2-rc
>
> It is probably better if I track this, since export.h won't
> exist until Linus pulls the module.h-split tree, and I'm
> guessing that will be closer to the end of the merge window.

OK, sounds good.  Feel free to add:

Acked-by: Kevin Hilman <khilman@ti.com>

Thanks,

Kevin



  reply	other threads:[~2011-11-03 17:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-03  7:00 [PATCH RESEND] ARM: OMAP: omap_device: Include linux/export.h Axel Lin
2011-11-03  7:00 ` Axel Lin
2011-11-03 14:26 ` Kevin Hilman
2011-11-03 14:26   ` Kevin Hilman
2011-11-03 14:26   ` Kevin Hilman
2011-11-03 14:47   ` Paul Gortmaker
2011-11-03 14:47     ` Paul Gortmaker
2011-11-03 14:47     ` Paul Gortmaker
2011-11-03 17:48     ` Kevin Hilman [this message]
2011-11-03 17:48       ` Kevin Hilman
2011-11-03 17:48       ` Kevin Hilman
2011-11-07 20:35 ` Tony Lindgren
2011-11-07 20:35   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877h3hhzb7.fsf@ti.com \
    --to=khilman@ti.com \
    --cc=axel.lin@gmail.com \
    --cc=balbi@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.