From: Kevin Hilman <khilman@ti.com>
To: "Munegowda, Keshava" <keshava_mgowda@ti.com>
Cc: Paul Walmsley <paul@pwsan.com>,
linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, balbi@ti.com, b-cousson@ti.com,
gadiyar@ti.com, sameo@linux.intel.com, parthab@india.ti.com,
tony@atomide.com, johnstul@us.ibm.com, vishwanath.bs@ti.com
Subject: Re: [PATCH 2/5 v12] arm: omap: usb: ehci and ohci hwmod structures for omap3
Date: Fri, 30 Sep 2011 10:17:22 -0700 [thread overview]
Message-ID: <877h4qj6fx.fsf@ti.com> (raw)
In-Reply-To: <CAP05o4LJ2P8DCri1Vf-opezP8eNX+Wghm9FBSYwy8Vrct8_YDw@mail.gmail.com> (Keshava Munegowda's message of "Fri, 30 Sep 2011 16:02:06 +0530")
"Munegowda, Keshava" <keshava_mgowda@ti.com> writes:
[...]
>>> +
>>> +static struct omap_hwmod_ocp_if omap34xx_f_cfg__usb_tll_hs = {
>>> + .clk = "usbtll_ick",
>>> + .user = OCP_USER_MPU,
>>> + .flags = OCPIF_SWSUP_IDLE,
>>> +};
>>
>> Does this really need OCPIF_SWSUP_IDLE? If so, then there is a hardware
>> bug, and some explanation is needed.
>
>
> it was not allowing enter usbhs pw domain to enter to low power idle mode; so
> I add a comment here.
>
When you add this comment, please be sure it describes *why* the power
domain was not hitting the target power state, and reference any
relevant eerrata.
Thanks,
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@ti.com>
To: "Munegowda\, Keshava" <keshava_mgowda@ti.com>
Cc: Paul Walmsley <paul@pwsan.com>,
linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, balbi@ti.com, b-cousson@ti.com,
gadiyar@ti.com, sameo@linux.intel.com, parthab@india.ti.com,
tony@atomide.com, johnstul@us.ibm.com, vishwanath.bs@ti.com
Subject: Re: [PATCH 2/5 v12] arm: omap: usb: ehci and ohci hwmod structures for omap3
Date: Fri, 30 Sep 2011 10:17:22 -0700 [thread overview]
Message-ID: <877h4qj6fx.fsf@ti.com> (raw)
In-Reply-To: <CAP05o4LJ2P8DCri1Vf-opezP8eNX+Wghm9FBSYwy8Vrct8_YDw@mail.gmail.com> (Keshava Munegowda's message of "Fri, 30 Sep 2011 16:02:06 +0530")
"Munegowda, Keshava" <keshava_mgowda@ti.com> writes:
[...]
>>> +
>>> +static struct omap_hwmod_ocp_if omap34xx_f_cfg__usb_tll_hs = {
>>> + .clk = "usbtll_ick",
>>> + .user = OCP_USER_MPU,
>>> + .flags = OCPIF_SWSUP_IDLE,
>>> +};
>>
>> Does this really need OCPIF_SWSUP_IDLE? If so, then there is a hardware
>> bug, and some explanation is needed.
>
>
> it was not allowing enter usbhs pw domain to enter to low power idle mode; so
> I add a comment here.
>
When you add this comment, please be sure it describes *why* the power
domain was not hitting the target power state, and reference any
relevant eerrata.
Thanks,
Kevin
next prev parent reply other threads:[~2011-09-30 17:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 5:40 [PATCH 2/5 v12] arm: omap: usb: ehci and ohci hwmod structures for omap3 Keshava Munegowda
2011-09-30 5:40 ` Keshava Munegowda
2011-09-30 7:12 ` Paul Walmsley
2011-09-30 8:02 ` Paul Walmsley
2011-09-30 10:33 ` Munegowda, Keshava
2011-09-30 10:32 ` Munegowda, Keshava
2011-09-30 17:17 ` Kevin Hilman [this message]
2011-09-30 17:17 ` Kevin Hilman
2011-10-04 11:57 ` Munegowda, Keshava
-- strict thread matches above, loose matches on Subject: below --
2011-09-29 14:24 [PATCH 0/5 v12] mfd: omap: usb: Runtime PM support for EHCI and OHCI drivers Keshava Munegowda
2011-09-29 14:24 ` [PATCH 1/5 v12] arm: omap: usb: ehci and ohci hwmod structures for omap4 Keshava Munegowda
2011-09-29 14:24 ` [PATCH 2/5 v12] arm: omap: usb: ehci and ohci hwmod structures for omap3 Keshava Munegowda
2011-09-29 14:24 ` Keshava Munegowda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877h4qj6fx.fsf@ti.com \
--to=khilman@ti.com \
--cc=b-cousson@ti.com \
--cc=balbi@ti.com \
--cc=gadiyar@ti.com \
--cc=johnstul@us.ibm.com \
--cc=keshava_mgowda@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=parthab@india.ti.com \
--cc=paul@pwsan.com \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
--cc=vishwanath.bs@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.