From: Rusty Russell <rusty@rustcorp.com.au>
To: Amit Shah <amit.shah@redhat.com>,
Virtualization List <virtualization@lists.linux-foundation.org>
Cc: markmc@redhat.com, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH 0/2] Fix hot-unplug: device removal while port in use
Date: Wed, 16 Mar 2011 14:31:03 +1030 [thread overview]
Message-ID: <877hbziuio.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20110311111628.GC8908@amit-x200.redhat.com>
On Fri, 11 Mar 2011 16:46:28 +0530, Amit Shah <amit.shah@redhat.com> wrote:
> Ideally virtio_pci_release_dev() shouldn't be needed at all; all that
> work can be moved to virtio_pci_remove(). virtio_pci_release_dev()
> was added in 29f9f12e to curb a warning:
>
> virtio: add PCI device release() function
>
> Add a release() function for virtio_pci devices so as to avoid:
>
> Device 'virtio0' does not have a release() function, it is
> broken and must be fixed
>
>
> So we could have an empty release() function that does nothing, and
> all of the current functionality be moved to virtio_pci_remove(), as
> it was earlier. This should keep everyone happy.
>
> Is that fine?
Greg K-H needs to be asked this question, I think.
Cheers,
Rusty.
prev parent reply other threads:[~2011-03-16 4:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 8:23 [PATCH 0/2] Fix hot-unplug: device removal while port in use Amit Shah
2011-03-02 8:23 ` [PATCH 1/2] virtio: console: Don't access vqs if device was unplugged Amit Shah
2011-03-02 8:23 ` [PATCH 2/2] virtio: console: Don't call device_destroy() on port device Amit Shah
2011-03-02 11:08 ` [PATCH 0/2] Fix hot-unplug: device removal while port in use Rusty Russell
2011-03-02 13:38 ` Amit Shah
2011-03-11 11:16 ` Amit Shah
2011-03-16 4:01 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877hbziuio.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=amit.shah@redhat.com \
--cc=markmc@redhat.com \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.