From: Peter Korsgaard <jacmet@sunsite.dk>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: sfr@canb.auug.org.au, devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, davem@davemloft.net
Subject: Re: [RFC PATCH 07/15] dt: uartlite: merge platform and of_platform driver bindings
Date: Wed, 23 Feb 2011 09:58:01 +0100 [thread overview]
Message-ID: <877hcryvom.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20110223043411.20795.57850.stgit@localhost6.localdomain6> (Grant Likely's message of "Tue, 22 Feb 2011 21:34:11 -0700")
>>>>> "Grant" == Grant Likely <grant.likely@secretlab.ca> writes:
Grant> of_platform_driver is getting removed, and a single platform_driver
Grant> can now support both devicetree and non-devicetree use cases. This
Grant> patch merges the two driver registrations.
Wee!
Grant> static int __devinit ulite_probe(struct platform_device *pdev)
Grant> {
Grant> struct resource *res, *res2;
Grant> + const __be32 *prop;
Grant> + int id = pdev->id;
Grant> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
Grant> if (!res)
Grant> @@ -583,7 +586,13 @@ static int __devinit ulite_probe(struct platform_device *pdev)
Grant> if (!res2)
Grant> return -ENODEV;
Grant> - return ulite_assign(&pdev->dev, pdev->id, res->start, res2->start);
Grant> +#ifdef CONFIG_OF
Grant> + prop = of_get_property(pdev->dev.of_node, "port-number", NULL);
Grant> + if (prop)
Grant> + id = be32_to_cpup(prop);
Grant> +#endif
Grant> +
Grant> + return ulite_assign(&pdev->dev, id, res->start, res2->start);
Grant> }
Isn't this going to give a build warning about prop being unused on
!CONFIG_OF builds? Perhaps move it down into the CONFIG_OF conditional?
Other than that,
Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
--
Bye, Peter Korsgaard
WARNING: multiple messages have this Message-ID (diff)
From: Peter Korsgaard <jacmet@sunsite.dk>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
devicetree-discuss@lists.ozlabs.org, sfr@canb.auug.org.au,
linux-kernel@vger.kernel.org, davem@davemloft.net,
sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [RFC PATCH 07/15] dt: uartlite: merge platform and of_platform driver bindings
Date: Wed, 23 Feb 2011 08:58:01 +0000 [thread overview]
Message-ID: <877hcryvom.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20110223043411.20795.57850.stgit@localhost6.localdomain6> (Grant Likely's message of "Tue, 22 Feb 2011 21:34:11 -0700")
>>>>> "Grant" = Grant Likely <grant.likely@secretlab.ca> writes:
Grant> of_platform_driver is getting removed, and a single platform_driver
Grant> can now support both devicetree and non-devicetree use cases. This
Grant> patch merges the two driver registrations.
Wee!
Grant> static int __devinit ulite_probe(struct platform_device *pdev)
Grant> {
Grant> struct resource *res, *res2;
Grant> + const __be32 *prop;
Grant> + int id = pdev->id;
Grant> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
Grant> if (!res)
Grant> @@ -583,7 +586,13 @@ static int __devinit ulite_probe(struct platform_device *pdev)
Grant> if (!res2)
Grant> return -ENODEV;
Grant> - return ulite_assign(&pdev->dev, pdev->id, res->start, res2->start);
Grant> +#ifdef CONFIG_OF
Grant> + prop = of_get_property(pdev->dev.of_node, "port-number", NULL);
Grant> + if (prop)
Grant> + id = be32_to_cpup(prop);
Grant> +#endif
Grant> +
Grant> + return ulite_assign(&pdev->dev, id, res->start, res2->start);
Grant> }
Isn't this going to give a build warning about prop being unused on
!CONFIG_OF builds? Perhaps move it down into the CONFIG_OF conditional?
Other than that,
Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
--
Bye, Peter Korsgaard
WARNING: multiple messages have this Message-ID (diff)
From: Peter Korsgaard <jacmet@sunsite.dk>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
devicetree-discuss@lists.ozlabs.org, sfr@canb.auug.org.au,
linux-kernel@vger.kernel.org, davem@davemloft.net,
sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [RFC PATCH 07/15] dt: uartlite: merge platform and of_platform driver bindings
Date: Wed, 23 Feb 2011 09:58:01 +0100 [thread overview]
Message-ID: <877hcryvom.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20110223043411.20795.57850.stgit@localhost6.localdomain6> (Grant Likely's message of "Tue, 22 Feb 2011 21:34:11 -0700")
>>>>> "Grant" == Grant Likely <grant.likely@secretlab.ca> writes:
Grant> of_platform_driver is getting removed, and a single platform_driver
Grant> can now support both devicetree and non-devicetree use cases. This
Grant> patch merges the two driver registrations.
Wee!
Grant> static int __devinit ulite_probe(struct platform_device *pdev)
Grant> {
Grant> struct resource *res, *res2;
Grant> + const __be32 *prop;
Grant> + int id = pdev->id;
Grant> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
Grant> if (!res)
Grant> @@ -583,7 +586,13 @@ static int __devinit ulite_probe(struct platform_device *pdev)
Grant> if (!res2)
Grant> return -ENODEV;
Grant> - return ulite_assign(&pdev->dev, pdev->id, res->start, res2->start);
Grant> +#ifdef CONFIG_OF
Grant> + prop = of_get_property(pdev->dev.of_node, "port-number", NULL);
Grant> + if (prop)
Grant> + id = be32_to_cpup(prop);
Grant> +#endif
Grant> +
Grant> + return ulite_assign(&pdev->dev, id, res->start, res2->start);
Grant> }
Isn't this going to give a build warning about prop being unused on
!CONFIG_OF builds? Perhaps move it down into the CONFIG_OF conditional?
Other than that,
Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2011-02-23 8:58 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 4:33 [RFC PATCH 00/15] Remove last remains of of_platform_bus_type Grant Likely
2011-02-23 4:33 ` Grant Likely
2011-02-23 4:33 ` Grant Likely
2011-02-23 4:33 ` [RFC PATCH 01/15] dt/powerpc: move of_bus_type infrastructure to ibmebus Grant Likely
2011-02-23 4:33 ` [RFC PATCH 01/15] dt/powerpc: move of_bus_type infrastructure to Grant Likely
2011-02-24 14:46 ` [RFC PATCH 01/15] dt/powerpc: move of_bus_type infrastructure to ibmebus Arnd Bergmann
2011-02-24 14:46 ` Arnd Bergmann
2011-02-24 14:46 ` Arnd Bergmann
2011-02-25 8:53 ` Benjamin Herrenschmidt
2011-02-25 8:53 ` Benjamin Herrenschmidt
2011-02-25 8:53 ` [RFC PATCH 01/15] dt/powerpc: move of_bus_type infrastructure Benjamin Herrenschmidt
2011-02-28 7:35 ` [RFC PATCH 01/15] dt/powerpc: move of_bus_type infrastructure to ibmebus Grant Likely
2011-02-28 7:35 ` Grant Likely
2011-02-28 7:35 ` [RFC PATCH 01/15] dt/powerpc: move of_bus_type infrastructure Grant Likely
2011-02-23 4:33 ` [RFC PATCH 02/15] dt: add a match table pointer to struct device Grant Likely
2011-02-23 4:33 ` Grant Likely
2011-02-23 18:29 ` Rob Herring
2011-02-23 18:29 ` Rob Herring
2011-02-23 18:29 ` Rob Herring
2011-02-23 18:44 ` Grant Likely
2011-02-23 18:44 ` Grant Likely
2011-02-23 18:44 ` [RFC PATCH 02/15] dt: add a match table pointer to struct Grant Likely
2011-02-23 21:18 ` Open Firmware and interrupt trigger Robert Thorhuus
2011-02-24 20:46 ` Benjamin Herrenschmidt
2011-02-25 7:29 ` Robert Thorhuus
2011-02-25 8:47 ` Benjamin Herrenschmidt
2011-02-23 4:33 ` [RFC PATCH 03/15] dt/powerpc: Eliminate users of of_platform_{, un}register_driver Grant Likely
2011-02-23 4:33 ` Grant Likely
2011-02-23 4:33 ` [RFC PATCH 03/15] dt/powerpc: Eliminate users of of_platform_{, Grant Likely
2011-02-23 4:33 ` [RFC PATCH 04/15] dt/sparc: Eliminate users of of_platform_{, un}register_driver Grant Likely
2011-02-23 4:33 ` [RFC PATCH 04/15] dt/sparc: Eliminate users of of_platform_{, Grant Likely
2011-02-23 4:34 ` [RFC PATCH 05/15] leds/leds-gpio: merge platform_driver with of_platform_driver Grant Likely
2011-02-23 4:34 ` [RFC PATCH 05/15] leds/leds-gpio: merge platform_driver with Grant Likely
2011-02-23 4:34 ` [RFC PATCH 06/15] dt: xilinx_hwicap: merge platform and of_platform driver bindings Grant Likely
2011-02-23 4:34 ` [RFC PATCH 06/15] dt: xilinx_hwicap: merge platform and of_platform Grant Likely
2011-02-25 18:25 ` [RFC PATCH 06/15] dt: xilinx_hwicap: merge platform and of_platformdriver bindings Stephen Neuendorffer
2011-02-25 18:25 ` Stephen Neuendorffer
2011-02-25 18:25 ` Stephen Neuendorffer
2011-02-25 18:25 ` Stephen Neuendorffer
2011-02-28 7:41 ` Grant Likely
2011-02-28 7:41 ` Grant Likely
2011-02-28 7:41 ` Grant Likely
2011-02-28 7:41 ` [RFC PATCH 06/15] dt: xilinx_hwicap: merge platform and Grant Likely
2011-02-23 4:34 ` [RFC PATCH 07/15] dt: uartlite: merge platform and of_platform driver bindings Grant Likely
2011-02-23 4:34 ` [RFC PATCH 07/15] dt: uartlite: merge platform and of_platform driver Grant Likely
2011-02-23 8:58 ` Peter Korsgaard [this message]
2011-02-23 8:58 ` [RFC PATCH 07/15] dt: uartlite: merge platform and of_platform driver bindings Peter Korsgaard
2011-02-23 8:58 ` Peter Korsgaard
2011-02-23 18:10 ` Grant Likely
2011-02-23 18:10 ` Grant Likely
2011-02-23 18:10 ` [RFC PATCH 07/15] dt: uartlite: merge platform and of_platform Grant Likely
2011-02-23 4:34 ` [RFC PATCH 08/15] dt/spi: Eliminate users of of_platform_{, un}register_driver Grant Likely
2011-02-23 4:34 ` [RFC PATCH 08/15] dt/spi: Eliminate users of of_platform_{, Grant Likely
2011-02-23 4:34 ` [RFC PATCH 09/15] dt/sound: Eliminate users of of_platform_{, un}register_driver Grant Likely
2011-02-23 4:34 ` [RFC PATCH 09/15] dt/sound: Eliminate users of of_platform_{, Grant Likely
2011-02-23 4:34 ` [RFC PATCH 10/15] dt/net: Eliminate users of of_platform_{, un}register_driver Grant Likely
2011-02-23 4:34 ` [RFC PATCH 10/15] dt/net: Eliminate users of of_platform_{, Grant Likely
2011-02-23 4:34 ` [RFC PATCH 11/15] dt/video: Eliminate users of of_platform_{, un}register_driver Grant Likely
2011-02-23 4:34 ` [RFC PATCH 11/15] dt/video: Eliminate users of of_platform_{, Grant Likely
2011-02-23 4:34 ` [RFC PATCH 12/15] dt/usb: Eliminate users of of_platform_{, un}register_driver Grant Likely
2011-02-23 4:34 ` [RFC PATCH 12/15] dt/usb: Eliminate users of of_platform_{, Grant Likely
2011-02-23 4:34 ` [RFC PATCH 13/15] dt/serial: Eliminate users of of_platform_{, un}register_driver Grant Likely
2011-02-23 4:34 ` [RFC PATCH 13/15] dt/serial: Eliminate users of of_platform_{, Grant Likely
2011-02-24 16:34 ` [RFC PATCH 13/15] dt/serial: Eliminate users of of_platform_{, un}register_driver Arnd Bergmann
2011-02-24 16:34 ` Arnd Bergmann
2011-02-24 16:34 ` Arnd Bergmann
2011-02-24 16:34 ` Arnd Bergmann
2011-02-23 4:34 ` [RFC PATCH 14/15] dt: Eliminate of_platform_{,un}register_driver Grant Likely
2011-02-23 4:34 ` Grant Likely
2011-02-23 16:56 ` Rob Herring
2011-02-23 16:56 ` Rob Herring
2011-02-23 16:56 ` Rob Herring
2011-02-23 17:22 ` Grant Likely
2011-02-23 17:22 ` Grant Likely
2011-02-23 17:22 ` Grant Likely
2011-02-23 17:22 ` Grant Likely
2011-02-23 4:34 ` [RFC PATCH 15/15] dt: eliminate of_platform_driver shim code Grant Likely
2011-02-23 4:34 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877hcryvom.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite.dk \
--cc=davem@davemloft.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sfr@canb.auug.org.au \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.