From: Marco Gerards <metgerards@student.han.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: sparc64 port
Date: Sat, 20 Aug 2005 16:10:00 +0200 [thread overview]
Message-ID: <877jegits7.fsf@student.han.nl> (raw)
In-Reply-To: <430716B7.1000806@yahoo.fr> (Vincent Pelletier's message of "Sat, 20 Aug 2005 13:40:39 +0200")
Vincent Pelletier <subdino2004@yahoo.fr> writes:
Hi Vincent,
This is really nice! Thanks a lot. You asked me on IRC if I can test
if it still builds on the PPC. I will test that (and let you know on
IRC), after that you can commit the patch if you fix the things I
mention in my email and Okuji mentioned in his.
> * disk/ieee1275/ofdisk.c (grub_ofdisk_open): use grub_ssize_t
> instead of int.
Please start sentences with an uppercase letter, same for the other
entries.
Some files are not GPL'ed (cache.c, for example). The copyright years
are not always correct, like that of ieee1275.h (you wrote it, so it
should be (C) 2005 only).
Can't openfw.c be shared? I think it can be...
Thanks,
Marco
next prev parent reply other threads:[~2005-08-20 14:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-20 11:40 sparc64 port Vincent Pelletier
2005-08-20 12:36 ` Yoshinori K. Okuji
2005-08-20 13:59 ` Vincent Pelletier
2005-08-20 14:36 ` Yoshinori K. Okuji
2005-08-20 14:10 ` Marco Gerards [this message]
2005-08-20 15:07 ` Vincent Pelletier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877jegits7.fsf@student.han.nl \
--to=metgerards@student.han.nl \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.