From: "Yoshinori K. Okuji" <okuji@enbug.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: sparc64 port
Date: Sat, 20 Aug 2005 14:36:51 +0200 [thread overview]
Message-ID: <200508201436.51320.okuji@enbug.org> (raw)
In-Reply-To: <430716B7.1000806@yahoo.fr>
On Saturday 20 August 2005 13:40, Vincent Pelletier wrote:
> * boot/sparc64/ieee1275/cmain.c: New file.
This is wrong. I guess you just followed the powerpc port, but it is also
wrong. Instead, this file must be put in the kernel. The directory boot is
used to organize files for the bootstrap of the kernel, which are not a part
of the kernel.
In principle, the kernel should not be linked with a file in another
directory. Unfortunately, this is not always true, in order to solve "chicken
and egg" problems. Nevertheless, we should try to make the kernel as much
independent of other directories as possible.
> * kern/sparc64/cache.c: New file.
The contents of this file is strange. Why don't you simply include
grub/cache.h?
About the ChangeLog:
Please do not mention new directories. They are not worth describing, because
they don't cause bugs, and they are not related to copyright problems.
Please use simply "Likewise" when you repeat the same description. This is not
obligatory, but often easier to read.
Okuji
next prev parent reply other threads:[~2005-08-20 12:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-20 11:40 sparc64 port Vincent Pelletier
2005-08-20 12:36 ` Yoshinori K. Okuji [this message]
2005-08-20 13:59 ` Vincent Pelletier
2005-08-20 14:36 ` Yoshinori K. Okuji
2005-08-20 14:10 ` Marco Gerards
2005-08-20 15:07 ` Vincent Pelletier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200508201436.51320.okuji@enbug.org \
--to=okuji@enbug.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.