All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Mehmet Fide <mehmet.fide@gmail.com>
Cc: Chun-Yeow Yeoh <yeohchunyeow@gmail.com>,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	mehmet.fide@screeningeagle.com
Subject: Re: [PATCH ath-next] wifi: ath9k_htc: do not fetch the beacon of a finished countdown
Date: Tue, 17 Nov 2026 14:57:03 +0100	[thread overview]
Message-ID: <878q2rtvbk.fsf@toke.dk> (raw)
In-Reply-To: <20261117122648.1731207-1-mehmet.fide@gmail.com>

Mehmet Fide <mehmet.fide@gmail.com> writes:

> Hi Toke,
>
>> if (ath9k_htc_csa_is_finished(priv))
>>    return;
>
> That would skip one beacon at most. ath9k_htc_csa_is_finished() clears
> csa_vif when it calls ieee80211_csa_finish(), but csa_active stays set
> until the second round of __ieee80211_csa_finalize(), after the channel
> change, and ath9k_htc_set_channel() turns beaconing back on in between.
> The next SWBA finds csa_vif NULL and fetches the CSA beacon again.

Hmm, so it seems that the ath9k driver used to have a similar structure
(with the csa_vif pointer), but that was changed in commit:

4effc6fda7ab ("ath9k: prepare for multi-interface CSA support")

I think doing a similar change in ath9k_htc would allow us to have the
pre-check use the same function without this issue, *and* get rid of the
setting of csa_vif without any locks protecting it, no?

-Toke

  reply	other threads:[~2026-11-17 13:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-02 12:34 [PATCH ath-next] wifi: ath9k_htc: do not fetch the beacon of a finished countdown Mehmet Fide
2026-11-17 10:25 ` Toke Høiland-Jørgensen
2026-11-17 12:26   ` Mehmet Fide
2026-11-17 13:57     ` Toke Høiland-Jørgensen [this message]
2026-11-17 15:13       ` Mehmet Fide

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878q2rtvbk.fsf@toke.dk \
    --to=toke@toke.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mehmet.fide@gmail.com \
    --cc=mehmet.fide@screeningeagle.com \
    --cc=yeohchunyeow@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.