From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Mehmet Fide <mehmet.fide@gmail.com>
Cc: Chun-Yeow Yeoh <yeohchunyeow@gmail.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
mehmet.fide@screeningeagle.com
Subject: Re: [PATCH ath-next] wifi: ath9k_htc: do not fetch the beacon of a finished countdown
Date: Tue, 17 Nov 2026 11:25:21 +0100 [thread overview]
Message-ID: <87fqwzu54e.fsf@toke.dk> (raw)
In-Reply-To: <20261102123430.1136741-1-mehmet.fide@gmail.com>
Mehmet Fide <mehmet.fide@gmail.com> writes:
> From: Mehmet Fide <mehmet.fide@screeningeagle.com>
>
> ath9k_htc_send_beacon() checks the channel switch countdown only after
> ieee80211_beacon_get(). mac80211 replaces the CSA beacon only after the
> channel change, and ath9k_htc_set_channel() re-enables beaconing before
> that, so an SWBA event can fetch the CSA beacon again on the new channel
> and mac80211 reports "beacon TX faster than countdown".
>
> Skip the beacon while the countdown is complete and finish the switch
> from there, as ath9k does for non-EDMA chips. Finishing from the skip
> also covers a count of 2, where the first fetch can complete the
> countdown before csa_vif is set.
>
> Tested on 6.12 with an AR9271 AP and hostapd chan_switch: the CSA beacon
> was fetched again in 3 of 40 switches with a count of 5 before and in
> none after, and all 60 switches with a count of 2 completed.
>
> Fixes: f0e449627e4a ("ath9k_htc: add support of channel switch")
> Signed-off-by: Mehmet Fide <mehmet.fide@screeningeagle.com>
> ---
> drivers/net/wireless/ath/ath9k/htc_drv_beacon.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_beacon.c b/drivers/net/wireless/ath/ath9k/htc_drv_beacon.c
> index 81fa7cbad892..2b5bf07511bb 100644
> --- a/drivers/net/wireless/ath/ath9k/htc_drv_beacon.c
> +++ b/drivers/net/wireless/ath/ath9k/htc_drv_beacon.c
> @@ -214,6 +214,13 @@ static void ath9k_htc_send_beacon(struct ath9k_htc_priv *priv,
> return;
> }
>
> + if (vif->bss_conf.csa_active &&
> + ieee80211_beacon_cntdwn_is_complete(vif, 0)) {
> + spin_unlock_bh(&priv->beacon_lock);
> + ath9k_htc_csa_is_finished(priv);
> + return;
> + }
> +
Hmm, there's something odd going on with the locking / vif selection
here. In the snippet above, you're basically replicating the checks
inside ath9k_htc_csa_is_finished(), before then calling
ath9k_htc_csa_is_finished() itself. Which presumably then repeats the
same checks, and does the ieee80211_csa_finish()? Or at least that's
the logic for why this is correct, AFAIU, no?
But ath9k_htc_csa_is_finished() doesn't take the 'vif' from the beacon
slot, it takes the 'priv' pointer that was passed to the function. Which
implies that either:
(1) priv->csa_vif is guaranteed to be the same whenever csa_active is
set, and thus this doesn't matter, or
(2) there's a bug here and things can get mixed up.
Since there's already a call to ath9k_htc_csa_is_finished(priv) at the
end of that same function, I'm assuming it's case (1) that holds. In
which case, I don't see any reason why we can't just do an early return
before taking the lock as:
if (ath9k_htc_csa_is_finished(priv))
return;
The priv->csa_vif pointer is not protected by the beacon lock anyway[0], so
I don't think this would lead to trouble?
Thoughts?
-Toke
[0] Side note - the priv->csa_vif pointer seems to be quite
inconsistently lock-protected: it's set under priv->mutex in the driver
setup paths, under the mac80211 wiphy lock by the
channel_switch_beacon() callback, and under the wmi lock by
ath9k_htc_csa_is_finished() itself. Not quite sure if there's some other
dependency between these locks that ensures this works, or if that's
just a total coincidence...
next prev parent reply other threads:[~2026-11-17 10:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 12:34 [PATCH ath-next] wifi: ath9k_htc: do not fetch the beacon of a finished countdown Mehmet Fide
2026-11-17 10:25 ` Toke Høiland-Jørgensen [this message]
2026-11-17 12:26 ` Mehmet Fide
2026-11-17 13:57 ` Toke Høiland-Jørgensen
2026-11-17 15:13 ` Mehmet Fide
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fqwzu54e.fsf@toke.dk \
--to=toke@toke.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mehmet.fide@gmail.com \
--cc=mehmet.fide@screeningeagle.com \
--cc=yeohchunyeow@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.