Re: [PATCH v2 1/2] dt-bindings: phy: qcom,sc8280xp-qmp-usb3-uni: Add SA8255P USB PHY

[Mattijs Korpershoek <mkorpershoek@kernel.org>]

Hi Krzysztof,

Thank you for the review.

On Sat, Jul 11, 2026 at 19:13, Krzysztof Kozlowski <krzk@kernel.org> wrote:

> On Thu, Jul 09, 2026 at 04:52:09PM +0200, Mattijs Korpershoek wrote:
>> diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
>> index 01342823e57f..80b04b7f7584 100644
>> --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
>> +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
>> @@ -26,6 +26,7 @@ properties:
>>                - qcom,msm8996-qmp-usb3-phy
>>                - qcom,qcs8300-qmp-usb3-uni-phy
>>                - qcom,qdu1000-qmp-usb3-uni-phy
>> +              - qcom,sa8255p-qmp-usb3-uni-phy
>>                - qcom,sa8775p-qmp-usb3-uni-phy
>>                - qcom,sc8180x-qmp-usb3-uni-phy
>>                - qcom,sc8280xp-qmp-usb3-uni-phy
>> @@ -54,7 +55,13 @@ properties:
>>      maxItems: 5
>>  
>>    power-domains:
>> -    maxItems: 1
>> +    minItems: 1
>> +    maxItems: 2
>> +
>> +  power-domain-names:
>> +    items:
>> +      - const: usb_transfer
>> +      - const: usb_core
>
> usb_ feels redundant, since this is USB phy.

Ack, will drop for v3.

>
>>  
>>    resets:
>>      maxItems: 2
>> @@ -82,14 +89,6 @@ properties:
>>  required:
>>    - compatible
>>    - reg
>> -  - clocks
>> -  - clock-names
>> -  - resets
>> -  - reset-names
>> -  - vdda-phy-supply
>> -  - vdda-pll-supply
>> -  - "#clock-cells"
>> -  - clock-output-names
>>    - "#phy-cells"
>
> Just like in all other saXXXX cases, same review: move to a separate
> binding file.

Ack, I was not sure about this one. I'll move to a separate binding file
in v3.

>
> Best regards,
> Krzysztof

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy