All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Cheng Ming Lin <linchengming884@gmail.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
	 Richard Weinberger <richard@nod.at>,
	 Tudor Ambarus <tudor.ambarus@linaro.org>,
	 Martin Kurbanov <mmkurbanov@salutedevices.com>,
	 Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>,
	 Pratyush Yadav <pratyush@kernel.org>,
	linux-mtd@lists.infradead.org,  linux-kernel@vger.kernel.org,
	alvinzhou@mxic.com.tw,  Cheng Ming Lin <chengminglin@mxic.com.tw>
Subject: Re: [PATCH v4 1/2] mtd: spi-nand: Add support for randomizer
Date: Wed, 04 Feb 2026 09:33:54 +0100	[thread overview]
Message-ID: <878qd8hpql.fsf@bootlin.com> (raw)
In-Reply-To: <CAAyq3SbZn5Hjx85xMS4cPYaoBccsiCj1obRbLO9eD9_RV=h7RQ@mail.gmail.com> (Cheng Ming Lin's message of "Wed, 4 Feb 2026 09:47:15 +0800")

Hi Cheng Ming,

>> Looking at the current implementation, I really don't like the core
>> always calling in the "init" and the manufacturer driver reading the DT
>> and deciding whether or not it enables it.
>
> I agree. I will refactor the logic in v5 so that the core parses the
> generic DT properties (nand-enable-randomizer and
> nand-disable-randomizer).
>
> Then, spinand_randomizer_init will determine the state and pass a
> boolean argument to the set_randomizer callback, leaving the driver
> to strictly handle the hardware configuration.

Perfect.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Cheng Ming Lin <linchengming884@gmail.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
	 Richard Weinberger <richard@nod.at>,
	 Tudor Ambarus <tudor.ambarus@linaro.org>,
	 Martin Kurbanov <mmkurbanov@salutedevices.com>,
	 Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>,
	 Pratyush Yadav <pratyush@kernel.org>,
	linux-mtd@lists.infradead.org,  linux-kernel@vger.kernel.org,
	alvinzhou@mxic.com.tw,  Cheng Ming Lin <chengminglin@mxic.com.tw>
Subject: Re: [PATCH v4 1/2] mtd: spi-nand: Add support for randomizer
Date: Wed, 04 Feb 2026 09:33:54 +0100	[thread overview]
Message-ID: <878qd8hpql.fsf@bootlin.com> (raw)
In-Reply-To: <CAAyq3SbZn5Hjx85xMS4cPYaoBccsiCj1obRbLO9eD9_RV=h7RQ@mail.gmail.com> (Cheng Ming Lin's message of "Wed, 4 Feb 2026 09:47:15 +0800")

Hi Cheng Ming,

>> Looking at the current implementation, I really don't like the core
>> always calling in the "init" and the manufacturer driver reading the DT
>> and deciding whether or not it enables it.
>
> I agree. I will refactor the logic in v5 so that the core parses the
> generic DT properties (nand-enable-randomizer and
> nand-disable-randomizer).
>
> Then, spinand_randomizer_init will determine the state and pass a
> boolean argument to the set_randomizer callback, leaving the driver
> to strictly handle the hardware configuration.

Perfect.

Thanks,
Miquèl

  reply	other threads:[~2026-02-04  8:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-03  2:13 [PATCH v4 0/2] mtd: spi-nand: Add support for randomizer feature Cheng Ming Lin
2026-02-03  2:13 ` Cheng Ming Lin
2026-02-03  2:13 ` [PATCH v4 1/2] mtd: spi-nand: Add support for randomizer Cheng Ming Lin
2026-02-03  2:13   ` Cheng Ming Lin
2026-02-03 14:40   ` Miquel Raynal
2026-02-03 14:40     ` Miquel Raynal
2026-02-04  1:47     ` Cheng Ming Lin
2026-02-04  1:47       ` Cheng Ming Lin
2026-02-04  8:33       ` Miquel Raynal [this message]
2026-02-04  8:33         ` Miquel Raynal
2026-02-03  2:13 ` [PATCH v4 2/2] mtd: spi-nand: macronix: Enable randomizer support Cheng Ming Lin
2026-02-03  2:13   ` Cheng Ming Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878qd8hpql.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=alvinzhou@mxic.com.tw \
    --cc=chengminglin@mxic.com.tw \
    --cc=linchengming884@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mikhail.kshevetskiy@iopsys.eu \
    --cc=mmkurbanov@salutedevices.com \
    --cc=pratyush@kernel.org \
    --cc=richard@nod.at \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.