All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
	"Cédric Le Goater" <clg@redhat.com>,
	"Peter Xu" <peterx@redhat.com>,
	qemu-devel@nongnu.org, farosas@suse.de
Subject: Re: g_autoptr(Error)
Date: Wed, 26 Nov 2025 15:01:50 +0100	[thread overview]
Message-ID: <878qfsc2pd.fsf@pond.sub.org> (raw)
In-Reply-To: <CAFEAcA_Xjzp12zB5Gv1pZPJQYicb1GkoHkt6Tt3QQK0n_YQZ5g@mail.gmail.com> (Peter Maydell's message of "Wed, 26 Nov 2025 13:27:28 +0000")

Peter Maydell <peter.maydell@linaro.org> writes:

> On Wed, 26 Nov 2025 at 12:01, Daniel P. Berrangé <berrange@redhat.com> wrote:
>> The other thing that plays in here is that we actively encourage use of
>> g_autoptr everywhere. It is very unusual for "Error" to be a type that
>> does NOT want g_autoptr, and thus the mistake is very much on the cards.
>>
>> I've proposed it before myself & Markus caught it. I also caught one
>> other proposals to add it since my attempt. This third time it slipped
>> through review. I expect we'll see a 4th attempt to add it at some point.
>
> We could add a comment to the header explaining the rationale for
> not providing a g_autoptr handler, so that at least we have it
> written down, and are more likely to remember it when it comes
> up again in future...

Good idea.  I'll take care of it.



  reply	other threads:[~2025-11-26 14:02 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-25  7:05 [PATCH] migration: Fix double-free on error path Markus Armbruster
2025-11-25  7:11 ` Markus Armbruster
2025-11-25 15:41   ` Peter Xu
2025-11-25  7:12 ` Marc-André Lureau
2025-11-25 12:59   ` Markus Armbruster
2025-11-25 15:47     ` Peter Xu
2025-11-25 18:48       ` Markus Armbruster
2025-11-25 19:32         ` Peter Xu
2025-11-26  6:12           ` Should functions that free memory clear the pointer? (was: [PATCH] migration: Fix double-free on error path) Markus Armbruster
2025-11-26  8:21             ` Should functions that free memory clear the pointer? Cédric Le Goater
2025-11-25  7:16 ` [PATCH] migration: Fix double-free on error path Philippe Mathieu-Daudé
2025-11-25  7:40 ` g_autoptr(Error) (was: [PATCH] migration: Fix double-free on error path) Markus Armbruster
2025-11-25 11:25   ` Daniel P. Berrangé
2025-11-25 11:46     ` g_autoptr(Error) Markus Armbruster
2025-11-25 16:15       ` g_autoptr(Error) Peter Xu
2025-11-25 19:02         ` g_autoptr(Error) Markus Armbruster
2025-11-25 20:49           ` g_autoptr(Error) Peter Xu
2025-11-26  8:19         ` g_autoptr(Error) Cédric Le Goater
2025-11-26 10:26           ` g_autoptr(Error) Cédric Le Goater
2025-11-26 11:46             ` g_autoptr(Error) Markus Armbruster
2025-11-26 12:00               ` g_autoptr(Error) Daniel P. Berrangé
2025-11-26 12:41                 ` g_autoptr(Error) Markus Armbruster
2025-11-26 13:27                 ` g_autoptr(Error) Peter Maydell
2025-11-26 14:01                   ` Markus Armbruster [this message]
2025-12-02  8:34 ` [PATCH] migration: Fix double-free on error path Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878qfsc2pd.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=clg@redhat.com \
    --cc=farosas@suse.de \
    --cc=peter.maydell@linaro.org \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.