Re: g_autoptr(Error)

[Markus Armbruster <armbru@redhat.com>]

Cédric Le Goater <clg@redhat.com> writes:

> On 11/26/25 09:19, Cédric Le Goater wrote:
>> On 11/25/25 17:15, Peter Xu wrote:
>>> On Tue, Nov 25, 2025 at 12:46:01PM +0100, Markus Armbruster wrote:

[...]

On the review and merging of commit 18eb55546a5 (error: define
g_autoptr() cleanup function for the Error type):

>>>> I missed it.  Not he submitter's fault; it was cc'ed to me.
>>>
>>> If someone to blame, it's the reviewer.
>> At end, I was the one who merged this stuff. My bad.
>>
>> I felt confident at the time, as it was only a single-line change reviewed
>> by a subsystem maintainer and the patch was large enough that this didn't
>
> s/patch/series/ makes more sense.
>
> Sorry for the noise.

> C.
>
>
>> raise my attention.
>>
>> But it should have been treated with greater caution, global features must
>> be introduced together with concrete usage proposals. I think this would
>> have raised some unconscious red flags.
>> Thanks,
>> C.

Don't worry about it!  From my point of view, the process worked okay.
A big series got reviewed by maintainers, except for one little patch
touching another subsystem, where that subsystem's maintainer (me)
remained silent.  The series was then merged without further delay.

Would I have appreciate a timely nudge on that little patch?  Sure.  Is
not nudging me a failure of sorts?  Nope.