From: Markus Armbruster <armbru@redhat.com>
To: BALATON Zoltan <balaton@eik.bme.hu>
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
"Leif Lindholm" <quic_llindhol@quicinc.com>,
"Marcin Juszkiewicz" <marcin.juszkiewicz@linaro.org>,
"Radoslaw Biernacki" <rad@semihalf.com>,
qemu-arm@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
qemu-block@nongnu.org, "John Snow" <jsnow@redhat.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>
Subject: Re: [PATCH v2 3/3] hw/ide: Include 'ide_internal.h' from current path
Date: Mon, 26 Feb 2024 08:40:37 +0100 [thread overview]
Message-ID: <878r37lll6.fsf@pond.sub.org> (raw)
In-Reply-To: <feffd329-59e0-0291-0dd6-76a625da190b@eik.bme.hu> (BALATON Zoltan's message of "Sun, 25 Feb 2024 21:28:33 +0100 (CET)")
BALATON Zoltan <balaton@eik.bme.hu> writes:
> On Sun, 25 Feb 2024, Philippe Mathieu-Daudé wrote:
>> Rename "internal.h" as "ide_internal.h", and include
>
> Is there a convention about using underscore or dash in file names? The headers Thomas added are using - as well as ahci-allwinner.c, only ahci_internal.h has _ (but there are others elsewhere such as pci_device.h). Maybe we should be consistent at least within IDE and this series is now a good opportunity for renaming these headers to match. But it's just a small nit, thanks for picking this up.
This is one of the many unnecessary inconsistencies we're inflicting on
ourselves.
We have more than 3600 file names containing '-', and more almost 2700
containing '_'. Bizarrely, 68 of them contain both.
I strongly prefer '_' myself.
Zoltan is making a local consistency argument for '-'.
Let's use '-' here.
next prev parent reply other threads:[~2024-02-26 7:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-25 17:16 [PATCH v2 0/3] hw/ide: Make "ide_internal.h" really internal Philippe Mathieu-Daudé
2024-02-25 17:16 ` [PATCH v2 1/3] hw/arm/sbsa-ref: Do not open-code ahci_ide_create_devs() Philippe Mathieu-Daudé
2024-02-25 17:21 ` Philippe Mathieu-Daudé
2024-02-26 6:18 ` Thomas Huth
2024-02-25 17:16 ` [PATCH v2 2/3] hw/ide: Remove last two uses of ide/internal.h outside of hw/ide/ Philippe Mathieu-Daudé
2024-02-25 17:16 ` [PATCH v2 3/3] hw/ide: Include 'ide_internal.h' from current path Philippe Mathieu-Daudé
2024-02-25 20:28 ` BALATON Zoltan
2024-02-26 7:40 ` Markus Armbruster [this message]
2024-02-26 8:00 ` Philippe Mathieu-Daudé
2024-02-26 8:09 ` Philippe Mathieu-Daudé
2024-02-26 10:54 ` BALATON Zoltan
2024-02-26 10:50 ` BALATON Zoltan
2024-02-26 13:43 ` Philippe Mathieu-Daudé
2024-02-26 13:51 ` BALATON Zoltan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878r37lll6.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=balaton@eik.bme.hu \
--cc=jsnow@redhat.com \
--cc=marcin.juszkiewicz@linaro.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=quic_llindhol@quicinc.com \
--cc=rad@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.