All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: "Zhao Ke 赵 可" <ke.zhao@shingroup.cn>,
	npiggin@gmail.com, christophe.leroy@csgroup.eu,
	fbarrat@linux.ibm.com, ajd@linux.ibm.com, arnd@arndb.de,
	gregkh@linuxfoundation.org
Cc: luming.yu@shingroup.cn, kvm@vger.kernel.org,
	dawei.li@shingroup.cn, linux-kernel@vger.kernel.org,
	shenghui.qu@shingroup.cn, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: Add PVN support for HeXin C2000 processor
Date: Wed, 29 Nov 2023 16:28:56 +1100	[thread overview]
Message-ID: <878r6h2kmf.fsf@mail.lhotse> (raw)
In-Reply-To: <52743BC52E07B486+dcb66331-0993-462b-ac03-6de69a3e1fac@shingroup.cn>

Zhao Ke 赵 可 <ke.zhao@shingroup.cn> writes:
> On 2023/11/22 9:46, Michael Ellerman wrote:
>> Zhao Ke <ke.zhao@shingroup.cn> writes:
>>> HeXin Tech Co. has applied for a new PVN from the OpenPower Community
>>> for its new processor C2000. The OpenPower has assigned a new PVN
>>> and this newly assigned PVN is 0x0066, add pvr register related
>>> support for this PVN.
>>>
>>> Signed-off-by: Zhao Ke <ke.zhao@shingroup.cn>
>>> Link: https://discuss.openpower.foundation/t/how-to-get-a-new-pvr-for-processors-follow-power-isa/477/10
>>   
>> Hi Zhao Ke,
>>
>> Thanks for the patch. Just a few questions.
>>
>> Are you able to provide any further detail on the processor?
>>
>> Your cputable entry claims that it's identical to the original Power8
>> core, can you comment at all on how true that is in practice?
>
> Basically, we made lots of design change for the new processor.
>
> For example:
>
>      1. redesign the interconnect of the fabric, from crossbar to mesh
>
>      2. redesign the memory subsystem, including the modification of L2 
> and L3 architecture
>
>      3. redesign the SMP bus
>
>      4. upgrade PCIe to gen5 and increase the number of lanes
>
>      5. upgrade ddr to DDR5, dimm direct connected, and the number of 
> channels
>
>      6. redesign the pervasive architecture, including debug/trace, 
> clock&power management, etc.

OK thanks for the detail.

Given all those changes I think you should not use "Power8" as the CPU
name. Whatever the lineage of the core design is, it's no longer a
literal "Power8", not even the same design using a different process
node.

So I think you should call it "HeXin C2000" or similar.

cheers

WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: "Zhao Ke 赵 可" <ke.zhao@shingroup.cn>,
	npiggin@gmail.com, christophe.leroy@csgroup.eu,
	fbarrat@linux.ibm.com, ajd@linux.ibm.com, arnd@arndb.de,
	gregkh@linuxfoundation.org
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	kvm@vger.kernel.org, shenghui.qu@shingroup.cn,
	luming.yu@shingroup.cn, dawei.li@shingroup.cn
Subject: Re: [PATCH] powerpc: Add PVN support for HeXin C2000 processor
Date: Wed, 29 Nov 2023 16:28:56 +1100	[thread overview]
Message-ID: <878r6h2kmf.fsf@mail.lhotse> (raw)
In-Reply-To: <52743BC52E07B486+dcb66331-0993-462b-ac03-6de69a3e1fac@shingroup.cn>

Zhao Ke 赵 可 <ke.zhao@shingroup.cn> writes:
> On 2023/11/22 9:46, Michael Ellerman wrote:
>> Zhao Ke <ke.zhao@shingroup.cn> writes:
>>> HeXin Tech Co. has applied for a new PVN from the OpenPower Community
>>> for its new processor C2000. The OpenPower has assigned a new PVN
>>> and this newly assigned PVN is 0x0066, add pvr register related
>>> support for this PVN.
>>>
>>> Signed-off-by: Zhao Ke <ke.zhao@shingroup.cn>
>>> Link: https://discuss.openpower.foundation/t/how-to-get-a-new-pvr-for-processors-follow-power-isa/477/10
>>   
>> Hi Zhao Ke,
>>
>> Thanks for the patch. Just a few questions.
>>
>> Are you able to provide any further detail on the processor?
>>
>> Your cputable entry claims that it's identical to the original Power8
>> core, can you comment at all on how true that is in practice?
>
> Basically, we made lots of design change for the new processor.
>
> For example:
>
>      1. redesign the interconnect of the fabric, from crossbar to mesh
>
>      2. redesign the memory subsystem, including the modification of L2 
> and L3 architecture
>
>      3. redesign the SMP bus
>
>      4. upgrade PCIe to gen5 and increase the number of lanes
>
>      5. upgrade ddr to DDR5, dimm direct connected, and the number of 
> channels
>
>      6. redesign the pervasive architecture, including debug/trace, 
> clock&power management, etc.

OK thanks for the detail.

Given all those changes I think you should not use "Power8" as the CPU
name. Whatever the lineage of the core design is, it's no longer a
literal "Power8", not even the same design using a different process
node.

So I think you should call it "HeXin C2000" or similar.

cheers

  reply	other threads:[~2023-11-29  5:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-17  7:52 [PATCH] powerpc: Add PVN support for HeXin C2000 processor Zhao Ke
2023-11-17  7:52 ` Zhao Ke
2023-11-22  1:46 ` Michael Ellerman
2023-11-22  1:46   ` Michael Ellerman
2023-11-22  7:25   ` Zhao Ke 赵 可
2023-11-22  7:25     ` Zhao Ke 赵 可
2023-11-29  5:28     ` Michael Ellerman [this message]
2023-11-29  5:28       ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878r6h2kmf.fsf@mail.lhotse \
    --to=mpe@ellerman.id.au \
    --cc=ajd@linux.ibm.com \
    --cc=arnd@arndb.de \
    --cc=christophe.leroy@csgroup.eu \
    --cc=dawei.li@shingroup.cn \
    --cc=fbarrat@linux.ibm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=ke.zhao@shingroup.cn \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=luming.yu@shingroup.cn \
    --cc=npiggin@gmail.com \
    --cc=shenghui.qu@shingroup.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.