All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: linux-wireless@vger.kernel.org
Cc: ath12k@lists.infradead.org
Subject: Re: [PATCH v2 00/50] wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices
Date: Mon, 28 Nov 2022 16:56:16 +0200	[thread overview]
Message-ID: <878rjv5drj.fsf@kernel.org> (raw)
In-Reply-To: <20221116163902.24996-1-kvalo@kernel.org> (Kalle Valo's message of "Wed, 16 Nov 2022 18:38:12 +0200")

Kalle Valo <kvalo@kernel.org> writes:

> From: Kalle Valo <quic_kvalo@quicinc.com>
>
> ath12k is a new mac80211 driver for Qualcomm Wi-Fi 7 devices, first
> supporting QCN9274 and WCN7850 PCI devices.  QCN9274 supports both AP
> and station; WCN7850 supports only station mode. Monitor mode is not
> (yet) supported. Only PCI bus devices are supported.
>
> ath12k is forked from an earlier version of ath11k. It was simpler to
> have a "clean start" for the new generation and not try to share the
> code with ath11k. This makes maintenance easier and avoids major
> changes in ath11k, which would have significantly increased the risk
> of regressions in existing setups.
>
> ath12k uses le32 and cpu_to_le32() macros to handle endian
> conversions, instead of using the firmware byte swap feature utilized
> by ath11k. There is only one kernel module, named ath12k.ko.
>
> Currently ath12k only supports HE mode (IEEE 802.11ax) or older, but
> work is ongoing to add EHT mode (IEEE 802.11be) support.
>
> The size of the driver is ~41 kLOC and 45 files. To make the review
> easier, this initial version of ath12k does not support Device Tree,
> debugfs or any other extra features. Those will be added later, after
> ath12k is accepted to upstream.
>
> The driver is build tested by Intel's kernel test robot with both GCC
> and Clang. Sparse reports no warnings. The driver is mostly free of
> checkpatch warnings, albeit few of the warnings are omitted on
> purpose, list of them here:
>
> https://github.com/qca/qca-swiss-army-knife/blob/master/tools/scripts/ath12k/ath12k-check#L52
>
> The driver has had multiple authors who are listed in alphabetical
> order below.
>
> Co-developed-by: Balamurugan S <quic_bselvara@quicinc.com>
> Signed-off-by: Balamurugan S <quic_bselvara@quicinc.com>
> Co-developed-by: Balamurugan Selvarajan <quic_bselvara@quicinc.com>
> Signed-off-by: Balamurugan Selvarajan <quic_bselvara@quicinc.com>

I noticed that Balamurugan is twice here, fixed in the pending branch:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=master-pending&id=b644733d58cb65d2e319bad0e0f89a852021c5c2

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath12k mailing list
ath12k@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/ath12k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org>
To: linux-wireless@vger.kernel.org
Cc: ath12k@lists.infradead.org
Subject: Re: [PATCH v2 00/50] wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices
Date: Mon, 28 Nov 2022 16:56:16 +0200	[thread overview]
Message-ID: <878rjv5drj.fsf@kernel.org> (raw)
In-Reply-To: <20221116163902.24996-1-kvalo@kernel.org> (Kalle Valo's message of "Wed, 16 Nov 2022 18:38:12 +0200")

Kalle Valo <kvalo@kernel.org> writes:

> From: Kalle Valo <quic_kvalo@quicinc.com>
>
> ath12k is a new mac80211 driver for Qualcomm Wi-Fi 7 devices, first
> supporting QCN9274 and WCN7850 PCI devices.  QCN9274 supports both AP
> and station; WCN7850 supports only station mode. Monitor mode is not
> (yet) supported. Only PCI bus devices are supported.
>
> ath12k is forked from an earlier version of ath11k. It was simpler to
> have a "clean start" for the new generation and not try to share the
> code with ath11k. This makes maintenance easier and avoids major
> changes in ath11k, which would have significantly increased the risk
> of regressions in existing setups.
>
> ath12k uses le32 and cpu_to_le32() macros to handle endian
> conversions, instead of using the firmware byte swap feature utilized
> by ath11k. There is only one kernel module, named ath12k.ko.
>
> Currently ath12k only supports HE mode (IEEE 802.11ax) or older, but
> work is ongoing to add EHT mode (IEEE 802.11be) support.
>
> The size of the driver is ~41 kLOC and 45 files. To make the review
> easier, this initial version of ath12k does not support Device Tree,
> debugfs or any other extra features. Those will be added later, after
> ath12k is accepted to upstream.
>
> The driver is build tested by Intel's kernel test robot with both GCC
> and Clang. Sparse reports no warnings. The driver is mostly free of
> checkpatch warnings, albeit few of the warnings are omitted on
> purpose, list of them here:
>
> https://github.com/qca/qca-swiss-army-knife/blob/master/tools/scripts/ath12k/ath12k-check#L52
>
> The driver has had multiple authors who are listed in alphabetical
> order below.
>
> Co-developed-by: Balamurugan S <quic_bselvara@quicinc.com>
> Signed-off-by: Balamurugan S <quic_bselvara@quicinc.com>
> Co-developed-by: Balamurugan Selvarajan <quic_bselvara@quicinc.com>
> Signed-off-by: Balamurugan Selvarajan <quic_bselvara@quicinc.com>

I noticed that Balamurugan is twice here, fixed in the pending branch:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=master-pending&id=b644733d58cb65d2e319bad0e0f89a852021c5c2

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  parent reply	other threads:[~2022-11-28 14:56 UTC|newest]

Thread overview: 114+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-16 16:38 [PATCH v2 00/50] wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices Kalle Valo
2022-11-16 16:38 ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 01/50] wifi: ath12k: add Kconfig Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 02/50] wifi: ath12k: add Makefile Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 03/50] wifi: ath12k: add ce.c Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 04/50] wifi: ath12k: add ce.h Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 05/50] wifi: ath12k: add core.c Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 06/50] wifi: ath12k: add core.h Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 07/50] wifi: ath12k: add dbring.c Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 08/50] wifi: ath12k: add dbring.h Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 09/50] wifi: ath12k: add debug.c Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 10/50] wifi: ath12k: add debug.h Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 11/50] wifi: ath12k: add dp.c Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 12/50] wifi: ath12k: add dp.h Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 13/50] wifi: ath12k: add dp_mon.c Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 14/50] wifi: ath12k: add dp_mon.h Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 15/50] wifi: ath12k: add dp_rx.c Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 16/50] wifi: ath12k: add dp_rx.h Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 17/50] wifi: ath12k: add dp_tx.c Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 18/50] wifi: ath12k: add dp_tx.h Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 19/50] wifi: ath12k: add hal.c Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 20/50] wifi: ath12k: add hal.h Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 21/50] wifi: ath12k: add hal_desc.h Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 22/50] wifi: ath12k: add hal_rx.c Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 23/50] wifi: ath12k: add hal_rx.h Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 24/50] wifi: ath12k: add hal_tx.c Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 25/50] wifi: ath12k: add hal_tx.h Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 26/50] wifi: ath12k: add hif.h Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 27/50] wifi: ath12k: add htc.c Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 28/50] wifi: ath12k: add htc.h Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 29/50] wifi: ath12k: add hw.c Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 30/50] wifi: ath12k: add hw.h Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 31/50] wifi: ath12k: add mac.c Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 32/50] wifi: ath12k: add mac.h Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 33/50] wifi: ath12k: add mhi.c Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 34/50] wifi: ath12k: add mhi.h Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 35/50] wifi: ath12k: add pci.c Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 36/50] wifi: ath12k: add pci.h Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 37/50] wifi: ath12k: add peer.c Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 38/50] wifi: ath12k: add peer.h Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 39/50] wifi: ath12k: add qmi.c Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 40/50] wifi: ath12k: add qmi.h Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 41/50] wifi: ath12k: add reg.c Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-21 16:27   ` Nicolas Cavallari
2022-11-21 16:27     ` Nicolas Cavallari
2022-11-24 10:07     ` Sriram R (QUIC)
2022-11-24 10:07       ` Sriram R (QUIC)
2022-11-16 16:38 ` [PATCH v2 42/50] wifi: ath12k: add reg.h Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 43/50] wifi: ath12k: add rx_desc.h Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 44/50] wifi: ath12k: add trace.c Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 45/50] wifi: ath12k: add trace.h Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 46/50] wifi: ath12k: add wmi.c Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:38 ` [PATCH v2 47/50] wifi: ath12k: add wmi.h Kalle Valo
2022-11-16 16:38   ` Kalle Valo
2022-11-16 16:39 ` [PATCH v2 48/50] wifi: ath: add ath12k to Makefile Kalle Valo
2022-11-16 16:39   ` Kalle Valo
2022-11-16 16:39 ` [PATCH v2 49/50] wifi: ath: add ath12k to Kconfig Kalle Valo
2022-11-16 16:39   ` Kalle Valo
2022-11-16 16:39 ` [PATCH v2 50/50] MAINTAINERS: add ath12k Kalle Valo
2022-11-16 16:39   ` Kalle Valo
2022-11-21 15:57 ` [PATCH v2 00/50] wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices Kalle Valo
2022-11-21 15:57   ` Kalle Valo
2022-11-25 11:06   ` Kalle Valo
2022-11-25 11:06     ` Kalle Valo
2022-11-28 14:56 ` Kalle Valo [this message]
2022-11-28 14:56   ` Kalle Valo
2022-11-29 11:10   ` Kalle Valo
2022-11-29 11:10     ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878rjv5drj.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=ath12k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.