From: Kalle Valo <kvalo@kernel.org>
To: Ruan Jinjie <ruanjinjie@huawei.com>
Cc: Franky Lin <franky.lin@broadcom.com>, <aspriel@gmail.com>,
<hante.meuleman@broadcom.com>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<marcan@marcan.st>, <linus.walleij@linaro.org>,
<rmk+kernel@armlinux.org.uk>, <soontak.lee@cypress.com>,
<linux-wireless@vger.kernel.org>,
<SHA-cyfmac-dev-list@infineon.com>,
<brcm80211-dev-list.pdl@broadcom.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] wifi: brcmfmac: pcie: add missing pci_disable_device() in brcmf_pcie_get_resource()
Date: Mon, 26 Sep 2022 10:58:45 +0300 [thread overview]
Message-ID: <878rm64le2.fsf@kernel.org> (raw)
In-Reply-To: <b5e39818-2961-ba3d-8552-f618c19f8fe6@huawei.com> (Ruan Jinjie's message of "Sat, 24 Sep 2022 09:00:12 +0800")
Ruan Jinjie <ruanjinjie@huawei.com> writes:
> On 2022/9/24 0:50, Franky Lin wrote:
>> On Fri, Sep 23, 2022 at 2:42 AM ruanjinjie <ruanjinjie@huawei.com> wrote:
>>>
>>> Add missing pci_disable_device() if brcmf_pcie_get_resource() fails.
>>
>> Did you encounter any issue because of the absensent
>> pci_disable_device? A bit more context will be very helpful.
>>
>
> We use static analysis via coccinelle to find the above issue. The
> command we use is below:
>
> spatch -I include -timeout 60 -very_quiet -sp_file
> pci_disable_device_missing.cocci
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
Please include this information to the commit log, it helps to
understand the background of the fix.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-09-26 8:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 9:38 [PATCH -next] wifi: brcmfmac: pcie: add missing pci_disable_device() in brcmf_pcie_get_resource() ruanjinjie
2022-09-23 16:50 ` Franky Lin
2022-09-24 1:00 ` Ruan Jinjie
2022-09-26 7:58 ` Kalle Valo [this message]
2022-09-26 8:06 ` Ruan Jinjie
2022-09-24 2:54 ` Ruan Jinjie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rm64le2.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=SHA-cyfmac-dev-list@infineon.com \
--cc=aspriel@gmail.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=ruanjinjie@huawei.com \
--cc=soontak.lee@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.