From: Takashi Iwai <tiwai@suse.de>
To: Mohan Kumar <mkumard@nvidia.com>
Cc: <tiwai@suse.com>, <perex@perex.cz>, <cezary.rojewski@intel.com>,
<treding@nvidia.com>, <jonathanh@nvidia.com>,
<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
<linux-tegra@vger.kernel.org>
Subject: Re: [PATCH] ALSA: hda: Fix crash due to jack poll in suspend
Date: Thu, 11 Aug 2022 07:46:35 +0200 [thread overview]
Message-ID: <878rnvuybo.wl-tiwai@suse.de> (raw)
In-Reply-To: <20220811052704.2944-1-mkumard@nvidia.com>
On Thu, 11 Aug 2022 07:27:04 +0200,
Mohan Kumar wrote:
>
> With jackpoll_in_suspend flag set, there is a possibility that
> jack poll worker thread will run even after system suspend was
> completed. Any register access after system pm callback flow
> will result in kernel crash as still jack poll worker thread
> tries to access registers.
>
> To fix the crash issue during system flow, cancel the jack poll
> worker thread during system pm prepare callback and cancel the
> worker thread at start of runtime suspend callback and re-schedule
> at last to avoid any unwarranted access of register by worker thread
> during suspend flow.
>
> Signed-off-by: Mohan Kumar <mkumard@nvidia.com>
Thanks, applied now with Fixes tag.
Takashi
prev parent reply other threads:[~2022-08-11 5:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 5:27 [PATCH] ALSA: hda: Fix crash due to jack poll in suspend Mohan Kumar
2022-08-11 5:27 ` Mohan Kumar
2022-08-11 5:46 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rnvuybo.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=cezary.rojewski@intel.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkumard@nvidia.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.