From: Nathan Lynch <nathanl@linux.ibm.com>
To: Laurent Dufour <ldufour@linux.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] powerpc/pseries: read the lpar name from the firmware
Date: Tue, 07 Dec 2021 11:07:50 -0600 [thread overview]
Message-ID: <878rwwny1l.fsf@linux.ibm.com> (raw)
In-Reply-To: <bbaa0d78-a09f-3ce3-25a9-67434039b741@linux.ibm.com>
Laurent Dufour <ldufour@linux.ibm.com> writes:
> On 07/12/2021, 15:32:39, Nathan Lynch wrote:
>> Is there a reasonable fallback for VMs where this parameter doesn't
>> exist? PowerVM partitions should always have it, but what do we want the
>> behavior to be on other hypervisors?
>
> In that case, there is no value displayed in the /proc/powerpc/lparcfg and
> the lparstat -i command will fall back to the device tree value. I can't
> see any valid reason to report the value defined in the device tree
> here.
Here's a valid reason :-)
lparstat isn't the only possible consumer of the interface, and the
'ibm,partition-name' property and the dynamic system parameter clearly
serve a common purpose. 'ibm,partition-name' is provided by qemu.
In any case, the function should not print an error when the return
value is -3 (parameter not supported).
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Lynch <nathanl@linux.ibm.com>
To: Laurent Dufour <ldufour@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v3] powerpc/pseries: read the lpar name from the firmware
Date: Tue, 07 Dec 2021 11:07:50 -0600 [thread overview]
Message-ID: <878rwwny1l.fsf@linux.ibm.com> (raw)
In-Reply-To: <bbaa0d78-a09f-3ce3-25a9-67434039b741@linux.ibm.com>
Laurent Dufour <ldufour@linux.ibm.com> writes:
> On 07/12/2021, 15:32:39, Nathan Lynch wrote:
>> Is there a reasonable fallback for VMs where this parameter doesn't
>> exist? PowerVM partitions should always have it, but what do we want the
>> behavior to be on other hypervisors?
>
> In that case, there is no value displayed in the /proc/powerpc/lparcfg and
> the lparstat -i command will fall back to the device tree value. I can't
> see any valid reason to report the value defined in the device tree
> here.
Here's a valid reason :-)
lparstat isn't the only possible consumer of the interface, and the
'ibm,partition-name' property and the dynamic system parameter clearly
serve a common purpose. 'ibm,partition-name' is provided by qemu.
In any case, the function should not print an error when the return
value is -3 (parameter not supported).
next prev parent reply other threads:[~2021-12-07 17:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 15:43 [PATCH v3] powerpc/pseries: read the lpar name from the firmware Laurent Dufour
2021-12-03 15:43 ` Laurent Dufour
2021-12-07 14:32 ` Nathan Lynch
2021-12-07 14:32 ` Nathan Lynch
2021-12-07 16:07 ` Laurent Dufour
2021-12-07 16:07 ` Laurent Dufour
2021-12-07 17:07 ` Nathan Lynch [this message]
2021-12-07 17:07 ` Nathan Lynch
2021-12-07 17:18 ` Laurent Dufour
2021-12-07 17:18 ` Laurent Dufour
2021-12-07 17:24 ` Laurent Dufour
2021-12-08 15:21 ` Nathan Lynch
2021-12-08 15:21 ` Nathan Lynch
2021-12-09 8:54 ` Laurent Dufour
2021-12-09 8:54 ` Laurent Dufour
2021-12-09 13:53 ` Nathan Lynch
2021-12-09 13:53 ` Nathan Lynch
2021-12-09 15:59 ` Laurent Dufour
2021-12-09 15:59 ` Laurent Dufour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rwwny1l.fsf@linux.ibm.com \
--to=nathanl@linux.ibm.com \
--cc=ldufour@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.