From: Marc Zyngier <maz@kernel.org>
To: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Joel Fernandes <joelaf@google.com>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Suleiman Souhlal <suleiman@google.com>,
Will Deacon <will@kernel.org>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv2 1/4] arm64: smccc: Add SMCCC pv-vcpu-state function call IDs
Date: Mon, 12 Jul 2021 15:22:40 +0100 [thread overview]
Message-ID: <878s2b393j.wl-maz@kernel.org> (raw)
In-Reply-To: <20210709043713.887098-2-senozhatsky@chromium.org>
On Fri, 09 Jul 2021 05:37:10 +0100,
Sergey Senozhatsky <senozhatsky@chromium.org> wrote:
>
> Add the definitions of the SMCCC functions that will be
> used to paravirt VCPU state configuration.
>
> Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
> ---
> include/linux/arm-smccc.h | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/include/linux/arm-smccc.h b/include/linux/arm-smccc.h
> index 7d1cabe15262..dbf0d658e54a 100644
> --- a/include/linux/arm-smccc.h
> +++ b/include/linux/arm-smccc.h
> @@ -177,6 +177,24 @@
> ARM_SMCCC_OWNER_STANDARD, \
> 0x53)
>
> +#define ARM_SMCCC_HV_PV_VCPU_STATE_FEATURES \
> + ARM_SMCCC_CALL_VAL(ARM_SMCCC_FAST_CALL, \
> + ARM_SMCCC_SMC_64, \
> + ARM_SMCCC_OWNER_STANDARD_HYP, \
> + 0x60)
> +
> +#define ARM_SMCCC_HV_PV_VCPU_STATE_INIT \
> + ARM_SMCCC_CALL_VAL(ARM_SMCCC_FAST_CALL, \
> + ARM_SMCCC_SMC_64, \
> + ARM_SMCCC_OWNER_STANDARD_HYP, \
> + 0x61)
> +
> +#define ARM_SMCCC_HV_PV_VCPU_STATE_RELEASE \
> + ARM_SMCCC_CALL_VAL(ARM_SMCCC_FAST_CALL, \
> + ARM_SMCCC_SMC_64, \
> + ARM_SMCCC_OWNER_STANDARD_HYP, \
> + 0x62)
> +
This is definitely the *wrong* namespace for this. The "STANDARD_HYP"
space is owned by ARM for hypercalls that are implementable by any
hypervisors, and for which there is an ARM-owned specification.
Unless you plan to get this adopted as an ARM spec (pretty doubtful),
this should go instead in the KVM-specific space, which currently has
a single user (the PTP stuff), although I plan to add a couple more
shortly.
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Will Deacon <will@kernel.org>,
Suleiman Souhlal <suleiman@google.com>,
Joel Fernandes <joelaf@google.com>,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCHv2 1/4] arm64: smccc: Add SMCCC pv-vcpu-state function call IDs
Date: Mon, 12 Jul 2021 15:22:40 +0100 [thread overview]
Message-ID: <878s2b393j.wl-maz@kernel.org> (raw)
In-Reply-To: <20210709043713.887098-2-senozhatsky@chromium.org>
On Fri, 09 Jul 2021 05:37:10 +0100,
Sergey Senozhatsky <senozhatsky@chromium.org> wrote:
>
> Add the definitions of the SMCCC functions that will be
> used to paravirt VCPU state configuration.
>
> Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
> ---
> include/linux/arm-smccc.h | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/include/linux/arm-smccc.h b/include/linux/arm-smccc.h
> index 7d1cabe15262..dbf0d658e54a 100644
> --- a/include/linux/arm-smccc.h
> +++ b/include/linux/arm-smccc.h
> @@ -177,6 +177,24 @@
> ARM_SMCCC_OWNER_STANDARD, \
> 0x53)
>
> +#define ARM_SMCCC_HV_PV_VCPU_STATE_FEATURES \
> + ARM_SMCCC_CALL_VAL(ARM_SMCCC_FAST_CALL, \
> + ARM_SMCCC_SMC_64, \
> + ARM_SMCCC_OWNER_STANDARD_HYP, \
> + 0x60)
> +
> +#define ARM_SMCCC_HV_PV_VCPU_STATE_INIT \
> + ARM_SMCCC_CALL_VAL(ARM_SMCCC_FAST_CALL, \
> + ARM_SMCCC_SMC_64, \
> + ARM_SMCCC_OWNER_STANDARD_HYP, \
> + 0x61)
> +
> +#define ARM_SMCCC_HV_PV_VCPU_STATE_RELEASE \
> + ARM_SMCCC_CALL_VAL(ARM_SMCCC_FAST_CALL, \
> + ARM_SMCCC_SMC_64, \
> + ARM_SMCCC_OWNER_STANDARD_HYP, \
> + 0x62)
> +
This is definitely the *wrong* namespace for this. The "STANDARD_HYP"
space is owned by ARM for hypercalls that are implementable by any
hypervisors, and for which there is an ARM-owned specification.
Unless you plan to get this adopted as an ARM spec (pretty doubtful),
this should go instead in the KVM-specific space, which currently has
a single user (the PTP stuff), although I plan to add a couple more
shortly.
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Will Deacon <will@kernel.org>,
Suleiman Souhlal <suleiman@google.com>,
Joel Fernandes <joelaf@google.com>,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCHv2 1/4] arm64: smccc: Add SMCCC pv-vcpu-state function call IDs
Date: Mon, 12 Jul 2021 15:22:40 +0100 [thread overview]
Message-ID: <878s2b393j.wl-maz@kernel.org> (raw)
In-Reply-To: <20210709043713.887098-2-senozhatsky@chromium.org>
On Fri, 09 Jul 2021 05:37:10 +0100,
Sergey Senozhatsky <senozhatsky@chromium.org> wrote:
>
> Add the definitions of the SMCCC functions that will be
> used to paravirt VCPU state configuration.
>
> Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
> ---
> include/linux/arm-smccc.h | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/include/linux/arm-smccc.h b/include/linux/arm-smccc.h
> index 7d1cabe15262..dbf0d658e54a 100644
> --- a/include/linux/arm-smccc.h
> +++ b/include/linux/arm-smccc.h
> @@ -177,6 +177,24 @@
> ARM_SMCCC_OWNER_STANDARD, \
> 0x53)
>
> +#define ARM_SMCCC_HV_PV_VCPU_STATE_FEATURES \
> + ARM_SMCCC_CALL_VAL(ARM_SMCCC_FAST_CALL, \
> + ARM_SMCCC_SMC_64, \
> + ARM_SMCCC_OWNER_STANDARD_HYP, \
> + 0x60)
> +
> +#define ARM_SMCCC_HV_PV_VCPU_STATE_INIT \
> + ARM_SMCCC_CALL_VAL(ARM_SMCCC_FAST_CALL, \
> + ARM_SMCCC_SMC_64, \
> + ARM_SMCCC_OWNER_STANDARD_HYP, \
> + 0x61)
> +
> +#define ARM_SMCCC_HV_PV_VCPU_STATE_RELEASE \
> + ARM_SMCCC_CALL_VAL(ARM_SMCCC_FAST_CALL, \
> + ARM_SMCCC_SMC_64, \
> + ARM_SMCCC_OWNER_STANDARD_HYP, \
> + 0x62)
> +
This is definitely the *wrong* namespace for this. The "STANDARD_HYP"
space is owned by ARM for hypercalls that are implementable by any
hypervisors, and for which there is an ARM-owned specification.
Unless you plan to get this adopted as an ARM spec (pretty doubtful),
this should go instead in the KVM-specific space, which currently has
a single user (the PTP stuff), although I plan to add a couple more
shortly.
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2021-07-12 14:22 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 4:37 [PATCHv2 0/4] arm64:kvm: teach guest sched that VCPUs can be preempted Sergey Senozhatsky
2021-07-09 4:37 ` Sergey Senozhatsky
2021-07-09 4:37 ` Sergey Senozhatsky
2021-07-09 4:37 ` [PATCHv2 1/4] arm64: smccc: Add SMCCC pv-vcpu-state function call IDs Sergey Senozhatsky
2021-07-09 4:37 ` Sergey Senozhatsky
2021-07-09 4:37 ` Sergey Senozhatsky
2021-07-12 14:22 ` Marc Zyngier [this message]
2021-07-12 14:22 ` Marc Zyngier
2021-07-12 14:22 ` Marc Zyngier
2021-07-09 4:37 ` [PATCHv2 2/4] arm64: add guest pvstate support Sergey Senozhatsky
2021-07-09 4:37 ` Sergey Senozhatsky
2021-07-09 4:37 ` Sergey Senozhatsky
2021-07-09 7:39 ` David Edmondson
2021-07-09 7:39 ` David Edmondson
2021-07-09 7:39 ` David Edmondson
2021-07-09 7:52 ` Sergey Senozhatsky
2021-07-09 7:52 ` Sergey Senozhatsky
2021-07-09 7:52 ` Sergey Senozhatsky
2021-07-09 18:58 ` Joel Fernandes
2021-07-09 18:58 ` Joel Fernandes
2021-07-09 18:58 ` Joel Fernandes
2021-07-09 21:53 ` Sergey Senozhatsky
2021-07-09 21:53 ` Sergey Senozhatsky
2021-07-09 21:53 ` Sergey Senozhatsky
2021-07-11 16:58 ` Joel Fernandes
2021-07-11 16:58 ` Joel Fernandes
2021-07-11 16:58 ` Joel Fernandes
2021-07-12 15:42 ` Marc Zyngier
2021-07-12 15:42 ` Marc Zyngier
2021-07-12 15:42 ` Marc Zyngier
2021-07-21 2:05 ` Sergey Senozhatsky
2021-07-21 2:05 ` Sergey Senozhatsky
2021-07-21 2:05 ` Sergey Senozhatsky
2021-07-21 8:22 ` Marc Zyngier
2021-07-21 8:22 ` Marc Zyngier
2021-07-21 8:22 ` Marc Zyngier
2021-07-21 8:47 ` Sergey Senozhatsky
2021-07-21 8:47 ` Sergey Senozhatsky
2021-07-21 8:47 ` Sergey Senozhatsky
2021-07-21 10:16 ` Marc Zyngier
2021-07-21 10:16 ` Marc Zyngier
2021-07-21 10:16 ` Marc Zyngier
2021-07-09 4:37 ` [PATCHv2 3/4] arm64: do not use dummy vcpu_is_preempted() Sergey Senozhatsky
2021-07-09 4:37 ` Sergey Senozhatsky
2021-07-09 4:37 ` Sergey Senozhatsky
2021-07-12 15:47 ` Marc Zyngier
2021-07-12 15:47 ` Marc Zyngier
2021-07-12 15:47 ` Marc Zyngier
2021-07-21 2:06 ` Sergey Senozhatsky
2021-07-21 2:06 ` Sergey Senozhatsky
2021-07-21 2:06 ` Sergey Senozhatsky
2021-07-09 4:37 ` [PATCHv2 4/4] arm64: add host pv-vcpu-state support Sergey Senozhatsky
2021-07-09 4:37 ` Sergey Senozhatsky
2021-07-09 4:37 ` Sergey Senozhatsky
2021-07-12 16:24 ` Marc Zyngier
2021-07-12 16:24 ` Marc Zyngier
2021-07-12 16:24 ` Marc Zyngier
2021-07-20 18:44 ` Joel Fernandes
2021-07-20 18:44 ` Joel Fernandes
2021-07-20 18:44 ` Joel Fernandes
2021-07-21 8:40 ` Marc Zyngier
2021-07-21 8:40 ` Marc Zyngier
2021-07-21 8:40 ` Marc Zyngier
2021-07-21 10:38 ` Sergey Senozhatsky
2021-07-21 10:38 ` Sergey Senozhatsky
2021-07-21 10:38 ` Sergey Senozhatsky
2021-07-21 11:08 ` Marc Zyngier
2021-07-21 11:08 ` Marc Zyngier
2021-07-21 11:08 ` Marc Zyngier
2021-07-21 1:15 ` Sergey Senozhatsky
2021-07-21 1:15 ` Sergey Senozhatsky
2021-07-21 1:15 ` Sergey Senozhatsky
2021-07-21 9:10 ` Marc Zyngier
2021-07-21 9:10 ` Marc Zyngier
2021-07-21 9:10 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878s2b393j.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=joelaf@google.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=senozhatsky@chromium.org \
--cc=suleiman@google.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.