From: Felipe Balbi <balbi@kernel.org>
To: Peter Chen <peter.chen@nxp.com>, pawell@cadence.com, rogerq@ti.com
Cc: linux-usb@vger.kernel.org, linux-imx@nxp.com,
gregkh@linuxfoundation.org, jun.li@nxp.com,
stable@vger.kernel.org, Peter Chen <peter.chen@nxp.com>
Subject: Re: [PATCH v2 3/3] usb: cdns3: Fix on-chip memory overflow issue
Date: Tue, 27 Oct 2020 11:27:48 +0200 [thread overview]
Message-ID: <878sbsc92j.fsf@kernel.org> (raw)
In-Reply-To: <20201022005505.24167-4-peter.chen@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 1200 bytes --]
Hi,
Peter Chen <peter.chen@nxp.com> writes:
> From: Pawel Laszczak <pawell@cadence.com>
>
> Patch fixes issue caused setting On-chip memory overflow bit in usb_sts
> register. The issue occurred because EP_CFG register was set twice
> before USB_STS.CFGSTS was set. Every write operation on EP_CFG.BUFFERING
> causes that controller increases internal counter holding the number
> of reserved on-chip buffers. First time this register was updated in
> function cdns3_ep_config before delegating SET_CONFIGURATION request
> to class driver and again it was updated when class wanted to enable
> endpoint. This patch fixes this issue by configuring endpoints
> enabled by class driver in cdns3_gadget_ep_enable and others just
> before status stage.
>
> Cc: <stable@vger.kernel.org> #v5.8+
> Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver")
> Reported-and-tested-by: Peter Chen <peter.chen@nxp.com>
> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
comment from previous thread is still valid. Far too extensive change to
qualify for stable or -rc. Sure there isn't a minimal patch possible?
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
next prev parent reply other threads:[~2020-10-27 9:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 0:55 [PATCH v2 0/3] usb: cdns3: three bug fixes for v5.10 Peter Chen
2020-10-22 0:55 ` [PATCH v2 1/3] usb: cdns3: gadget: suspicious implicit sign extension Peter Chen
2020-10-22 0:55 ` [PATCH v2 2/3] usb: cdns3: gadget: own the lock wrongly at the suspend routine Peter Chen
2020-10-27 9:26 ` Felipe Balbi
2020-10-29 9:31 ` Peter Chen
2020-10-22 0:55 ` [PATCH v2 3/3] usb: cdns3: Fix on-chip memory overflow issue Peter Chen
2020-10-27 9:27 ` Felipe Balbi [this message]
2020-10-27 11:21 ` Pawel Laszczak
2020-10-28 9:07 ` [PATCH v2 0/3] usb: cdns3: three bug fixes for v5.10 Greg KH
2020-10-28 9:33 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878sbsc92j.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jun.li@nxp.com \
--cc=linux-imx@nxp.com \
--cc=linux-usb@vger.kernel.org \
--cc=pawell@cadence.com \
--cc=peter.chen@nxp.com \
--cc=rogerq@ti.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.