From: Felipe Balbi <balbi@kernel.org>
To: Peter Chen <peter.chen@nxp.com>, pawell@cadence.com, rogerq@ti.com
Cc: linux-usb@vger.kernel.org, linux-imx@nxp.com,
gregkh@linuxfoundation.org, jun.li@nxp.com,
Peter Chen <peter.chen@nxp.com>
Subject: Re: [PATCH v2 2/3] usb: cdns3: gadget: own the lock wrongly at the suspend routine
Date: Tue, 27 Oct 2020 11:26:56 +0200 [thread overview]
Message-ID: <87blgoc93z.fsf@kernel.org> (raw)
In-Reply-To: <20201022005505.24167-3-peter.chen@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 790 bytes --]
Peter Chen <peter.chen@nxp.com> writes:
> When the system goes to suspend, if the controller is at device mode with
> cable connecting to host, the call stack is: cdns3_suspend->
> cdns3_gadget_suspend -> cdns3_disconnect_gadget, after cdns3_disconnect_gadget
> is called, it owns lock wrongly, it causes the system being deadlock after
> resume due to at cdns3_device_thread_irq_handler, it tries to get the lock,
> but can't get it forever.
>
> To fix it, we delete the unlock-lock operations at cdns3_disconnect_gadget,
> and do it at the caller.
>
> Fixes: b1234e3b3b26 ("usb: cdns3: add runtime PM support")
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
comment from previous thread is still valid. Missing __releases() and
__acquires() annotation.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
next prev parent reply other threads:[~2020-10-27 9:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 0:55 [PATCH v2 0/3] usb: cdns3: three bug fixes for v5.10 Peter Chen
2020-10-22 0:55 ` [PATCH v2 1/3] usb: cdns3: gadget: suspicious implicit sign extension Peter Chen
2020-10-22 0:55 ` [PATCH v2 2/3] usb: cdns3: gadget: own the lock wrongly at the suspend routine Peter Chen
2020-10-27 9:26 ` Felipe Balbi [this message]
2020-10-29 9:31 ` Peter Chen
2020-10-22 0:55 ` [PATCH v2 3/3] usb: cdns3: Fix on-chip memory overflow issue Peter Chen
2020-10-27 9:27 ` Felipe Balbi
2020-10-27 11:21 ` Pawel Laszczak
2020-10-28 9:07 ` [PATCH v2 0/3] usb: cdns3: three bug fixes for v5.10 Greg KH
2020-10-28 9:33 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blgoc93z.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jun.li@nxp.com \
--cc=linux-imx@nxp.com \
--cc=linux-usb@vger.kernel.org \
--cc=pawell@cadence.com \
--cc=peter.chen@nxp.com \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.