* Re: [RFC PATCH] docs/devel: add some notes on tcg-icount for developers
2020-06-19 13:58 [RFC PATCH] docs/devel: add some notes on tcg-icount for developers Alex Bennée
@ 2020-06-19 14:50 ` no-reply
2020-06-19 14:51 ` no-reply
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: no-reply @ 2020-06-19 14:50 UTC (permalink / raw)
To: alex.bennee
Cc: peter.maydell, richard.henderson, qemu-devel, dovgaluk, pbonzini,
alex.bennee
Patchew URL: https://patchew.org/QEMU/20200619135844.23307-1-alex.bennee@linaro.org/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#! /bin/bash
export ARCH=x86_64
make docker-image-fedora V=1 NETWORK=1
time make docker-test-mingw@fedora J=14 NETWORK=1
=== TEST SCRIPT END ===
CC crypto/tlscredsx509.o
CC crypto/tlssession.o
Warning, treated as error:
/tmp/qemu-test/src/docs/devel/tcg-icount.rst:document isn't included in any toctree
CC crypto/secret_common.o
CC crypto/secret.o
---
CC qom/qom-qobject.o
CC qom/object_interfaces.o
CC qemu-io.o
make: *** [Makefile:1088: docs/devel/index.html] Error 2
make: *** Waiting for unfinished jobs....
Traceback (most recent call last):
File "./tests/docker/docker.py", line 669, in <module>
---
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=22d5a51c49734f0fbfca837a9ba20368', '-u', '1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-r_d8dc9j/src/docker-src.2020-06-19-10.47.26.31220:/var/tmp/qemu:z,ro', 'qemu:fedora', '/var/tmp/qemu/run', 'test-mingw']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=22d5a51c49734f0fbfca837a9ba20368
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-r_d8dc9j/src'
make: *** [docker-run-test-mingw@fedora] Error 2
real 2m44.378s
user 0m8.422s
The full log is available at
http://patchew.org/logs/20200619135844.23307-1-alex.bennee@linaro.org/testing.docker-mingw@fedora/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [RFC PATCH] docs/devel: add some notes on tcg-icount for developers
2020-06-19 13:58 [RFC PATCH] docs/devel: add some notes on tcg-icount for developers Alex Bennée
2020-06-19 14:50 ` no-reply
@ 2020-06-19 14:51 ` no-reply
2020-06-19 14:54 ` Peter Maydell
2020-06-19 14:55 ` no-reply
3 siblings, 0 replies; 7+ messages in thread
From: no-reply @ 2020-06-19 14:51 UTC (permalink / raw)
To: alex.bennee
Cc: peter.maydell, richard.henderson, qemu-devel, dovgaluk, pbonzini,
alex.bennee
Patchew URL: https://patchew.org/QEMU/20200619135844.23307-1-alex.bennee@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [RFC PATCH] docs/devel: add some notes on tcg-icount for developers
Type: series
Message-id: 20200619135844.23307-1-alex.bennee@linaro.org
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Switched to a new branch 'test'
2cb15db docs/devel: add some notes on tcg-icount for developers
=== OUTPUT BEGIN ===
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21:
new file mode 100644
ERROR: trailing whitespace
#95: FILE: docs/devel/tcg-icount.rst:70:
+ $
ERROR: trailing whitespace
#96: FILE: docs/devel/tcg-icount.rst:71:
+.. [1] sometimes two instructions if dealing with delay slots $
total: 2 errors, 1 warnings, 86 lines checked
Commit 2cb15db2a94c (docs/devel: add some notes on tcg-icount for developers) has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20200619135844.23307-1-alex.bennee@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RFC PATCH] docs/devel: add some notes on tcg-icount for developers
2020-06-19 13:58 [RFC PATCH] docs/devel: add some notes on tcg-icount for developers Alex Bennée
2020-06-19 14:50 ` no-reply
2020-06-19 14:51 ` no-reply
@ 2020-06-19 14:54 ` Peter Maydell
2020-06-19 15:44 ` Paolo Bonzini
2020-06-19 15:54 ` Alex Bennée
2020-06-19 14:55 ` no-reply
3 siblings, 2 replies; 7+ messages in thread
From: Peter Maydell @ 2020-06-19 14:54 UTC (permalink / raw)
To: Alex Bennée
Cc: Paolo Bonzini, Richard Henderson, Pavel Dovgalyuk,
QEMU Developers
On Fri, 19 Jun 2020 at 14:58, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> This attempts to bring together my understanding of the requirements
> for icount behaviour into one reference document for our developer
> notes. It currently make one piece of conjecture which I think is true
> that we don't need gen_io_start/end statements for non-MMIO related
> I/O operations.
> +Other I/O operations
> +--------------------
> +
> +MMIO isn't the only type of operation for which we might need a
> +correct and accurate clock. IO port instructions and accesses to
> +system registers are the common examples here. For the clock to be
> +accurate you end a translation block on these instructions.
> +
> +.. warning:: (CONJECTURE) instructions that won't get trapped in the
> + io_read/writex shouldn't need gen_io_start/end blocks
> + around them.
I think this is backwards -- instructions where icount is handled
by io_readx/io_writex are the ones that don't need to be marked
with gen_io_start. It's the i/o instructions that don't go through
io_readx/io_writex that need gen_io_start.
thanks
-- PMM
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RFC PATCH] docs/devel: add some notes on tcg-icount for developers
2020-06-19 14:54 ` Peter Maydell
@ 2020-06-19 15:44 ` Paolo Bonzini
2020-06-19 15:54 ` Alex Bennée
1 sibling, 0 replies; 7+ messages in thread
From: Paolo Bonzini @ 2020-06-19 15:44 UTC (permalink / raw)
To: Peter Maydell, Alex Bennée
Cc: Richard Henderson, Pavel Dovgalyuk, QEMU Developers
On 19/06/20 16:54, Peter Maydell wrote:
>> +
>> +MMIO isn't the only type of operation for which we might need a
>> +correct and accurate clock. IO port instructions and accesses to
>> +system registers are the common examples here. For the clock to be
>> +accurate you end a translation block on these instructions.
>> +
>> +.. warning:: (CONJECTURE) instructions that won't get trapped in the
>> + io_read/writex shouldn't need gen_io_start/end blocks
>> + around them.
> I think this is backwards -- instructions where icount is handled
> by io_readx/io_writex are the ones that don't need to be marked
> with gen_io_start. It's the i/o instructions that don't go through
> io_readx/io_writex that need gen_io_start.
Yes, and likewise instructions where icount is handled by
io_readx/io_writex need not terminate the TB.
Paolo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RFC PATCH] docs/devel: add some notes on tcg-icount for developers
2020-06-19 14:54 ` Peter Maydell
2020-06-19 15:44 ` Paolo Bonzini
@ 2020-06-19 15:54 ` Alex Bennée
1 sibling, 0 replies; 7+ messages in thread
From: Alex Bennée @ 2020-06-19 15:54 UTC (permalink / raw)
To: Peter Maydell
Cc: Paolo Bonzini, Richard Henderson, Pavel Dovgalyuk,
QEMU Developers
Peter Maydell <peter.maydell@linaro.org> writes:
> On Fri, 19 Jun 2020 at 14:58, Alex Bennée <alex.bennee@linaro.org> wrote:
>>
>> This attempts to bring together my understanding of the requirements
>> for icount behaviour into one reference document for our developer
>> notes. It currently make one piece of conjecture which I think is true
>> that we don't need gen_io_start/end statements for non-MMIO related
>> I/O operations.
>
>> +Other I/O operations
>> +--------------------
>> +
>> +MMIO isn't the only type of operation for which we might need a
>> +correct and accurate clock. IO port instructions and accesses to
>> +system registers are the common examples here. For the clock to be
>> +accurate you end a translation block on these instructions.
>> +
>> +.. warning:: (CONJECTURE) instructions that won't get trapped in the
>> + io_read/writex shouldn't need gen_io_start/end blocks
>> + around them.
>
> I think this is backwards -- instructions where icount is handled
> by io_readx/io_writex are the ones that don't need to be marked
> with gen_io_start. It's the i/o instructions that don't go through
> io_readx/io_writex that need gen_io_start.
There are two types of MMIO accesses we generate:
- normal loads/stores which if they end up accessing I/O ports
eventually trap in io_read/writex where as they haven't been marked
with can_do_io (via gen_io_start()) will trigger a recompile and
exit.
- loads and stores emitted while CF_LAST_IO && icount is in effect
(from the above recompile) where they should be the last instruction
in the block so the icount is correct when the do whatever they do.
What I've missed is the one other place where cpu->can_do_io is checked
which is when we read cpu_get_icount_raw_locked. In this case it is
effectively an assert that we have marked the instruction as potentially
accessing icount - although not that the gen_io_start/end was actually on
the last instruction of the block.
--
Alex Bennée
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RFC PATCH] docs/devel: add some notes on tcg-icount for developers
2020-06-19 13:58 [RFC PATCH] docs/devel: add some notes on tcg-icount for developers Alex Bennée
` (2 preceding siblings ...)
2020-06-19 14:54 ` Peter Maydell
@ 2020-06-19 14:55 ` no-reply
3 siblings, 0 replies; 7+ messages in thread
From: no-reply @ 2020-06-19 14:55 UTC (permalink / raw)
To: alex.bennee
Cc: peter.maydell, richard.henderson, qemu-devel, dovgaluk, pbonzini,
alex.bennee
Patchew URL: https://patchew.org/QEMU/20200619135844.23307-1-alex.bennee@linaro.org/
Hi,
This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
export ARCH=x86_64
make docker-image-fedora V=1 NETWORK=1
time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1
=== TEST SCRIPT END ===
CC ui/trace.o
CC hw/core/trace.o
Warning, treated as error:
/tmp/qemu-test/src/docs/devel/tcg-icount.rst:document isn't included in any toctree
CC hw/display/trace.o
CC qapi/trace.o
---
CC stubs/runstate-check.o
CC stubs/semihost.o
CC stubs/set-fd-handler.o
make: *** [Makefile:1088: docs/devel/index.html] Error 2
make: *** Waiting for unfinished jobs....
Traceback (most recent call last):
File "./tests/docker/docker.py", line 669, in <module>
---
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=4b7116456d8441268d522e8434872604', '-u', '1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=x86_64-softmmu', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-wgrif8gc/src/docker-src.2020-06-19-10.51.34.8511:/var/tmp/qemu:z,ro', 'qemu:fedora', '/var/tmp/qemu/run', 'test-debug']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=4b7116456d8441268d522e8434872604
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-wgrif8gc/src'
make: *** [docker-run-test-debug@fedora] Error 2
real 4m14.587s
user 0m8.118s
The full log is available at
http://patchew.org/logs/20200619135844.23307-1-alex.bennee@linaro.org/testing.asan/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
^ permalink raw reply [flat|nested] 7+ messages in thread