All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Alexei Podtelezhnikov" <apodtele@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [patch] drm/i915: Update Slylake PCI IDs
Date: Wed, 29 Apr 2020 11:52:57 +0300	[thread overview]
Message-ID: <878siead1y.fsf@intel.com> (raw)
In-Reply-To: <20200429063240.GL6112@intel.com>

On Wed, 29 Apr 2020, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Tue, Apr 28, 2020 at 11:27:50PM -0400, Alexei Podtelezhnikov wrote:
>> Add three new devices 0x1513, 0x1515, and 0x1517 also known as 
>
> typo 0x15 vs. 0x19
>
>> iSKLULTGT15, iSKLULXGT15, and iSKLDTGT15. Reclassify 0x1923, 0x1927, 
>> and 0x192A according to specifications.
>
> I'd make this three separate patches, just in case we have to revert
> some of these in the future. Most worried about the 0x192a case since
> the evidence is rather poor.

+1

>
> Otherwise lgtm.
>
>> 
>> Signed-off-by: Alexei Podtelezhnikov <apodtele@gmail.com> 
>> ---
>>  include/drm/i915_pciids.h | 19 +++++++++++--------
>>  1 file changed, 11 insertions(+), 8 deletions(-)
>> 
>> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
>> index 1d2c1221..c12bce9e 100644
>> --- a/include/drm/i915_pciids.h
>> +++ b/include/drm/i915_pciids.h
>> @@ -331,15 +331,18 @@
>>  	INTEL_VGA_DEVICE(0x22b3, info)
>>  
>>  #define INTEL_SKL_ULT_GT1_IDS(info) \
>> -	INTEL_VGA_DEVICE(0x1906, info) /* ULT GT1 */
>> +	INTEL_VGA_DEVICE(0x1906, info), /* ULT GT1 */ \
>> +	INTEL_VGA_DEVICE(0x1913, info) /* ULT GT1.5 */
>>  
>>  #define INTEL_SKL_ULX_GT1_IDS(info) \
>> -	INTEL_VGA_DEVICE(0x190E, info) /* ULX GT1 */
>> +	INTEL_VGA_DEVICE(0x190E, info), /* ULX GT1 */ \
>> +	INTEL_VGA_DEVICE(0x1915, info) /* ULX GT1.5 */
>>  
>>  #define INTEL_SKL_GT1_IDS(info)	\
>>  	INTEL_SKL_ULT_GT1_IDS(info), \
>>  	INTEL_SKL_ULX_GT1_IDS(info), \
>>  	INTEL_VGA_DEVICE(0x1902, info), /* DT  GT1 */ \
>> +	INTEL_VGA_DEVICE(0x1917, info), /* DT  GT1.5 */ \
>>  	INTEL_VGA_DEVICE(0x190B, info), /* Halo GT1 */ \
>>  	INTEL_VGA_DEVICE(0x190A, info) /* SRV GT1 */
>>  
>> @@ -359,21 +362,21 @@
>>  	INTEL_VGA_DEVICE(0x191D, info)  /* WKS GT2 */
>>  
>>  #define INTEL_SKL_ULT_GT3_IDS(info) \
>> -	INTEL_VGA_DEVICE(0x1926, info) /* ULT GT3 */
>> +	INTEL_VGA_DEVICE(0x1923, info), /* ULT GT3 */ \
>> +	INTEL_VGA_DEVICE(0x1927, info), /* ULT GT3 28W */ \
>> +	INTEL_VGA_DEVICE(0x1926, info) /* ULT GT3e */
>>  
>>  #define INTEL_SKL_GT3_IDS(info) \
>>  	INTEL_SKL_ULT_GT3_IDS(info), \
>> -	INTEL_VGA_DEVICE(0x1923, info), /* ULT GT3 */ \
>> -	INTEL_VGA_DEVICE(0x1927, info), /* ULT GT3 */ \
>> +	INTEL_VGA_DEVICE(0x192A, info), /* SRV GT3 */ \
>>  	INTEL_VGA_DEVICE(0x192B, info), /* Halo GT3 */ \
>> -	INTEL_VGA_DEVICE(0x192D, info)  /* SRV GT3 */
>> +	INTEL_VGA_DEVICE(0x192D, info)  /* SRV GT3e */
>>  
>>  #define INTEL_SKL_GT4_IDS(info) \
>>  	INTEL_VGA_DEVICE(0x1932, info), /* DT GT4 */ \
>>  	INTEL_VGA_DEVICE(0x193B, info), /* Halo GT4 */ \
>>  	INTEL_VGA_DEVICE(0x193D, info), /* WKS GT4 */ \
>> -	INTEL_VGA_DEVICE(0x192A, info), /* SRV GT4 */ \
>> -	INTEL_VGA_DEVICE(0x193A, info)  /* SRV GT4e */
>> +	INTEL_VGA_DEVICE(0x193A, info)  /* SRV GT4 */
>>  
>>  #define INTEL_SKL_IDS(info)	 \
>>  	INTEL_SKL_GT1_IDS(info), \
>> --
>> 2.26.2

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2020-04-29  8:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-28  3:47 [Intel-gfx] [patch] drm/i915: Add PCI IDs for Skylake GT1.5 Alexei Podtelezhnikov
2020-04-28  4:24 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-04-28  7:10 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-04-28 13:57 ` [Intel-gfx] [patch] " Ville Syrjälä
2020-04-28 14:33   ` Alexei Podtelezhnikov
2020-04-29  3:27   ` [Intel-gfx] [patch] drm/i915: Update Slylake PCI IDs Alexei Podtelezhnikov
2020-04-29  6:32     ` Ville Syrjälä
2020-04-29  8:52       ` Jani Nikula [this message]
2020-04-29  4:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add PCI IDs for Skylake GT1.5 (rev2) Patchwork
2020-04-29  9:13 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2020-04-29 11:40 [Intel-gfx] [patch] drm/i915: Update Slylake PCI IDs Alexei Podtelezhnikov
2020-04-29 11:54 ` Alexei Podtelezhnikov
2020-04-29 13:00   ` Chris Wilson
2020-04-29 15:29 ` Alexei Podtelezhnikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878siead1y.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=apodtele@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.