Re: [Intel-gfx] [patch] drm/i915: Add PCI IDs for Skylake GT1.5

From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Alexei Podtelezhnikov <apodtele@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [patch] drm/i915: Add PCI IDs for Skylake GT1.5
Date: Tue, 28 Apr 2020 16:57:44 +0300	[thread overview]
Message-ID: <20200428135744.GI6112@intel.com> (raw)
In-Reply-To: <20200428034705.3907-1-apodtele@gmail.com>

On Mon, Apr 27, 2020 at 11:47:05PM -0400, Alexei Podtelezhnikov wrote:
> These devices are also known as iSKLULTGT15 and iSKLDTGT15.
> 
> Signed-off-by: Alexei Podtelezhnikov <apodtele@gmail.com>
> ---
>  include/drm/i915_pciids.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/src/i915_pciids.h b/src/i915_pciids.h
> index 1d2c1221..a9c88eab 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -331,7 +355,8 @@ Add SKL GT1.5
>  	INTEL_VGA_DEVICE(0x22b3, info)
>  
>  #define INTEL_SKL_ULT_GT1_IDS(info) \
> -	INTEL_VGA_DEVICE(0x1906, info) /* ULT GT1 */
> +	INTEL_VGA_DEVICE(0x1906, info), /* ULT GT1 */ \
> +	INTEL_VGA_DEVICE(0x1913, info) /* ULT GT1.5 */
>  
>  #define INTEL_SKL_ULX_GT1_IDS(info) \
>  	INTEL_VGA_DEVICE(0x190E, info) /* ULX GT1 */

We also seem to be missing 0x1915 from the ulx list.

Another odd things I noticed in our SKL PCI ID lists is that
that 0x1923 and 0x1927 are potentially miscategorized. They
are listed as ULT in some parts of the spec whereas we have
them in the non-ULT/ULX list. Also 0x1927 is listed as Iris
graphics 550, and ark.intel.com says that it can be found
in the i5-6267U CPU, which is ULT. The other one is listed
as HD Graphics 535 which does give some ULT google hits based
on the Windows drivers. So looks like we should make these ULT.

The third odd thing is that 0x192a is listed as both GT3 and GT4
in the spec. Not really able to find corroborating evidence one
way or the other unfortunately.

> @@ -340,6 +365,7 @@ Add SKL GT1.5
>  	INTEL_SKL_ULT_GT1_IDS(info), \
>  	INTEL_SKL_ULX_GT1_IDS(info), \
>  	INTEL_VGA_DEVICE(0x1902, info), /* DT  GT1 */ \
> +	INTEL_VGA_DEVICE(0x1917, info), /* DT  GT1.5 */ \
>  	INTEL_VGA_DEVICE(0x190B, info), /* Halo GT1 */ \
>  	INTEL_VGA_DEVICE(0x190A, info) /* SRV GT1 */
>  
> --
> 2.26.2
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx