* [Intel-gfx] [PATCH] drm/i915/display: Remove useless but deadly local
@ 2020-03-26 8:28 Chris Wilson
2020-03-26 8:43 ` Jani Nikula
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Chris Wilson @ 2020-03-26 8:28 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula, Wambui Karuga
Beware dereferencing the NULL pointer prior to checking for its
existence.
Fixes: 419190429cd1 ("drm/i915/hdmi: use struct drm_device based logging")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Wambui Karuga <wambui.karugax@gmail.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_hdmi.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
index 395dc192baa0..0076abc63851 100644
--- a/drivers/gpu/drm/i915/display/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
@@ -691,7 +691,6 @@ void intel_read_infoframe(struct intel_encoder *encoder,
union hdmi_infoframe *frame)
{
struct intel_digital_port *intel_dig_port = enc_to_dig_port(encoder);
- struct drm_i915_private *i915 = to_i915(intel_dig_port->base.base.dev);
u8 buffer[VIDEO_DIP_DATA_SIZE];
int ret;
@@ -708,13 +707,13 @@ void intel_read_infoframe(struct intel_encoder *encoder,
/* see comment above for the reason for this offset */
ret = hdmi_infoframe_unpack(frame, buffer + 1, sizeof(buffer) - 1);
if (ret) {
- drm_dbg_kms(&i915->drm,
+ drm_dbg_kms(encoder->base.dev,
"Failed to unpack infoframe type 0x%02x\n", type);
return;
}
if (frame->any.type != type)
- drm_dbg_kms(&i915->drm,
+ drm_dbg_kms(encoder->base.dev,
"Found the wrong infoframe type 0x%x (expected 0x%02x)\n",
frame->any.type, type);
}
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915/display: Remove useless but deadly local 2020-03-26 8:28 [Intel-gfx] [PATCH] drm/i915/display: Remove useless but deadly local Chris Wilson @ 2020-03-26 8:43 ` Jani Nikula 2020-03-26 9:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork ` (2 subsequent siblings) 3 siblings, 0 replies; 5+ messages in thread From: Jani Nikula @ 2020-03-26 8:43 UTC (permalink / raw) To: Chris Wilson, intel-gfx; +Cc: Wambui Karuga On Thu, 26 Mar 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote: > Beware dereferencing the NULL pointer prior to checking for its > existence. Huh, I don't see the failure mode. Please enlighten me. BR, Jani. > > Fixes: 419190429cd1 ("drm/i915/hdmi: use struct drm_device based logging") > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Wambui Karuga <wambui.karugax@gmail.com> > Cc: Jani Nikula <jani.nikula@intel.com> > Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com> > --- > drivers/gpu/drm/i915/display/intel_hdmi.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c > index 395dc192baa0..0076abc63851 100644 > --- a/drivers/gpu/drm/i915/display/intel_hdmi.c > +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c > @@ -691,7 +691,6 @@ void intel_read_infoframe(struct intel_encoder *encoder, > union hdmi_infoframe *frame) > { > struct intel_digital_port *intel_dig_port = enc_to_dig_port(encoder); > - struct drm_i915_private *i915 = to_i915(intel_dig_port->base.base.dev); > u8 buffer[VIDEO_DIP_DATA_SIZE]; > int ret; > > @@ -708,13 +707,13 @@ void intel_read_infoframe(struct intel_encoder *encoder, > /* see comment above for the reason for this offset */ > ret = hdmi_infoframe_unpack(frame, buffer + 1, sizeof(buffer) - 1); > if (ret) { > - drm_dbg_kms(&i915->drm, > + drm_dbg_kms(encoder->base.dev, > "Failed to unpack infoframe type 0x%02x\n", type); > return; > } > > if (frame->any.type != type) > - drm_dbg_kms(&i915->drm, > + drm_dbg_kms(encoder->base.dev, > "Found the wrong infoframe type 0x%x (expected 0x%02x)\n", > frame->any.type, type); > } -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Remove useless but deadly local 2020-03-26 8:28 [Intel-gfx] [PATCH] drm/i915/display: Remove useless but deadly local Chris Wilson 2020-03-26 8:43 ` Jani Nikula @ 2020-03-26 9:12 ` Patchwork 2020-03-26 10:03 ` [Intel-gfx] [PATCH] " Jani Nikula 2020-03-26 10:39 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork 3 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2020-03-26 9:12 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915/display: Remove useless but deadly local URL : https://patchwork.freedesktop.org/series/75109/ State : success == Summary == CI Bug Log - changes from CI_DRM_8190 -> Patchwork_17094 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/index.html Known issues ------------ Here are the changes found in Patchwork_17094 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_selftest@live@hangcheck: - fi-icl-guc: [PASS][1] -> [INCOMPLETE][2] ([fdo#108569]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/fi-icl-guc/igt@i915_selftest@live@hangcheck.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/fi-icl-guc/igt@i915_selftest@live@hangcheck.html * igt@kms_chamelium@common-hpd-after-suspend: - fi-cml-u2: [PASS][3] -> [DMESG-WARN][4] ([IGT#4]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/fi-cml-u2/igt@kms_chamelium@common-hpd-after-suspend.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/fi-cml-u2/igt@kms_chamelium@common-hpd-after-suspend.html #### Possible fixes #### * igt@i915_selftest@live@execlists: - {fi-tgl-u}: [DMESG-FAIL][5] ([i915#656]) -> [PASS][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/fi-tgl-u/igt@i915_selftest@live@execlists.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/fi-tgl-u/igt@i915_selftest@live@execlists.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [IGT#4]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/4 [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569 [i915#656]: https://gitlab.freedesktop.org/drm/intel/issues/656 Participating hosts (40 -> 41) ------------------------------ Additional (9): fi-glk-dsi fi-ilk-650 fi-gdg-551 fi-ivb-3770 fi-elk-e7500 fi-bsw-kefka fi-blb-e6850 fi-bsw-nick fi-snb-2600 Missing (8): fi-hsw-4200u fi-bsw-n3050 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-cfl-8109u fi-byt-clapper fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_8190 -> Patchwork_17094 CI-20190529: 20190529 CI_DRM_8190: 73f711b364bc85c8a7189487c09431eb1f515ed0 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5538: 47becbc9cd1fc7b1b78692f90fd3dcd5a9066965 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_17094: 007816da9e131891dace85d46c9bcc3c2ce4deac @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 007816da9e13 drm/i915/display: Remove useless but deadly local == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Remove useless but deadly local 2020-03-26 8:28 [Intel-gfx] [PATCH] drm/i915/display: Remove useless but deadly local Chris Wilson 2020-03-26 8:43 ` Jani Nikula 2020-03-26 9:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork @ 2020-03-26 10:03 ` Jani Nikula 2020-03-26 10:39 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork 3 siblings, 0 replies; 5+ messages in thread From: Jani Nikula @ 2020-03-26 10:03 UTC (permalink / raw) To: Chris Wilson, intel-gfx; +Cc: Wambui Karuga On Thu, 26 Mar 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote: > Beware dereferencing the NULL pointer prior to checking for its > existence. Okay, so the crt code calls ddi functions, and enc_to_dig_port() will return NULL. Backtrace for posterity below, copy-pasted from logs Chris pointed me at. I think alternatively we could just use to_i915(encoder->base.dev) here instead of accessing intel_dig_port, but the patch at hand fixes stuff, Reviewed-by: Jani Nikula <jani.nikula@intel.com> Some other observations: As we're moving further and further away from crt, I don't think people expect the intel_ddi_* functions to be called directly from crt code, or any code where the encoder is *not* a digital port. And that brings us to another case where enc_to_dig_port() will return NULL: INTEL_OUTPUT_DP_MST. We rarely check for enc_to_dig_port() being NULL anywhere. There's probably more subtle bugs waiting to happen here and there. BR, Jani. <1>[ 3.324694] BUG: kernel NULL pointer dereference, address: 0000000000000000 <1>[ 3.324696] #PF: supervisor read access in kernel mode <4>[ 3.324704] hardirqs last enabled at (751): [<ffffffff812a4f77>] d_lookup+0x57/0xa0 <1>[ 3.324709] #PF: error_code(0x0000) - not-present page <4>[ 3.324716] hardirqs last disabled at (752): [<ffffffff8125a1b9>] __slab_alloc.isra.89.constprop.94+0x19/0x70 <4>[ 3.324720] softirqs last enabled at (402): [<ffffffff81e00385>] __do_softirq+0x385/0x47f <6>[ 3.324725] PGD 0 P4D 0 <4>[ 3.324733] softirqs last disabled at (395): [<ffffffff810bab6a>] irq_exit+0xba/0xc0 <4>[ 3.324762] Oops: 0000 [#1] PREEMPT SMP PTI <4>[ 3.324768] CPU: 0 PID: 380 Comm: systemd-udevd Not tainted 5.6.0-rc7-CI-CI_DRM_8189+ #1 <4>[ 3.324776] Hardware name: MSI MS-7924/Z97M-G43(MS-7924), BIOS V1.12 02/15/2016 <4>[ 3.324840] RIP: 0010:intel_read_infoframe+0x3a/0x170 [i915] <4>[ 3.324848] Code: 65 48 8b 04 25 28 00 00 00 48 89 44 24 20 31 c0 83 f9 0a 77 12 ba 01 00 00 00 48 d3 e2 f7 c2 c0 05 00 00 48 0f 45 c7 83 fb 03 <4c> 8b 20 0f 84 f2 00 00 00 83 fb 0a 0f 84 f3 00 00 00 83 fb 07 0f <4>[ 3.324865] RSP: 0018:ffffc900005438b0 EFLAGS: 00010212 <4>[ 3.324871] RAX: 0000000000000000 RBX: 0000000000000082 RCX: 0000000000000001 <4>[ 3.324879] RDX: 0000000000000002 RSI: ffff8883f8309000 RDI: ffff8883f80cbe00 <4>[ 3.324887] RBP: ffff8883f8309b34 R08: 000000000000000e R09: 0000000000000001 <4>[ 3.324894] R10: 0000000000000000 R11: 0000000000000000 R12: ffff8883f7ac0000 <4>[ 3.324901] R13: ffff8883f7ac0000 R14: ffff8883f7ac0d90 R15: ffff8883f844d000 <4>[ 3.324908] FS: 00007ffa4a839680(0000) GS:ffff888410000000(0000) knlGS:0000000000000000 <4>[ 3.324917] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 <4>[ 3.324923] CR2: 0000000000000000 CR3: 0000000401aa4002 CR4: 00000000001606f0 <4>[ 3.324930] Call Trace: <4>[ 3.324980] ? gen6_read32+0x272/0x300 [i915] <4>[ 3.325044] intel_ddi_get_config+0x238/0x610 [i915] <4>[ 3.325108] hsw_crt_get_config+0x12/0x40 [i915] <4>[ 3.325173] intel_modeset_setup_hw_state+0x3b3/0x1660 [i915] <4>[ 3.325182] ? ww_mutex_lock+0x39/0x70 <4>[ 3.325190] ? drm_modeset_lock+0xad/0x120 <4>[ 3.325254] intel_modeset_init+0x582/0x1c50 [i915] <4>[ 3.325263] ? _raw_spin_unlock_irqrestore+0x34/0x60 <4>[ 3.325314] ? intel_irq_postinstall+0xb3/0x610 [i915] <4>[ 3.325366] i915_driver_probe+0xa7e/0xed0 [i915] <4>[ 3.325375] ? __pm_runtime_resume+0x4f/0x80 <4>[ 3.325426] i915_pci_probe+0x43/0x1b0 [i915] <4>[ 3.325434] ? _raw_spin_unlock_irqrestore+0x34/0x60 <4>[ 3.325442] pci_device_probe+0x9e/0x120 <4>[ 3.325450] really_probe+0xea/0x430 <4>[ 3.325456] driver_probe_device+0x10b/0x120 <4>[ 3.325463] device_driver_attach+0x4a/0x50 <4>[ 3.325469] __driver_attach+0x97/0x130 <4>[ 3.325476] ? device_driver_attach+0x50/0x50 <4>[ 3.325482] bus_for_each_dev+0x74/0xc0 <4>[ 3.325489] bus_add_driver+0x142/0x220 <4>[ 3.325495] driver_register+0x56/0xf0 <4>[ 3.325543] i915_init+0x6c/0x7c [i915] <4>[ 3.325549] ? 0xffffffffa087f000 <4>[ 3.325555] do_one_initcall+0x58/0x300 <4>[ 3.325562] ? rcu_read_lock_sched_held+0x4d/0x80 <4>[ 3.325570] ? kmem_cache_alloc_trace+0x2a6/0x2d0 <4>[ 3.325578] do_init_module+0x56/0x1f2 <4>[ 3.325584] load_module+0x233d/0x2a30 <4>[ 3.325596] ? __do_sys_finit_module+0xe9/0x110 <4>[ 3.325602] __do_sys_finit_module+0xe9/0x110 <4>[ 3.325612] do_syscall_64+0x4f/0x220 <4>[ 3.325618] entry_SYSCALL_64_after_hwframe+0x49/0xbe <4>[ 3.325624] RIP: 0033:0x7ffa4a35a839 <4>[ 3.325630] Code: 00 f3 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 1f f6 2c 00 f7 d8 64 89 01 48 <4>[ 3.325647] RSP: 002b:00007ffdbdf7b848 EFLAGS: 00000246 ORIG_RAX: 0000000000000139 <4>[ 3.325656] RAX: ffffffffffffffda RBX: 000055bc2aa95fc0 RCX: 00007ffa4a35a839 <4>[ 3.325663] RDX: 0000000000000000 RSI: 00007ffa4a039145 RDI: 000000000000000f <4>[ 3.325671] RBP: 00007ffa4a039145 R08: 0000000000000000 R09: 00007ffdbdf7b960 <4>[ 3.325678] R10: 000000000000000f R11: 0000000000000246 R12: 0000000000000000 <4>[ 3.325686] R13: 000055bc2aaa3200 R14: 0000000000020000 R15: 000055bc2aa95fc0 <4>[ 3.325696] Modules linked in: i915(+) mei_hdcp x86_pkg_temp_thermal coretemp snd_hda_codec_realtek snd_hda_codec_generic crct10dif_pclmul crc32_pclmul snd_hda_intel snd_intel_dspcfg snd_hda_codec ghash_clmulni_intel snd_hwdep r8169 snd_hda_core realtek snd_pcm mei_me mei prime_numbers lpc_ich <4>[ 3.325729] CR2: 0000000000000000 <4>[ 3.325740] ---[ end trace 22628c46d7d6a985 ]--- > > Fixes: 419190429cd1 ("drm/i915/hdmi: use struct drm_device based logging") > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Wambui Karuga <wambui.karugax@gmail.com> > Cc: Jani Nikula <jani.nikula@intel.com> > Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com> > --- > drivers/gpu/drm/i915/display/intel_hdmi.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c > index 395dc192baa0..0076abc63851 100644 > --- a/drivers/gpu/drm/i915/display/intel_hdmi.c > +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c > @@ -691,7 +691,6 @@ void intel_read_infoframe(struct intel_encoder *encoder, > union hdmi_infoframe *frame) > { > struct intel_digital_port *intel_dig_port = enc_to_dig_port(encoder); > - struct drm_i915_private *i915 = to_i915(intel_dig_port->base.base.dev); > u8 buffer[VIDEO_DIP_DATA_SIZE]; > int ret; > > @@ -708,13 +707,13 @@ void intel_read_infoframe(struct intel_encoder *encoder, > /* see comment above for the reason for this offset */ > ret = hdmi_infoframe_unpack(frame, buffer + 1, sizeof(buffer) - 1); > if (ret) { > - drm_dbg_kms(&i915->drm, > + drm_dbg_kms(encoder->base.dev, > "Failed to unpack infoframe type 0x%02x\n", type); > return; > } > > if (frame->any.type != type) > - drm_dbg_kms(&i915->drm, > + drm_dbg_kms(encoder->base.dev, > "Found the wrong infoframe type 0x%x (expected 0x%02x)\n", > frame->any.type, type); > } -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Remove useless but deadly local 2020-03-26 8:28 [Intel-gfx] [PATCH] drm/i915/display: Remove useless but deadly local Chris Wilson ` (2 preceding siblings ...) 2020-03-26 10:03 ` [Intel-gfx] [PATCH] " Jani Nikula @ 2020-03-26 10:39 ` Patchwork 3 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2020-03-26 10:39 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915/display: Remove useless but deadly local URL : https://patchwork.freedesktop.org/series/75109/ State : success == Summary == CI Bug Log - changes from CI_DRM_8190_full -> Patchwork_17094_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_17094_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_balancer@smoke: - shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#110854]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb1/igt@gem_exec_balancer@smoke.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/shard-iclb5/igt@gem_exec_balancer@smoke.html * igt@gem_exec_schedule@implicit-read-write-bsd1: - shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276] / [i915#677]) +4 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb4/igt@gem_exec_schedule@implicit-read-write-bsd1.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/shard-iclb7/igt@gem_exec_schedule@implicit-read-write-bsd1.html * igt@gem_exec_schedule@in-order-bsd: - shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#112146]) +7 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb3/igt@gem_exec_schedule@in-order-bsd.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/shard-iclb4/igt@gem_exec_schedule@in-order-bsd.html * igt@gem_exec_schedule@pi-shared-iova-bsd: - shard-iclb: [PASS][7] -> [SKIP][8] ([i915#677]) +1 similar issue [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb3/igt@gem_exec_schedule@pi-shared-iova-bsd.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/shard-iclb2/igt@gem_exec_schedule@pi-shared-iova-bsd.html * igt@i915_suspend@forcewake: - shard-skl: [PASS][9] -> [INCOMPLETE][10] ([i915#69]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-skl9/igt@i915_suspend@forcewake.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/shard-skl2/igt@i915_suspend@forcewake.html * igt@kms_flip@flip-vs-expired-vblank: - shard-skl: [PASS][11] -> [FAIL][12] ([i915#79]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-skl6/igt@kms_flip@flip-vs-expired-vblank.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/shard-skl3/igt@kms_flip@flip-vs-expired-vblank.html * igt@kms_flip@flip-vs-suspend-interruptible: - shard-apl: [PASS][13] -> [DMESG-WARN][14] ([i915#180]) +1 similar issue [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-apl3/igt@kms_flip@flip-vs-suspend-interruptible.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/shard-apl6/igt@kms_flip@flip-vs-suspend-interruptible.html * igt@kms_hdr@bpc-switch: - shard-skl: [PASS][15] -> [FAIL][16] ([i915#1188]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-skl4/igt@kms_hdr@bpc-switch.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/shard-skl6/igt@kms_hdr@bpc-switch.html * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min: - shard-skl: [PASS][17] -> [FAIL][18] ([fdo#108145]) +1 similar issue [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-skl7/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/shard-skl8/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html * igt@kms_plane_lowres@pipe-a-tiling-x: - shard-glk: [PASS][19] -> [FAIL][20] ([i915#899]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-glk7/igt@kms_plane_lowres@pipe-a-tiling-x.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/shard-glk6/igt@kms_plane_lowres@pipe-a-tiling-x.html * igt@kms_prime@basic-crc: - shard-apl: [PASS][21] -> [FAIL][22] ([i915#1031] / [i915#95]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-apl4/igt@kms_prime@basic-crc.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/shard-apl8/igt@kms_prime@basic-crc.html - shard-kbl: [PASS][23] -> [FAIL][24] ([i915#1031] / [i915#93] / [i915#95]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-kbl7/igt@kms_prime@basic-crc.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/shard-kbl1/igt@kms_prime@basic-crc.html * igt@kms_psr@psr2_cursor_blt: - shard-iclb: [PASS][25] -> [SKIP][26] ([fdo#109441]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/shard-iclb1/igt@kms_psr@psr2_cursor_blt.html * igt@kms_vblank@pipe-a-ts-continuation-suspend: - shard-kbl: [PASS][27] -> [DMESG-WARN][28] ([i915#180]) +2 similar issues [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-kbl3/igt@kms_vblank@pipe-a-ts-continuation-suspend.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/shard-kbl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html * igt@perf_pmu@init-busy-vcs1: - shard-iclb: [PASS][29] -> [SKIP][30] ([fdo#112080]) +13 similar issues [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb4/igt@perf_pmu@init-busy-vcs1.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/shard-iclb7/igt@perf_pmu@init-busy-vcs1.html * igt@prime_busy@hang-bsd2: - shard-iclb: [PASS][31] -> [SKIP][32] ([fdo#109276]) +28 similar issues [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb1/igt@prime_busy@hang-bsd2.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/shard-iclb3/igt@prime_busy@hang-bsd2.html #### Possible fixes #### * igt@gem_busy@busy-vcs1: - shard-iclb: [SKIP][33] ([fdo#112080]) -> [PASS][34] +16 similar issues [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb7/igt@gem_busy@busy-vcs1.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/shard-iclb2/igt@gem_busy@busy-vcs1.html * igt@gem_ctx_shared@exec-single-timeline-bsd: - shard-iclb: [SKIP][35] ([fdo#110841]) -> [PASS][36] [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb1/igt@gem_ctx_shared@exec-single-timeline-bsd.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/shard-iclb5/igt@gem_ctx_shared@exec-single-timeline-bsd.html * igt@gem_exec_schedule@implicit-both-bsd2: - shard-iclb: [SKIP][37] ([fdo#109276] / [i915#677]) -> [PASS][38] [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb3/igt@gem_exec_schedule@implicit-both-bsd2.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/shard-iclb4/igt@gem_exec_schedule@implicit-both-bsd2.html * igt@gem_exec_schedule@pi-common-bsd: - shard-iclb: [SKIP][39] ([i915#677]) -> [PASS][40] +2 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb1/igt@gem_exec_schedule@pi-common-bsd.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/shard-iclb5/igt@gem_exec_schedule@pi-common-bsd.html * igt@gem_exec_schedule@pi-common-bsd1: - shard-iclb: [SKIP][41] ([fdo#109276]) -> [PASS][42] +12 similar issues [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb5/igt@gem_exec_schedule@pi-common-bsd1.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/shard-iclb1/igt@gem_exec_schedule@pi-common-bsd1.html * igt@gem_exec_schedule@preempt-other-chain-bsd: - shard-iclb: [SKIP][43] ([fdo#112146]) -> [PASS][44] +3 similar issues [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb4/igt@gem_exec_schedule@preempt-other-chain-bsd.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/shard-iclb5/igt@gem_exec_schedule@preempt-other-chain-bsd.html * igt@gem_softpin@noreloc-s3: - shard-apl: [DMESG-WARN][45] ([i915#180]) -> [PASS][46] +2 similar issues [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-apl7/igt@gem_softpin@noreloc-s3.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/shard-apl7/igt@gem_softpin@noreloc-s3.html * igt@gen9_exec_parse@allowed-all: - shard-skl: [DMESG-WARN][47] ([i915#716]) -> [PASS][48] [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-skl1/igt@gen9_exec_parse@allowed-all.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/shard-skl5/igt@gen9_exec_parse@allowed-all.html - shard-apl: [DMESG-WARN][49] ([i915#716]) -> [PASS][50] [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-apl7/igt@gen9_exec_parse@allowed-all.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/shard-apl6/igt@gen9_exec_parse@allowed-all.html * igt@kms_flip@plain-flip-fb-recreate: - shard-skl: [FAIL][51] ([i915#34]) -> [PASS][52] [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-skl10/igt@kms_flip@plain-flip-fb-recreate.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/shard-skl7/igt@kms_flip@plain-flip-fb-recreate.html * igt@kms_hdr@bpc-switch-dpms: - shard-skl: [FAIL][53] ([i915#1188]) -> [PASS][54] [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-skl6/igt@kms_hdr@bpc-switch-dpms.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/shard-skl4/igt@kms_hdr@bpc-switch-dpms.html * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes: - shard-kbl: [DMESG-WARN][55] ([i915#180]) -> [PASS][56] +2 similar issues [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-kbl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/shard-kbl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html * igt@kms_plane_lowres@pipe-a-tiling-y: - shard-glk: [FAIL][57] ([i915#899]) -> [PASS][58] [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-glk8/igt@kms_plane_lowres@pipe-a-tiling-y.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/shard-glk2/igt@kms_plane_lowres@pipe-a-tiling-y.html * igt@kms_psr@no_drrs: - shard-iclb: [FAIL][59] ([i915#173]) -> [PASS][60] [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb1/igt@kms_psr@no_drrs.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/shard-iclb5/igt@kms_psr@no_drrs.html * igt@kms_psr@psr2_no_drrs: - shard-iclb: [SKIP][61] ([fdo#109441]) -> [PASS][62] +1 similar issue [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb3/igt@kms_psr@psr2_no_drrs.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/shard-iclb2/igt@kms_psr@psr2_no_drrs.html #### Warnings #### * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max: - shard-apl: [FAIL][63] ([fdo#108145]) -> [FAIL][64] ([fdo#108145] / [i915#95]) [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-apl6/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/shard-apl8/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max.html * igt@kms_psr2_su@page_flip: - shard-iclb: [FAIL][65] ([i915#608]) -> [SKIP][66] ([fdo#109642] / [fdo#111068]) [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-iclb2/igt@kms_psr2_su@page_flip.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/shard-iclb5/igt@kms_psr2_su@page_flip.html * igt@runner@aborted: - shard-apl: ([FAIL][67], [FAIL][68]) ([fdo#103927] / [i915#716]) -> [FAIL][69] ([fdo#103927]) [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-apl7/igt@runner@aborted.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8190/shard-apl8/igt@runner@aborted.html [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/shard-apl3/igt@runner@aborted.html [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841 [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080 [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146 [i915#1031]: https://gitlab.freedesktop.org/drm/intel/issues/1031 [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188 [i915#173]: https://gitlab.freedesktop.org/drm/intel/issues/173 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34 [i915#608]: https://gitlab.freedesktop.org/drm/intel/issues/608 [i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677 [i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69 [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#899]: https://gitlab.freedesktop.org/drm/intel/issues/899 [i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_8190 -> Patchwork_17094 CI-20190529: 20190529 CI_DRM_8190: 73f711b364bc85c8a7189487c09431eb1f515ed0 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5538: 47becbc9cd1fc7b1b78692f90fd3dcd5a9066965 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_17094: 007816da9e131891dace85d46c9bcc3c2ce4deac @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17094/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-03-26 10:39 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-03-26 8:28 [Intel-gfx] [PATCH] drm/i915/display: Remove useless but deadly local Chris Wilson 2020-03-26 8:43 ` Jani Nikula 2020-03-26 9:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2020-03-26 10:03 ` [Intel-gfx] [PATCH] " Jani Nikula 2020-03-26 10:39 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.