From: Yoshinori Sato <ysato@users.sourceforge.jp>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Rich Felker <dalias@libc.org>,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH] sh: kernel: hw_breakpoint: Fix missing break in switch statement
Date: Tue, 13 Aug 2019 08:50:08 +0000 [thread overview]
Message-ID: <878srxphz3.wl-ysato@users.sourceforge.jp> (raw)
In-Reply-To: <20190810045944.GA13815@embeddedor>
On Sat, 10 Aug 2019 13:59:44 +0900,
Gustavo A. R. Silva wrote:
>
> Add missing break statement in order to prevent the code from
> erroneously falling through to case SH_BREAKPOINT_WRITE.
>
> Fixes: 09a072947791 ("sh: hw-breakpoints: Add preliminary support for SH-4A UBC.")
> Cc: stable@vger.kernel.org
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
>
> If no one cares, I'll apply this to my tree and queue it up for 5.3-rc4.
>
> arch/sh/kernel/hw_breakpoint.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/sh/kernel/hw_breakpoint.c b/arch/sh/kernel/hw_breakpoint.c
> index 3bd010b4c55f..f10d64311127 100644
> --- a/arch/sh/kernel/hw_breakpoint.c
> +++ b/arch/sh/kernel/hw_breakpoint.c
> @@ -157,6 +157,7 @@ int arch_bp_generic_fields(int sh_len, int sh_type,
> switch (sh_type) {
> case SH_BREAKPOINT_READ:
> *gen_type = HW_BREAKPOINT_R;
> + break;
> case SH_BREAKPOINT_WRITE:
> *gen_type = HW_BREAKPOINT_W;
> break;
> --
> 2.22.0
>
Applied sh-next.
Thanks.
--
Yosinori Sato
WARNING: multiple messages have this Message-ID (diff)
From: Yoshinori Sato <ysato@users.sourceforge.jp>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Rich Felker <dalias@libc.org>,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH] sh: kernel: hw_breakpoint: Fix missing break in switch statement
Date: Tue, 13 Aug 2019 17:50:08 +0900 [thread overview]
Message-ID: <878srxphz3.wl-ysato@users.sourceforge.jp> (raw)
In-Reply-To: <20190810045944.GA13815@embeddedor>
On Sat, 10 Aug 2019 13:59:44 +0900,
Gustavo A. R. Silva wrote:
>
> Add missing break statement in order to prevent the code from
> erroneously falling through to case SH_BREAKPOINT_WRITE.
>
> Fixes: 09a072947791 ("sh: hw-breakpoints: Add preliminary support for SH-4A UBC.")
> Cc: stable@vger.kernel.org
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
>
> If no one cares, I'll apply this to my tree and queue it up for 5.3-rc4.
>
> arch/sh/kernel/hw_breakpoint.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/sh/kernel/hw_breakpoint.c b/arch/sh/kernel/hw_breakpoint.c
> index 3bd010b4c55f..f10d64311127 100644
> --- a/arch/sh/kernel/hw_breakpoint.c
> +++ b/arch/sh/kernel/hw_breakpoint.c
> @@ -157,6 +157,7 @@ int arch_bp_generic_fields(int sh_len, int sh_type,
> switch (sh_type) {
> case SH_BREAKPOINT_READ:
> *gen_type = HW_BREAKPOINT_R;
> + break;
> case SH_BREAKPOINT_WRITE:
> *gen_type = HW_BREAKPOINT_W;
> break;
> --
> 2.22.0
>
Applied sh-next.
Thanks.
--
Yosinori Sato
next prev parent reply other threads:[~2019-08-13 8:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-10 4:59 [PATCH] sh: kernel: hw_breakpoint: Fix missing break in switch statement Gustavo A. R. Silva
2019-08-10 4:59 ` Gustavo A. R. Silva
2019-08-10 6:53 ` Geert Uytterhoeven
2019-08-10 6:53 ` Geert Uytterhoeven
2019-08-10 12:53 ` Guenter Roeck
2019-08-10 12:53 ` Guenter Roeck
2019-08-13 8:50 ` Yoshinori Sato [this message]
2019-08-13 8:50 ` Yoshinori Sato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878srxphz3.wl-ysato@users.sourceforge.jp \
--to=ysato@users.sourceforge.jp \
--cc=dalias@libc.org \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.