From: "Alex Bennée" <alex.bennee@linaro.org>
To: "LI\, BO XUAN" <liboxuan@connect.hku.hk>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
"Eric Blake" <eblake@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Yuval Shaia" <yuval.shaia@oracle.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-trivial] [PATCH v4] hw/virtio/virtio-mmio: Convert DPRINTF to trace and log
Date: Fri, 03 May 2019 18:00:25 +0100 [thread overview]
Message-ID: <878svn4gnq.fsf@zen.linaroharston> (raw)
In-Reply-To: <CALM0=-=b+z2aW-cuM=hmk3_oKG7w3ianMo_ZA7gj8zMgCOfC3g@mail.gmail.com>
LI, BO XUAN <liboxuan@connect.hku.hk> writes:
> Hi Alex,
>
> Sorry about that, I am still trying to get familiar with the patch
> submission process. Since my patch has been changed from your last review,
> I thought it would be safe to not include the r-b tag from last time. Will
> take care next time!
That's ok. As a general rule as long as you haven't substantially
changed a patch it's safe to keep previous r-b tags. You can always
mention it in your cover letter if you are unsure.
--
Alex Bennée
WARNING: multiple messages have this Message-ID (diff)
From: "Alex Bennée" <alex.bennee@linaro.org>
To: "LI, BO XUAN" <liboxuan@connect.hku.hk>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
"Eric Blake" <eblake@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Yuval Shaia" <yuval.shaia@oracle.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4] hw/virtio/virtio-mmio: Convert DPRINTF to trace and log
Date: Fri, 03 May 2019 18:00:25 +0100 [thread overview]
Message-ID: <878svn4gnq.fsf@zen.linaroharston> (raw)
In-Reply-To: <CALM0=-=b+z2aW-cuM=hmk3_oKG7w3ianMo_ZA7gj8zMgCOfC3g@mail.gmail.com>
LI, BO XUAN <liboxuan@connect.hku.hk> writes:
> Hi Alex,
>
> Sorry about that, I am still trying to get familiar with the patch
> submission process. Since my patch has been changed from your last review,
> I thought it would be safe to not include the r-b tag from last time. Will
> take care next time!
That's ok. As a general rule as long as you haven't substantially
changed a patch it's safe to keep previous r-b tags. You can always
mention it in your cover letter if you are unsure.
--
Alex Bennée
WARNING: multiple messages have this Message-ID (diff)
From: "Alex Bennée" <alex.bennee@linaro.org>
To: "LI\, BO XUAN" <liboxuan@connect.hku.hk>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
"Yuval Shaia" <yuval.shaia@oracle.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4] hw/virtio/virtio-mmio: Convert DPRINTF to trace and log
Date: Fri, 03 May 2019 18:00:25 +0100 [thread overview]
Message-ID: <878svn4gnq.fsf@zen.linaroharston> (raw)
Message-ID: <20190503170025.nviJ1pl7_Ga4Q38ZSwgqpNBzc3lRz8DZ3gIQOgoEDIA@z> (raw)
In-Reply-To: <CALM0=-=b+z2aW-cuM=hmk3_oKG7w3ianMo_ZA7gj8zMgCOfC3g@mail.gmail.com>
LI, BO XUAN <liboxuan@connect.hku.hk> writes:
> Hi Alex,
>
> Sorry about that, I am still trying to get familiar with the patch
> submission process. Since my patch has been changed from your last review,
> I thought it would be safe to not include the r-b tag from last time. Will
> take care next time!
That's ok. As a general rule as long as you haven't substantially
changed a patch it's safe to keep previous r-b tags. You can always
mention it in your cover letter if you are unsure.
--
Alex Bennée
next prev parent reply other threads:[~2019-05-03 17:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-03 15:44 [Qemu-trivial] [PATCH v4] hw/virtio/virtio-mmio: Convert DPRINTF to trace and log Boxuan Li
2019-05-03 15:44 ` [Qemu-devel] " Boxuan Li
2019-05-03 15:44 ` Boxuan Li
2019-05-03 15:58 ` [Qemu-trivial] " Philippe Mathieu-Daudé
2019-05-03 15:58 ` [Qemu-devel] " Philippe Mathieu-Daudé
2019-05-03 15:58 ` Philippe Mathieu-Daudé
2019-05-03 16:18 ` [Qemu-trivial] " Alex Bennée
2019-05-03 16:18 ` [Qemu-devel] " Alex Bennée
2019-05-03 16:18 ` Alex Bennée
2019-05-03 16:23 ` [Qemu-trivial] " LI, BO XUAN
2019-05-03 16:23 ` [Qemu-devel] " LI, BO XUAN
2019-05-03 16:23 ` LI, BO XUAN
2019-05-03 17:00 ` Alex Bennée [this message]
2019-05-03 17:00 ` Alex Bennée
2019-05-03 17:00 ` Alex Bennée
2019-05-03 17:13 ` [Qemu-trivial] " LI, BO XUAN
2019-05-03 17:13 ` [Qemu-devel] " LI, BO XUAN
2019-05-03 17:13 ` LI, BO XUAN
2019-05-05 10:57 ` [Qemu-trivial] " Yuval Shaia
2019-05-05 10:57 ` [Qemu-devel] " Yuval Shaia
2019-05-05 10:57 ` Yuval Shaia
2019-05-22 13:33 ` [Qemu-trivial] " Laurent Vivier
2019-05-22 13:33 ` [Qemu-devel] " Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878svn4gnq.fsf@zen.linaroharston \
--to=alex.bennee@linaro.org \
--cc=eblake@redhat.com \
--cc=liboxuan@connect.hku.hk \
--cc=mst@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=yuval.shaia@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.