All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Emilio G. Cota" <cota@braap.org>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [Qemu-devel] [PATCH 13/16] translate-all: protect TB jumps with a per-destination-TB lock
Date: Wed, 28 Mar 2018 16:57:58 +0100	[thread overview]
Message-ID: <878tac8a61.fsf@linaro.org> (raw)
In-Reply-To: <1519709965-29833-14-git-send-email-cota@braap.org>


Emilio G. Cota <cota@braap.org> writes:

> This applies to both user-mode and !user-mode emulation.
>
<snip>
> @@ -2124,7 +2148,7 @@ void cpu_io_recompile(CPUState *cpu, uintptr_t retaddr)
>      /* Adjust the execution state of the next TB.  */
>      cpu->cflags_next_tb = curr_cflags() | CF_LAST_IO | n;
>
> -    if (tb->cflags & CF_NOCACHE) {
> +    if (tb_cflags(tb) & CF_NOCACHE) {
>          if (tb->orig_tb) {
>              /* Invalidate original TB if this TB was generated in
>               * cpu_exec_nocache() */

Heads up, this fails to apply on master, most likely due to
87f963be66a32453e001d1052b000f1653605caa

--
Alex Bennée

  parent reply	other threads:[~2018-03-28 15:58 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-27  5:39 [Qemu-devel] [PATCH 00/16] tcg: tb_lock removal redux v1 Emilio G. Cota
2018-02-27  5:39 ` [Qemu-devel] [PATCH 01/16] qht: require a default comparison function Emilio G. Cota
2018-02-28 19:02   ` Richard Henderson
2018-03-28 16:21   ` Alex Bennée
2018-02-27  5:39 ` [Qemu-devel] [PATCH 02/16] qht: return existing entry when qht_insert fails Emilio G. Cota
2018-02-28 19:10   ` Richard Henderson
2018-03-28 16:33   ` Alex Bennée
2018-04-05 17:10     ` Emilio G. Cota
2018-02-27  5:39 ` [Qemu-devel] [PATCH 03/16] tcg: track TBs with per-region BST's Emilio G. Cota
2018-02-28 20:53   ` Richard Henderson
2018-03-29  9:54   ` Alex Bennée
2018-02-27  5:39 ` [Qemu-devel] [PATCH 04/16] tcg: move tb_ctx.tb_phys_invalidate_count to tcg_ctx Emilio G. Cota
2018-02-28 20:55   ` Richard Henderson
2018-03-29 10:06   ` Alex Bennée
2018-04-05 17:18     ` Emilio G. Cota
2018-02-27  5:39 ` [Qemu-devel] [PATCH 05/16] translate-all: iterate over TBs in a page with PAGE_FOR_EACH_TB Emilio G. Cota
2018-02-28 21:40   ` Richard Henderson
2018-02-28 22:50     ` Emilio G. Cota
2018-02-28 22:53       ` Richard Henderson
2018-02-27  5:39 ` [Qemu-devel] [PATCH 06/16] translate-all: make l1_map lockless Emilio G. Cota
2018-02-28 22:15   ` Richard Henderson
2018-03-29 10:16   ` Alex Bennée
2018-02-27  5:39 ` [Qemu-devel] [PATCH 07/16] translate-all: remove hole in PageDesc Emilio G. Cota
2018-02-28 22:17   ` Richard Henderson
2018-03-29 10:17   ` Alex Bennée
2018-02-27  5:39 ` [Qemu-devel] [PATCH 08/16] translate-all: work page-by-page in tb_invalidate_phys_range_1 Emilio G. Cota
2018-02-28 22:23   ` Richard Henderson
2018-03-29 10:10   ` Alex Bennée
2018-03-29 10:17   ` Alex Bennée
2018-02-27  5:39 ` [Qemu-devel] [PATCH 09/16] translate-all: move tb_invalidate_phys_page_range up in the file Emilio G. Cota
2018-02-28 22:24   ` Richard Henderson
2018-03-29 10:08   ` Alex Bennée
2018-02-27  5:39 ` [Qemu-devel] [PATCH 10/16] translate-all: use per-page locking in !user-mode Emilio G. Cota
2018-03-29 14:55   ` Alex Bennée
2018-04-06  0:43     ` Emilio G. Cota
2018-02-27  5:39 ` [Qemu-devel] [PATCH 11/16] translate-all: add page_collection assertions Emilio G. Cota
2018-03-29 15:08   ` Alex Bennée
2018-02-27  5:39 ` [Qemu-devel] [PATCH 12/16] translate-all: discard TB when tb_link_page returns an existing matching TB Emilio G. Cota
2018-03-29 15:19   ` Alex Bennée
2018-04-06  1:23     ` Emilio G. Cota
2018-02-27  5:39 ` [Qemu-devel] [PATCH 13/16] translate-all: protect TB jumps with a per-destination-TB lock Emilio G. Cota
2018-02-27 11:33   ` Paolo Bonzini
2018-02-27 11:43     ` Laurent Desnogues
2018-02-27 14:31       ` Paolo Bonzini
2018-03-28 15:57   ` Alex Bennée [this message]
2018-02-27  5:39 ` [Qemu-devel] [PATCH 14/16] cputlb: remove tb_lock from tlb_flush functions Emilio G. Cota
2018-03-29 15:46   ` Alex Bennée
2018-02-27  5:39 ` [Qemu-devel] [PATCH 15/16] translate-all: remove tb_lock mention from cpu_restore_state_from_tb Emilio G. Cota
2018-03-29 16:06   ` Alex Bennée
2018-04-06  1:40     ` Emilio G. Cota
2018-02-27  5:39 ` [Qemu-devel] [PATCH 16/16] tcg: remove tb_lock Emilio G. Cota
2018-03-29 16:15   ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878tac8a61.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=cota@braap.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.