Re: [Qemu-devel] [PATCH 07/16] translate-all: remove hole in PageDesc

["Alex Bennée" <alex.bennee@linaro.org>]

Emilio G. Cota <cota@braap.org> writes:

> Groundwork for supporting parallel TCG generation.
>
> Move the hole to the end of the struct, so that a u32
> field can be added there without bloating the struct.
>
> Signed-off-by: Emilio G. Cota <cota@braap.org>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

> ---
>  accel/tcg/translate-all.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c
> index f2bfa71..816419a 100644
> --- a/accel/tcg/translate-all.c
> +++ b/accel/tcg/translate-all.c
> @@ -107,8 +107,8 @@ typedef struct PageDesc {
>  #ifdef CONFIG_SOFTMMU
>      /* in order to optimize self modifying code, we count the number
>         of lookups we do to a given page to use a bitmap */
> -    unsigned int code_write_count;
>      unsigned long *code_bitmap;
> +    unsigned int code_write_count;
>  #else
>      unsigned long flags;
>  #endif


--
Alex Bennée