From: Jani Nikula <jani.nikula@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>,
Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Cc: intel-gfx@lists.freedesktop.org, dim-tools@lists.freedesktop.org,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: i915 vs checkpatch
Date: Mon, 05 Mar 2018 13:10:21 +0200 [thread overview]
Message-ID: <878tb6u6aq.fsf@intel.com> (raw)
In-Reply-To: <20180305081427.GF6419@phenom.ffwll.local>
On Mon, 05 Mar 2018, Daniel Vetter <daniel@ffwll.ch> wrote:
> I'd recommend not making checkpatch ever fail CI, but at most warning.
Agreed. But we want the automated warnings on the list, neutrally from a
bot instead of a developer spending time nitpicking this stuff. And the
committers should pay attention before pushing.
Really, everyone should be running checkpatch themselves locally before
sending patches, ignoring the irrelevant warnings with good taste...
> Plus silence the ones we obviously think are silly (or currently
> inconsistent in our code).
>
> I think the ingore list is probably best kept within maintainer-tools
> itself, that way we at least have visibility into it from committers.
Agreed, but as I wrote in [1] we need to add checkpatch profiles or
config or something, because I want *all* the warnings when I run it
locally. And if we decide to, say, enforce kernel types in i915 but
drm-misc decides otherwise, that's also another config.
BR,
Jani.
[1] http://mid.mail-archive.com/87zi3qtq9f.fsf@intel.com
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-03-05 11:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 9:47 i915 vs checkpatch Arkadiusz Hiler
2018-03-01 10:43 ` Jani Nikula
2018-03-01 11:21 ` Ville Syrjälä
2018-03-02 16:07 ` Jani Nikula
2018-03-01 16:13 ` Jani Nikula
2018-03-01 18:00 ` Rodrigo Vivi
2018-03-02 9:37 ` Joonas Lahtinen
2018-03-02 10:07 ` Jani Nikula
2018-03-01 23:17 ` Chris Wilson
2018-03-05 12:55 ` Arkadiusz Hiler
2018-03-05 8:14 ` Daniel Vetter
2018-03-05 11:10 ` Jani Nikula [this message]
2018-03-05 12:44 ` Arkadiusz Hiler
2018-03-13 11:38 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878tb6u6aq.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=arkadiusz.hiler@intel.com \
--cc=daniel@ffwll.ch \
--cc=dim-tools@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.