From: Jani Nikula <jani.nikula@linux.intel.com>
To: Arkadiusz Hiler <arkadiusz.hiler@intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org, dim-tools@lists.freedesktop.org
Subject: Re: i915 vs checkpatch
Date: Fri, 02 Mar 2018 18:07:40 +0200 [thread overview]
Message-ID: <87zi3qtq9f.fsf@intel.com> (raw)
In-Reply-To: <87371kuldh.fsf@intel.com>
On Thu, 01 Mar 2018, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> Does checkpatch support disabling checks or do you have to filter them
> out from the output?
Turns out it does. There's an --ignore option. For starters, I sent a
patch [1] to show the warning types in the output, so we can more
accurately discuss the ignores.
Alas it's probably not as simple as just slamming the ignores to dim:
I'll probably want to use the strictest set both when I'm developing and
applying patches (just to get an idea about the warnings, and I try to
keep my patches under 80 columns, etc.). Some other drivers and drm core
might have different sets of rules, and dim is no longer an Intel-only
tool. So we probably need to be able to specify different rule sets.
BR,
Jani.
PS. We need to get dim-tools and igt-dev etc. subscribed to the mail
archive and marc etc.
[1] id:20180302155800.6874-1-jani.nikula@intel.com
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-03-02 16:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 9:47 i915 vs checkpatch Arkadiusz Hiler
2018-03-01 10:43 ` Jani Nikula
2018-03-01 11:21 ` Ville Syrjälä
2018-03-02 16:07 ` Jani Nikula [this message]
2018-03-01 16:13 ` Jani Nikula
2018-03-01 18:00 ` Rodrigo Vivi
2018-03-02 9:37 ` Joonas Lahtinen
2018-03-02 10:07 ` Jani Nikula
2018-03-01 23:17 ` Chris Wilson
2018-03-05 12:55 ` Arkadiusz Hiler
2018-03-05 8:14 ` Daniel Vetter
2018-03-05 11:10 ` Jani Nikula
2018-03-05 12:44 ` Arkadiusz Hiler
2018-03-13 11:38 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zi3qtq9f.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=arkadiusz.hiler@intel.com \
--cc=daniel@ffwll.ch \
--cc=dim-tools@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.