All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Petri Latvala <petri.latvala@intel.com>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] tools/intel_bios_decode: update vbt defs from kernel
Date: Fri, 19 Jan 2018 14:11:17 +0200	[thread overview]
Message-ID: <878tcuyroa.fsf@intel.com> (raw)
In-Reply-To: <20180119115646.q3xt52jqmabkzbqp@platvala-desk.ger.corp.intel.com>

On Fri, 19 Jan 2018, Petri Latvala <petri.latvala@intel.com> wrote:
> On Fri, Jan 19, 2018 at 10:56:33AM +0200, Jani Nikula wrote:
>> Sync up with the following intel_vbt_defs.h changes in kernel:
>> 
>> c4fb60b9aba9 ("drm/i915/bios: add DP max link rate to VBT child device
>> struct")
>> 
>> d6038611aa3d ("drm/i915: Parse max HDMI TMDS clock from VBT")
>> 
>> 6e8fbf8d19e4 ("drm/i915/vbt: Fix HDMI level shifter and max data rate
>> bitfield sizes")
>> 
>> 9c3b2689d01f ("drm/i915/cnl: Map VBT DDC Pin to BSpec DDC Pin.")
>> 
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Matches the kernel's file. But change the commit message with
> s/intel_bios_decode/intel_vbt_decode/?

D'oh!

> Reviewed-by: Petri Latvala <petri.latvala@intel.com>

Thanks, pushed.

BR,
Jani.

>
>
>> ---
>>  tools/intel_vbt_defs.h | 18 ++++++++++++++++--
>>  1 file changed, 16 insertions(+), 2 deletions(-)
>> 
>> diff --git a/tools/intel_vbt_defs.h b/tools/intel_vbt_defs.h
>> index e388f9ad5c33..3f5eff49105b 100644
>> --- a/tools/intel_vbt_defs.h
>> +++ b/tools/intel_vbt_defs.h
>> @@ -304,8 +304,20 @@ struct bdb_general_features {
>>  #define DVO_PORT_MIPIC		23				/* 171 */
>>  #define DVO_PORT_MIPID		24				/* 171 */
>>  
>> +#define HDMI_MAX_DATA_RATE_PLATFORM	0			/* 204 */
>> +#define HDMI_MAX_DATA_RATE_297		1			/* 204 */
>> +#define HDMI_MAX_DATA_RATE_165		2			/* 204 */
>> +
>>  #define LEGACY_CHILD_DEVICE_CONFIG_SIZE		33
>>  
>> +/* DDC Bus DDI Type 155+ */
>> +enum vbt_gmbus_ddi {
>> +	DDC_BUS_DDI_B = 0x1,
>> +	DDC_BUS_DDI_C,
>> +	DDC_BUS_DDI_D,
>> +	DDC_BUS_DDI_F,
>> +};
>> +
>>  /*
>>   * The child device config, aka the display device data structure, provides a
>>   * description of a port and its configuration on the platform.
>> @@ -334,8 +346,8 @@ struct child_device_config {
>>  			u8 i2c_speed;
>>  			u8 dp_onboard_redriver;			/* 158 */
>>  			u8 dp_ondock_redriver;			/* 158 */
>> -			u8 hdmi_level_shifter_value:4;		/* 169 */
>> -			u8 hdmi_max_data_rate:4;		/* 204 */
>> +			u8 hdmi_level_shifter_value:5;		/* 169 */
>> +			u8 hdmi_max_data_rate:3;		/* 204 */
>>  			u16 dtd_buf_ptr;			/* 161 */
>>  			u8 edidless_efp:1;			/* 161 */
>>  			u8 compression_enable:1;		/* 198 */
>> @@ -400,6 +412,8 @@ struct child_device_config {
>>  	u16 dp_gpio_pin_num;					/* 195 */
>>  	u8 dp_iboost_level:4;					/* 196 */
>>  	u8 hdmi_iboost_level:4;					/* 196 */
>> +	u8 dp_max_link_rate:2;					/* 216 CNL+ */
>> +	u8 dp_max_link_rate_reserved:6;				/* 216 */
>>  } __packed;
>>  
>>  struct bdb_general_definitions {
>> -- 
>> 2.11.0
>> 
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@intel.com>
To: Petri Latvala <petri.latvala@intel.com>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] tools/intel_bios_decode: update vbt defs from kernel
Date: Fri, 19 Jan 2018 14:11:17 +0200	[thread overview]
Message-ID: <878tcuyroa.fsf@intel.com> (raw)
In-Reply-To: <20180119115646.q3xt52jqmabkzbqp@platvala-desk.ger.corp.intel.com>

On Fri, 19 Jan 2018, Petri Latvala <petri.latvala@intel.com> wrote:
> On Fri, Jan 19, 2018 at 10:56:33AM +0200, Jani Nikula wrote:
>> Sync up with the following intel_vbt_defs.h changes in kernel:
>> 
>> c4fb60b9aba9 ("drm/i915/bios: add DP max link rate to VBT child device
>> struct")
>> 
>> d6038611aa3d ("drm/i915: Parse max HDMI TMDS clock from VBT")
>> 
>> 6e8fbf8d19e4 ("drm/i915/vbt: Fix HDMI level shifter and max data rate
>> bitfield sizes")
>> 
>> 9c3b2689d01f ("drm/i915/cnl: Map VBT DDC Pin to BSpec DDC Pin.")
>> 
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Matches the kernel's file. But change the commit message with
> s/intel_bios_decode/intel_vbt_decode/?

D'oh!

> Reviewed-by: Petri Latvala <petri.latvala@intel.com>

Thanks, pushed.

BR,
Jani.

>
>
>> ---
>>  tools/intel_vbt_defs.h | 18 ++++++++++++++++--
>>  1 file changed, 16 insertions(+), 2 deletions(-)
>> 
>> diff --git a/tools/intel_vbt_defs.h b/tools/intel_vbt_defs.h
>> index e388f9ad5c33..3f5eff49105b 100644
>> --- a/tools/intel_vbt_defs.h
>> +++ b/tools/intel_vbt_defs.h
>> @@ -304,8 +304,20 @@ struct bdb_general_features {
>>  #define DVO_PORT_MIPIC		23				/* 171 */
>>  #define DVO_PORT_MIPID		24				/* 171 */
>>  
>> +#define HDMI_MAX_DATA_RATE_PLATFORM	0			/* 204 */
>> +#define HDMI_MAX_DATA_RATE_297		1			/* 204 */
>> +#define HDMI_MAX_DATA_RATE_165		2			/* 204 */
>> +
>>  #define LEGACY_CHILD_DEVICE_CONFIG_SIZE		33
>>  
>> +/* DDC Bus DDI Type 155+ */
>> +enum vbt_gmbus_ddi {
>> +	DDC_BUS_DDI_B = 0x1,
>> +	DDC_BUS_DDI_C,
>> +	DDC_BUS_DDI_D,
>> +	DDC_BUS_DDI_F,
>> +};
>> +
>>  /*
>>   * The child device config, aka the display device data structure, provides a
>>   * description of a port and its configuration on the platform.
>> @@ -334,8 +346,8 @@ struct child_device_config {
>>  			u8 i2c_speed;
>>  			u8 dp_onboard_redriver;			/* 158 */
>>  			u8 dp_ondock_redriver;			/* 158 */
>> -			u8 hdmi_level_shifter_value:4;		/* 169 */
>> -			u8 hdmi_max_data_rate:4;		/* 204 */
>> +			u8 hdmi_level_shifter_value:5;		/* 169 */
>> +			u8 hdmi_max_data_rate:3;		/* 204 */
>>  			u16 dtd_buf_ptr;			/* 161 */
>>  			u8 edidless_efp:1;			/* 161 */
>>  			u8 compression_enable:1;		/* 198 */
>> @@ -400,6 +412,8 @@ struct child_device_config {
>>  	u16 dp_gpio_pin_num;					/* 195 */
>>  	u8 dp_iboost_level:4;					/* 196 */
>>  	u8 hdmi_iboost_level:4;					/* 196 */
>> +	u8 dp_max_link_rate:2;					/* 216 CNL+ */
>> +	u8 dp_max_link_rate_reserved:6;				/* 216 */
>>  } __packed;
>>  
>>  struct bdb_general_definitions {
>> -- 
>> 2.11.0
>> 
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-01-19 12:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-19  8:56 [igt-dev] [PATCH i-g-t] tools/intel_bios_decode: update vbt defs from kernel Jani Nikula
2018-01-19  8:56 ` Jani Nikula
2018-01-19  9:35 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-01-19 11:56 ` [Intel-gfx] [PATCH i-g-t] " Petri Latvala
2018-01-19 11:56   ` Petri Latvala
2018-01-19 12:11   ` Jani Nikula [this message]
2018-01-19 12:11     ` Jani Nikula
2018-01-19 13:16 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878tcuyroa.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=petri.latvala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.