All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: Kamil Rytarowski <n54@gmx.com>,
	qemu-trivial@nongnu.org, peter.maydell@redhat.com,
	marcandre.lureau@gmail.com, qemu-devel@nongnu.org,
	f4bug@amsat.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v3] ivshmem-server: ivshmem-client: Build when eventfd() is available
Date: Tue, 06 Jun 2017 13:05:05 +0200	[thread overview]
Message-ID: <878tl5wf4u.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <b60c5d7b-6ae7-4aa0-6263-b96c964b9195@msgid.tls.msk.ru> (Michael Tokarev's message of "Tue, 6 Jun 2017 10:10:06 +0300")

Michael Tokarev <mjt@tls.msk.ru> writes:

> 06.06.2017 09:54, Markus Armbruster wrote:
>
> [ ./configure --disable-linux-user --disable-system --static ]
>
>> I haven't, but here's a quick guess on what we need to squash into the
>> patch:
>> 
>> diff --git a/Makefile b/Makefile
>> index c830d7a..2ef5a78 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -469,10 +469,12 @@ ifneq ($(EXESUF),)
>>  qemu-ga: qemu-ga$(EXESUF) $(QGA_VSS_PROVIDER) $(QEMU_GA_MSI)
>>  endif
>>  
>> +ifdef CONFIG_IVSHMEM
>>  ivshmem-client$(EXESUF): $(ivshmem-client-obj-y) $(COMMON_LDADDS)
>>  	$(call LINK, $^)
>>  ivshmem-server$(EXESUF): $(ivshmem-server-obj-y) $(COMMON_LDADDS)
>>  	$(call LINK, $^)
>> +endif
>
> This effectively disables building ivshmem executables on this config
> on linux, while previously they were building fine. Hmm..

These executables are only useful together with an ivshmem device.  Not
building them when they can't be useful makes sense to me.

See previous discussion
Message-ID: <87fufwjfqw.fsf@dusky.pond.sub.org>
https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg05108.html


WARNING: multiple messages have this Message-ID (diff)
From: Markus Armbruster <armbru@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: Kamil Rytarowski <n54@gmx.com>,
	qemu-trivial@nongnu.org, peter.maydell@redhat.com,
	marcandre.lureau@gmail.com, qemu-devel@nongnu.org,
	f4bug@amsat.org
Subject: Re: [Qemu-devel] [PATCH v3] ivshmem-server: ivshmem-client: Build when eventfd() is available
Date: Tue, 06 Jun 2017 13:05:05 +0200	[thread overview]
Message-ID: <878tl5wf4u.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <b60c5d7b-6ae7-4aa0-6263-b96c964b9195@msgid.tls.msk.ru> (Michael Tokarev's message of "Tue, 6 Jun 2017 10:10:06 +0300")

Michael Tokarev <mjt@tls.msk.ru> writes:

> 06.06.2017 09:54, Markus Armbruster wrote:
>
> [ ./configure --disable-linux-user --disable-system --static ]
>
>> I haven't, but here's a quick guess on what we need to squash into the
>> patch:
>> 
>> diff --git a/Makefile b/Makefile
>> index c830d7a..2ef5a78 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -469,10 +469,12 @@ ifneq ($(EXESUF),)
>>  qemu-ga: qemu-ga$(EXESUF) $(QGA_VSS_PROVIDER) $(QEMU_GA_MSI)
>>  endif
>>  
>> +ifdef CONFIG_IVSHMEM
>>  ivshmem-client$(EXESUF): $(ivshmem-client-obj-y) $(COMMON_LDADDS)
>>  	$(call LINK, $^)
>>  ivshmem-server$(EXESUF): $(ivshmem-server-obj-y) $(COMMON_LDADDS)
>>  	$(call LINK, $^)
>> +endif
>
> This effectively disables building ivshmem executables on this config
> on linux, while previously they were building fine. Hmm..

These executables are only useful together with an ivshmem device.  Not
building them when they can't be useful makes sense to me.

See previous discussion
Message-ID: <87fufwjfqw.fsf@dusky.pond.sub.org>
https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg05108.html

  reply	other threads:[~2017-06-06 11:05 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-31 12:00 [Qemu-trivial] [PATCH v3] ivshmem-server: ivshmem-client: Build when eventfd() is available Kamil Rytarowski
2017-05-31 12:00 ` [Qemu-devel] " Kamil Rytarowski
2017-06-01 10:00 ` [Qemu-trivial] " Michael Tokarev
2017-06-01 10:00   ` [Qemu-devel] " Michael Tokarev
2017-06-05 14:29 ` [Qemu-trivial] " Michael Tokarev
2017-06-05 14:29   ` [Qemu-devel] " Michael Tokarev
2017-06-05 14:52   ` [Qemu-trivial] " Kamil Rytarowski
2017-06-05 14:52     ` [Qemu-devel] " Kamil Rytarowski
2017-06-06  6:54     ` [Qemu-trivial] [Qemu-devel] " Markus Armbruster
2017-06-06  6:54       ` [Qemu-devel] [Qemu-trivial] " Markus Armbruster
2017-06-06  7:10       ` Michael Tokarev
2017-06-06  7:10         ` [Qemu-devel] " Michael Tokarev
2017-06-06 11:05         ` Markus Armbruster [this message]
2017-06-06 11:05           ` Markus Armbruster
2017-06-06 13:38         ` [Qemu-trivial] " Kamil Rytarowski
2017-06-06 13:38           ` [Qemu-devel] " Kamil Rytarowski
2017-06-06 14:34           ` [Qemu-trivial] " Peter Maydell
2017-06-06 14:34             ` [Qemu-devel] " Peter Maydell
2017-06-06 14:56             ` [Qemu-trivial] " Kamil Rytarowski
2017-06-06 14:56               ` Kamil Rytarowski
2017-06-10 13:41               ` [Qemu-trivial] " Kamil Rytarowski
2017-06-10 13:41                 ` Kamil Rytarowski
2017-06-10 15:15                 ` [Qemu-trivial] " Markus Armbruster
2017-06-10 15:15                   ` Markus Armbruster
2017-06-10 15:24                   ` [Qemu-trivial] " Kamil Rytarowski
2017-06-10 15:24                     ` [Qemu-devel] [Qemu-trivial] " Kamil Rytarowski
2017-06-19  7:42                     ` [Qemu-trivial] [Qemu-devel] " Markus Armbruster
2017-06-19  7:42                       ` [Qemu-devel] [Qemu-trivial] " Markus Armbruster
2017-06-19 11:06                       ` [Qemu-trivial] [Qemu-devel] " Kamil Rytarowski
2017-06-19 11:06                         ` [Qemu-devel] [Qemu-trivial] " Kamil Rytarowski
2017-06-22 15:54   ` [Qemu-trivial] [Qemu-devel] " Peter Maydell
2017-06-22 15:54     ` Peter Maydell
2017-06-22 16:24     ` [Qemu-trivial] " Philippe Mathieu-Daudé
2017-06-22 16:24       ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878tl5wf4u.fsf@dusky.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=marcandre.lureau@gmail.com \
    --cc=mjt@tls.msk.ru \
    --cc=n54@gmx.com \
    --cc=peter.maydell@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.