Re: [Qemu-trivial] [Qemu-devel] [PATCH] configure: Check if struct fsxattr is available from linux header

[Markus Armbruster <armbru@redhat.com>]

Jan Vesely <jano.vesely@gmail.com> writes:

> On Tue, 2016-04-12 at 17:09 -0400, Jan Vesely wrote:
>> On Sat, 2016-03-19 at 21:18 -0400, Jan Vesely wrote:
>> > 
>> > Fixes build with new linux headers.
>> > 
>> > Signed-off-by: Jan Vesely <jano.vesely@gmail.com>
>> > ---
>> > linux-headers-4.5 and xfsprogs-3.2.4 in my case
>> > 
>> >  configure | 18 ++++++++++++++++++
>> >  1 file changed, 18 insertions(+)
>> > 
>> > diff --git a/configure b/configure
>> > index b88d0db..bb64d6c 100755
>> > --- a/configure
>> > +++ b/configure
>> > @@ -4474,6 +4474,21 @@ if test "$fortify_source" != "no"; then
>> >    fi
>> >  fi
>> >  
>> > +########################################
>> > +# check if struct fsxattr is available
>> > +
>> > +have_fsxattr=no
>> > +cat > $TMPC << EOF
>> > +#include <linux/fs.h>
>> > +struct fsxattr foo;
>> > +int main(void) {
>> > +  return 0;
>> > +}
>> > +EOF
>> > +if compile_prog "" "" ; then
>> > +    have_fsxattr=yes
>> > +fi
>> > +
>> >  ##########################################
>> >  # End of CC checks
>> >  # After here, no more $cc or $ld runs
>> > @@ -5137,6 +5152,9 @@ fi
>> >  if test "$have_ifaddrs_h" = "yes" ; then
>> >      echo "HAVE_IFADDRS_H=y" >> $config_host_mak
>> >  fi
>> > +if test "$have_fsxattr" = "yes" ; then
>> > +    echo "HAVE_FSXATTR=y" >> $config_host_mak
>> > +fi
>> >  if test "$vte" = "yes" ; then
>> >    echo "CONFIG_VTE=y" >> $config_host_mak
>> >    echo "VTE_CFLAGS=$vte_cflags" >> $config_host_mak
>> gentle ping.
>> the docs say trivial patches are collected every week. yet the last
>> one
>> was in Feb.
>> 
>
> gentle ping v2. Is there a maintainer for configure? get_maintainer.pl
> was not helpful.

This might be trivial if you explain what's broken without it in more
detail.  The explanation belongs into the commit message.

Now let's look for victims^Wreviewers:

    $ scripts/get_maintainer.pl -f configure 
    get_maintainer.pl: No maintainers found, printing recent contributors.
    get_maintainer.pl: Do not blindly cc: them on patches!  Use common sense.

    "Daniel P. Berrange" <berrange@redhat.com> (commit_signer:21/95=22%)
    Paolo Bonzini <pbonzini@redhat.com> (commit_signer:21/95=22%)
    Stefan Hajnoczi <stefanha@redhat.com> (commit_signer:15/95=16%)
    Gerd Hoffmann <kraxel@redhat.com> (commit_signer:11/95=12%)
    Peter Maydell <peter.maydell@linaro.org> (commit_signer:11/95=12%)
    qemu-devel@nongnu.org (open list:All patches CC here)

    $ scripts/get_maintainer.pl -f --git-since "5-years-ago" configure 
    get_maintainer.pl: No maintainers found, printing recent contributors.
    get_maintainer.pl: Do not blindly cc: them on patches!  Use common sense.

    Peter Maydell <peter.maydell@linaro.org> (commit_signer:135/686=20%)
    Anthony Liguori <aliguori@amazon.com> (commit_signer:119/686=17%)
    Stefan Hajnoczi <stefanha@redhat.com> (commit_signer:113/686=16%)
    Paolo Bonzini <pbonzini@redhat.com> (commit_signer:110/686=16%)
    Stefan Weil <sw@weilnetz.de> (commit_signer:78/686=11%)
    qemu-devel@nongnu.org (open list:All patches CC here)

    $ scripts/get_maintainer.pl --git-blame -f configure 
    Peter Maydell <peter.maydell@linaro.org> (authored lines:611/5975=10%,commits:91/703=13%)
    Juan Quintela <quintela@redhat.com> (authored lines:486/5975=8%,commits:78/703=11%)
    "Daniel P. Berrange" <berrange@redhat.com> (authored lines:355/5975=6%)
    Anthony Liguori <anthony@codemonkey.ws> (commits:178/703=25%)
    Paolo Bonzini <pbonzini@redhat.com> (commits:90/703=13%)
    Stefan Hajnoczi <stefanha@linux.vnet.ibm.com> (commits:88/703=13%)
    qemu-devel@nongnu.org (open list:All patches CC here)

Suggest to copy Paolo Bonzini, Peter Maydell, Stefan Hajnoczi on your
respin.