From: Markus Armbruster <armbru@redhat.com>
To: zhanghailiang <zhang.zhanghailiang@huawei.com>
Cc: qemu-trivial@nongnu.org, peter.huangpeng@huawei.com,
qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH RFC 4/5] pci-assign: Avoid qerror_report_err() outside QMP command handlers
Date: Mon, 02 Mar 2015 11:14:20 +0100 [thread overview]
Message-ID: <878uffhfk3.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <1425114327-12136-5-git-send-email-zhang.zhanghailiang@huawei.com> (zhanghailiang's message of "Sat, 28 Feb 2015 17:05:26 +0800")
zhanghailiang <zhang.zhanghailiang@huawei.com> writes:
> qerror_report_err() is a transitional interface to help with
> converting existing monitor commands to QMP. It should not be used
> elsewhere. Replace by error_report_err() in assigned_initfn().
>
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> ---
> hw/i386/kvm/pci-assign.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c
> index bd92c69..f2f4e07 100644
> --- a/hw/i386/kvm/pci-assign.c
> +++ b/hw/i386/kvm/pci-assign.c
> @@ -1831,8 +1831,7 @@ out:
>
> exit_with_error:
> assert(local_err);
> - qerror_report_err(local_err);
> - error_free(local_err);
> + error_report_err(local_err);
> return -1;
> }
This breaks the error reply when you hot plug the devices via QMP
device_add.
A correct solution is my "[PATCH 10/10] pci-assign: Convert to realize".
WARNING: multiple messages have this Message-ID (diff)
From: Markus Armbruster <armbru@redhat.com>
To: zhanghailiang <zhang.zhanghailiang@huawei.com>
Cc: qemu-trivial@nongnu.org, peter.huangpeng@huawei.com,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH RFC 4/5] pci-assign: Avoid qerror_report_err() outside QMP command handlers
Date: Mon, 02 Mar 2015 11:14:20 +0100 [thread overview]
Message-ID: <878uffhfk3.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <1425114327-12136-5-git-send-email-zhang.zhanghailiang@huawei.com> (zhanghailiang's message of "Sat, 28 Feb 2015 17:05:26 +0800")
zhanghailiang <zhang.zhanghailiang@huawei.com> writes:
> qerror_report_err() is a transitional interface to help with
> converting existing monitor commands to QMP. It should not be used
> elsewhere. Replace by error_report_err() in assigned_initfn().
>
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> ---
> hw/i386/kvm/pci-assign.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c
> index bd92c69..f2f4e07 100644
> --- a/hw/i386/kvm/pci-assign.c
> +++ b/hw/i386/kvm/pci-assign.c
> @@ -1831,8 +1831,7 @@ out:
>
> exit_with_error:
> assert(local_err);
> - qerror_report_err(local_err);
> - error_free(local_err);
> + error_report_err(local_err);
> return -1;
> }
This breaks the error reply when you hot plug the devices via QMP
device_add.
A correct solution is my "[PATCH 10/10] pci-assign: Convert to realize".
next prev parent reply other threads:[~2015-03-02 10:14 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-28 9:05 [Qemu-trivial] [PATCH RFC 0/5] Another patchset try to clean up around qerror_report_err() zhanghailiang
2015-02-28 9:05 ` [Qemu-devel] " zhanghailiang
2015-02-28 9:05 ` [Qemu-trivial] [PATCH RFC 1/5] serial-pci: Avoid qerror_report_err() outside QMP command handlers zhanghailiang
2015-02-28 9:05 ` [Qemu-devel] " zhanghailiang
2015-03-02 10:02 ` [Qemu-trivial] " Markus Armbruster
2015-03-02 10:02 ` Markus Armbruster
2015-02-28 9:05 ` [Qemu-trivial] [PATCH RFC 2/5] qdev: " zhanghailiang
2015-02-28 9:05 ` [Qemu-devel] " zhanghailiang
2015-03-02 10:11 ` [Qemu-trivial] " Markus Armbruster
2015-03-02 10:11 ` Markus Armbruster
2015-02-28 9:05 ` [Qemu-trivial] [PATCH RFC 3/5] pci-hotplug-old: " zhanghailiang
2015-02-28 9:05 ` [Qemu-devel] " zhanghailiang
2015-03-02 10:12 ` [Qemu-trivial] " Markus Armbruster
2015-03-02 10:12 ` Markus Armbruster
2015-02-28 9:05 ` [Qemu-trivial] [PATCH RFC 4/5] pci-assign: " zhanghailiang
2015-02-28 9:05 ` [Qemu-devel] " zhanghailiang
2015-03-02 10:14 ` Markus Armbruster [this message]
2015-03-02 10:14 ` Markus Armbruster
2015-02-28 9:05 ` [Qemu-trivial] [PATCH RFC 5/5] savevm: Replace error_report() & error_free() with error_report_err() zhanghailiang
2015-02-28 9:05 ` [Qemu-devel] " zhanghailiang
2015-03-02 10:26 ` [Qemu-trivial] " Markus Armbruster
2015-03-02 10:26 ` Markus Armbruster
2015-03-03 6:11 ` [Qemu-trivial] " zhanghailiang
2015-03-03 6:11 ` zhanghailiang
2015-03-03 9:19 ` [Qemu-trivial] " Markus Armbruster
2015-03-03 9:19 ` Markus Armbruster
2015-03-03 9:34 ` [Qemu-trivial] " zhanghailiang
2015-03-03 9:34 ` zhanghailiang
2015-03-02 10:01 ` [Qemu-trivial] [Qemu-devel] [PATCH RFC 0/5] Another patchset try to clean up around qerror_report_err() Markus Armbruster
2015-03-02 10:01 ` Markus Armbruster
2015-03-03 6:08 ` [Qemu-trivial] " zhanghailiang
2015-03-03 6:08 ` zhanghailiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878uffhfk3.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.