From: Kevin Hilman <khilman@deeprootsystems.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Tony Lindgren <tony@atomide.com>, Paul Walmsley <paul@pwsan.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Linux ARM Kernel Mailing List
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC/NOT FOR MERGING 3/5] arm: omap: introduce other PM methods
Date: Thu, 18 Oct 2012 10:07:31 -0700 [thread overview]
Message-ID: <878vb3g14c.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1350488043-5053-4-git-send-email-balbi@ti.com> (Felipe Balbi's message of "Wed, 17 Oct 2012 18:34:01 +0300")
Felipe Balbi <balbi@ti.com> writes:
> current omap_device PM implementation defines
> omap-specific *_noirq methods but uses the
> generic versions for all other PM methods.
>
> As it turns out, if a device decides to implement
> non-runtime PM callbacks, we might fall into a
> situation where the hwmod is still idled which
> will generate an abort exception when we try
> to access device's address space while clocks
> are still gated.
Please explain in more detail how this could happen.
Kevin
> In order to solve that, we implement all other
> methods taking into account that devices might
> not implement those, in which case we return
> early.
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
WARNING: multiple messages have this Message-ID (diff)
From: khilman@deeprootsystems.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC/NOT FOR MERGING 3/5] arm: omap: introduce other PM methods
Date: Thu, 18 Oct 2012 10:07:31 -0700 [thread overview]
Message-ID: <878vb3g14c.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1350488043-5053-4-git-send-email-balbi@ti.com> (Felipe Balbi's message of "Wed, 17 Oct 2012 18:34:01 +0300")
Felipe Balbi <balbi@ti.com> writes:
> current omap_device PM implementation defines
> omap-specific *_noirq methods but uses the
> generic versions for all other PM methods.
>
> As it turns out, if a device decides to implement
> non-runtime PM callbacks, we might fall into a
> situation where the hwmod is still idled which
> will generate an abort exception when we try
> to access device's address space while clocks
> are still gated.
Please explain in more detail how this could happen.
Kevin
> In order to solve that, we implement all other
> methods taking into account that devices might
> not implement those, in which case we return
> early.
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
next prev parent reply other threads:[~2012-10-18 17:07 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 15:33 [RFC/NOT FOR MERGING 0/5] OMAP PM patches Felipe Balbi
2012-10-17 15:33 ` Felipe Balbi
2012-10-17 15:33 ` [RFC/NOT FOR MERGING 1/5] arm: omap: fix up _od_suspend_noirq and _od_resume_noirq Felipe Balbi
2012-10-17 15:39 ` Felipe Balbi
2012-10-18 16:34 ` Kevin Hilman
2012-10-18 16:34 ` Kevin Hilman
2012-10-18 16:55 ` Felipe Balbi
2012-10-18 16:55 ` Felipe Balbi
2012-10-18 17:42 ` Kevin Hilman
2012-10-18 17:42 ` Kevin Hilman
2012-10-18 17:50 ` Felipe Balbi
2012-10-18 17:50 ` Felipe Balbi
2012-10-18 18:42 ` Kevin Hilman
2012-10-18 18:42 ` Kevin Hilman
2012-10-18 19:34 ` Felipe Balbi
2012-10-18 19:34 ` Felipe Balbi
2012-10-18 20:47 ` Kevin Hilman
2012-10-18 20:47 ` Kevin Hilman
2012-10-18 20:58 ` Kevin Hilman
2012-10-18 20:58 ` Kevin Hilman
2012-10-17 15:34 ` [RFC/NOT FOR MERGING 2/5] arm: omap: don't forcefully runtime suspend a device Felipe Balbi
2012-10-17 15:39 ` Felipe Balbi
2012-10-18 17:01 ` Kevin Hilman
2012-10-18 17:01 ` Kevin Hilman
2012-10-18 17:05 ` Felipe Balbi
2012-10-18 17:05 ` Felipe Balbi
2012-10-17 15:34 ` [RFC/NOT FOR MERGING 3/5] arm: omap: introduce other PM methods Felipe Balbi
2012-10-17 15:39 ` Felipe Balbi
2012-10-18 17:07 ` Kevin Hilman [this message]
2012-10-18 17:07 ` Kevin Hilman
2012-10-18 17:06 ` Felipe Balbi
2012-10-18 17:06 ` Felipe Balbi
2012-10-18 17:23 ` Felipe Balbi
2012-10-18 17:23 ` Felipe Balbi
2012-10-17 15:34 ` [RFC/NOT FOR MERGING 4/5] i2c: omap: don't re-enable IRQs after masking them Felipe Balbi
2012-10-17 15:39 ` Felipe Balbi
2012-10-18 17:10 ` Kevin Hilman
2012-10-18 17:10 ` Kevin Hilman
2012-10-18 17:07 ` Felipe Balbi
2012-10-18 17:07 ` Felipe Balbi
2012-10-17 15:34 ` [RFC/NOT FOR MERGING 5/5] i2c: omap: introduce suspend/resume methods Felipe Balbi
2012-10-17 15:39 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878vb3g14c.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.