From: Chris Ball <cjb@laptop.org>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: ludovic.desroches@atmel.com, linux-mmc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, nicolas.ferre@atmel.com,
devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH v4 1/3] mmc: atmel-mci: add device tree support
Date: Thu, 24 May 2012 10:40:07 -0400 [thread overview]
Message-ID: <878vghfxrs.fsf@laptop.org> (raw)
In-Reply-To: <20120524094304.GH3377@game.jcrosoft.org> (Jean-Christophe PLAGNIOL-VILLARD's message of "Thu, 24 May 2012 11:43:04 +0200")
Hi,
On Thu, May 24 2012, Jean-Christophe PLAGNIOL-VILLARD wrote:
>> +
>> + pdata->slot[slot_id].detect_is_active_high =
>> + of_property_read_bool(cnp, "cd-inverted");
>
> I really this this is redondant with gpio binding
>
> Chris??
Hm, I think go ahead and add it for now -- I agree it's redundant, but
we should go through and remove the redundancy from all drivers (and the
binding document, which is in 3.5-rc1 now) at once later. Since it's in
the bindings doc, best to implement it until that changes.
Thanks,
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
WARNING: multiple messages have this Message-ID (diff)
From: cjb@laptop.org (Chris Ball)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/3] mmc: atmel-mci: add device tree support
Date: Thu, 24 May 2012 10:40:07 -0400 [thread overview]
Message-ID: <878vghfxrs.fsf@laptop.org> (raw)
In-Reply-To: <20120524094304.GH3377@game.jcrosoft.org> (Jean-Christophe PLAGNIOL-VILLARD's message of "Thu, 24 May 2012 11:43:04 +0200")
Hi,
On Thu, May 24 2012, Jean-Christophe PLAGNIOL-VILLARD wrote:
>> +
>> + pdata->slot[slot_id].detect_is_active_high =
>> + of_property_read_bool(cnp, "cd-inverted");
>
> I really this this is redondant with gpio binding
>
> Chris??
Hm, I think go ahead and add it for now -- I agree it's redundant, but
we should go through and remove the redundancy from all drivers (and the
binding document, which is in 3.5-rc1 now) at once later. Since it's in
the bindings doc, best to implement it until that changes.
Thanks,
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2012-05-24 14:40 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 10:09 [PATCH v3 0/3] atmel-mci device tree support ludovic.desroches
2012-05-22 10:09 ` ludovic.desroches at atmel.com
2012-05-22 10:09 ` [PATCH v3 1/3] mmc: atmel-mci: add " ludovic.desroches
2012-05-22 10:09 ` ludovic.desroches at atmel.com
2012-05-22 12:55 ` Nicolas Ferre
2012-05-22 12:55 ` Nicolas Ferre
2012-05-22 14:08 ` Jean-Christophe PLAGNIOL-VILLARD
2012-05-22 14:08 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <20120522140845.GA3377-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
2012-05-22 14:48 ` ludovic.desroches
2012-05-22 14:48 ` ludovic.desroches
[not found] ` <4FBBA756.8030501-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-05-22 15:10 ` Jean-Christophe PLAGNIOL-VILLARD
2012-05-22 15:10 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <20120522151048.GD3377-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
2012-05-22 15:18 ` Nicolas Ferre
2012-05-22 15:18 ` Nicolas Ferre
2012-05-23 7:23 ` [PATCH v4 " ludovic.desroches
2012-05-23 7:23 ` ludovic.desroches at atmel.com
2012-05-24 9:43 ` Jean-Christophe PLAGNIOL-VILLARD
2012-05-24 9:43 ` Jean-Christophe PLAGNIOL-VILLARD
2012-05-24 14:40 ` Chris Ball [this message]
2012-05-24 14:40 ` Chris Ball
2012-05-22 10:09 ` [PATCH v3 2/3] ARM: at91: add clocks for DT entries ludovic.desroches
2012-05-22 10:09 ` ludovic.desroches at atmel.com
2012-05-22 12:56 ` Nicolas Ferre
2012-05-22 12:56 ` Nicolas Ferre
2012-05-22 14:11 ` Jean-Christophe PLAGNIOL-VILLARD
2012-05-22 14:11 ` Jean-Christophe PLAGNIOL-VILLARD
2012-05-23 19:38 ` [PATCH v4 " ludovic.desroches
2012-05-23 19:38 ` ludovic.desroches at atmel.com
2012-05-24 9:43 ` Jean-Christophe PLAGNIOL-VILLARD
2012-05-24 9:43 ` Jean-Christophe PLAGNIOL-VILLARD
2012-05-22 10:09 ` [PATCH v3 3/3] ARM: dts: add nodes for atmel hsmci controllers for atmel platforms ludovic.desroches
2012-05-22 10:09 ` ludovic.desroches at atmel.com
2012-05-22 13:11 ` Nicolas Ferre
2012-05-22 13:11 ` Nicolas Ferre
2012-05-22 14:13 ` Jean-Christophe PLAGNIOL-VILLARD
2012-05-22 14:13 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <20120522141348.GC3377-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
2012-05-22 14:41 ` ludovic.desroches
2012-05-22 14:41 ` ludovic.desroches
2012-05-23 19:42 ` [PATCH v4 " ludovic.desroches
2012-05-23 19:42 ` ludovic.desroches at atmel.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878vghfxrs.fsf@laptop.org \
--to=cjb@laptop.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ludovic.desroches@atmel.com \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.