Re: [PATCH] powerpc: fix compile fail in hugetlb cmdline parsing

[Rusty Russell <rusty@rustcorp.com.au>]

On Mon,  7 May 2012 10:32:22 -0400, Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
> Commit 9fb48c744ba6a4bf58b666f4e6fdac3008ea1bd4
> 
>     "params: add 3rd arg to option handler callback signature"
> 
> added an extra arg to the function, but didn't catch all the use
> cases needing it, causing this compile fail in mpc85xx_defconfig:
> 
>  arch/powerpc/mm/hugetlbpage.c:316:4: error: passing argument 7 of
>  'parse_args' from incompatible pointer type [-Werror]
> 
>  include/linux/moduleparam.h:317:12: note: expected
> 	 'int (*)(char *, char *, const char *)' but argument is of type
> 	 'int (*)(char *, char *)'
> 
> This function has no need to printk out the "doing" value, so
> just add the arg as an "unused".
> 
> Cc: Rusty Russell <rusty@rustcorp.com.au>
> Cc: Jim Cromie <jim.cromie@gmail.com>
> Cc: Jason Baron <jbaron@redhat.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Becky Bruce <beckyb@kernel.crashing.org>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Acked-by: Rusty Russell <rusty@rustcorp.com.au>

Thanks,
Rusty.