From: Rusty Russell <rusty@rustcorp.com.au>
To: "Russell King - ARM Linux" <linux@arm.linux.org.uk>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Tony Lindgren <tony@atomide.com>,
linux-kernel@vger.kernel.org,
Anders Kaseorg <andersk@ksplice.com>,
Greg KH <gregkh@linuxfoundation.org>,
linux-omap@vger.kernel.org, Ben Hutchings <ben@decadent.org.uk>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] modpost: Fix section warnings for ARM for many compilers
Date: Tue, 14 Feb 2012 10:59:12 +1030 [thread overview]
Message-ID: <878vk6cl5z.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20120213225118.GC31482@n2100.arm.linux.org.uk>
On Mon, 13 Feb 2012 22:51:18 +0000, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
> On Mon, Feb 13, 2012 at 11:26:52PM +0100, Uwe Kleine-König wrote:
> > On Mon, Feb 13, 2012 at 01:24:01PM -0800, Tony Lindgren wrote:
> > Maybe:
> >
> > #ifndef R_ARM_CALL
> > #warning "you're elf.h include is outdated"
>
> "You are elf.h include is outdated" does not make sense.
>
> Why are you calling Tony an elf.h include?
Because he knew it would attract the attention of pedants to the patch?
:)
Just do the #ifndef, and skip the warning. There's not much the poor
user receiving the warning can do about it.
Acked-by: Rusty Russell <rusty@rustcorp.com.au>
Thanks,
Rusty.
WARNING: multiple messages have this Message-ID (diff)
From: rusty@rustcorp.com.au (Rusty Russell)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] modpost: Fix section warnings for ARM for many compilers
Date: Tue, 14 Feb 2012 10:59:12 +1030 [thread overview]
Message-ID: <878vk6cl5z.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20120213225118.GC31482@n2100.arm.linux.org.uk>
On Mon, 13 Feb 2012 22:51:18 +0000, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
> On Mon, Feb 13, 2012 at 11:26:52PM +0100, Uwe Kleine-K?nig wrote:
> > On Mon, Feb 13, 2012 at 01:24:01PM -0800, Tony Lindgren wrote:
> > Maybe:
> >
> > #ifndef R_ARM_CALL
> > #warning "you're elf.h include is outdated"
>
> "You are elf.h include is outdated" does not make sense.
>
> Why are you calling Tony an elf.h include?
Because he knew it would attract the attention of pedants to the patch?
:)
Just do the #ifndef, and skip the warning. There's not much the poor
user receiving the warning can do about it.
Acked-by: Rusty Russell <rusty@rustcorp.com.au>
Thanks,
Rusty.
next prev parent reply other threads:[~2012-02-14 0:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-13 21:24 [PATCH] modpost: Fix section warnings for ARM for many compilers Tony Lindgren
2012-02-13 21:24 ` Tony Lindgren
2012-02-13 22:26 ` Uwe Kleine-König
2012-02-13 22:26 ` Uwe Kleine-König
2012-02-13 22:51 ` Russell King - ARM Linux
2012-02-13 22:51 ` Russell King - ARM Linux
2012-02-13 22:51 ` Russell King - ARM Linux
2012-02-14 0:29 ` Rusty Russell [this message]
2012-02-14 0:29 ` Rusty Russell
2012-02-14 1:12 ` Tony Lindgren
2012-02-14 1:12 ` Tony Lindgren
2012-02-14 21:01 ` Tony Lindgren
2012-02-14 21:01 ` Tony Lindgren
2012-02-14 21:01 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878vk6cl5z.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=andersk@ksplice.com \
--cc=ben@decadent.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=tony@atomide.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.