From: Arnaud Patard (Rtp) <arnaud.patard-dQbF7i+pzddAfugRpC6u6w@public.gmane.org>
To: marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org
Cc: sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
Mark Brown
<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>,
spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org
Subject: Re: mc13xxx: add I2C support
Date: Fri, 20 Jan 2012 11:36:07 +0100 [thread overview]
Message-ID: <878vl2lkyw.fsf@lebrac.rtp-net.org> (raw)
In-Reply-To: <201201201855.35971.marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org> (Marc Reilly's message of "Fri, 20 Jan 2012 18:55:35 +1100")
Marc Reilly <marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org> writes:
> Hi,
Hi,
>
> Thankyou all for your feedback and comments. I'll use them for a V2 but
> Samuel, I'd like to know if you'd like me to base them on a specific branch
> before I do.
>
> Shawn, thanks for testing!
>
> On Thursday, January 19, 2012 10:29:41 PM Mark Brown wrote:
>> On Thu, Jan 19, 2012 at 12:12:31PM +0100, Arnaud Patard wrote:
>> > I've never looked at regmap deeply but can't it be done with regmap or is
>> > it just a bad idea ?
>>
>> Glancing quickly at the existing code it should map on reasonably well,
>> though a new format definition may be required for the 25 bit shift that
>> would be trivial.
>
> I'm sadly unfamiliar with regmap, is it a far superior solution? does it need
The aim of regmap is to provide a solution for chip running either on
i2c or spi, that's why I thought it would be interesting to use it
instead of rewriting similar code.
> to used now? (ie. I'm relucant to totally rework this now. Please convince me
> I need to if required.)
I don't know. I've no strong opinion about it. Moreover, nothing
prevents you to try to merge this version and then convert to regmap,
say once the 25 bit shift problem noticed by Mark is fixed.
Arnaud
WARNING: multiple messages have this Message-ID (diff)
From: arnaud.patard@rtp-net.org (Arnaud Patard (Rtp))
To: linux-arm-kernel@lists.infradead.org
Subject: mc13xxx: add I2C support
Date: Fri, 20 Jan 2012 11:36:07 +0100 [thread overview]
Message-ID: <878vl2lkyw.fsf@lebrac.rtp-net.org> (raw)
In-Reply-To: <201201201855.35971.marc@cpdesign.com.au> (Marc Reilly's message of "Fri, 20 Jan 2012 18:55:35 +1100")
Marc Reilly <marc@cpdesign.com.au> writes:
> Hi,
Hi,
>
> Thankyou all for your feedback and comments. I'll use them for a V2 but
> Samuel, I'd like to know if you'd like me to base them on a specific branch
> before I do.
>
> Shawn, thanks for testing!
>
> On Thursday, January 19, 2012 10:29:41 PM Mark Brown wrote:
>> On Thu, Jan 19, 2012 at 12:12:31PM +0100, Arnaud Patard wrote:
>> > I've never looked at regmap deeply but can't it be done with regmap or is
>> > it just a bad idea ?
>>
>> Glancing quickly at the existing code it should map on reasonably well,
>> though a new format definition may be required for the 25 bit shift that
>> would be trivial.
>
> I'm sadly unfamiliar with regmap, is it a far superior solution? does it need
The aim of regmap is to provide a solution for chip running either on
i2c or spi, that's why I thought it would be interesting to use it
instead of rewriting similar code.
> to used now? (ie. I'm relucant to totally rework this now. Please convince me
> I need to if required.)
I don't know. I've no strong opinion about it. Moreover, nothing
prevents you to try to merge this version and then convert to regmap,
say once the 25 bit shift problem noticed by Mark is fixed.
Arnaud
next prev parent reply other threads:[~2012-01-20 10:36 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-19 1:01 mc13xxx: add I2C support Marc Reilly
2012-01-19 1:01 ` Marc Reilly
[not found] ` <1326934894-29516-1-git-send-email-marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org>
2012-01-19 1:01 ` [PATCH 1/3] mc13xxx-core: Prepare for separate spi and i2c backends Marc Reilly
2012-01-19 1:01 ` Marc Reilly
[not found] ` <1326934894-29516-2-git-send-email-marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org>
2012-01-19 7:35 ` Shawn Guo
2012-01-19 7:35 ` Shawn Guo
2012-01-19 7:51 ` Uwe Kleine-König
2012-01-19 7:51 ` Uwe Kleine-König
2012-01-19 1:01 ` [PATCH 2/3] mfd: mc13xxx-core: Move spi specific code into separate module Marc Reilly
2012-01-19 1:01 ` Marc Reilly
[not found] ` <1326934894-29516-3-git-send-email-marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org>
2012-01-19 8:08 ` Uwe Kleine-König
2012-01-19 8:08 ` Uwe Kleine-König
[not found] ` <20120119080843.GC4066-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-01-19 12:54 ` Grant Likely
2012-01-19 12:54 ` Grant Likely
2012-01-19 1:01 ` [PATCH 3/3] mfd: mc13xxx-core: Add i2c driver Marc Reilly
2012-01-19 1:01 ` Marc Reilly
2012-01-19 7:22 ` mc13xxx: add I2C support Shawn Guo
2012-01-19 7:22 ` Shawn Guo
2012-01-19 11:12 ` Arnaud Patard
2012-01-19 11:12 ` Arnaud Patard (Rtp)
[not found] ` <87lip4kktc.fsf-0gaJ4kiyQU6khWr4QmshqB2eb7JE58TQ@public.gmane.org>
2012-01-19 11:29 ` Mark Brown
2012-01-19 11:29 ` Mark Brown
[not found] ` <20120119112941.GC29494-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2012-01-20 7:55 ` Marc Reilly
[not found] ` <201201201855.35971.marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org>
2012-01-20 10:36 ` Arnaud Patard [this message]
2012-01-20 10:36 ` Arnaud Patard (Rtp)
2012-01-20 12:08 ` Mark Brown
2012-01-20 12:08 ` Mark Brown
2012-02-20 16:50 ` Samuel Ortiz
2012-02-20 16:50 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878vl2lkyw.fsf@lebrac.rtp-net.org \
--to=arnaud.patard-dqbf7i+pzddafugrpc6u6w@public.gmane.org \
--cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org \
--cc=mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.