From: Kevin Hilman <khilman@ti.com>
To: Nishanth Menon <nm@ti.com>
Cc: linux-omap <linux-omap@vger.kernel.org>,
Martin Etti <ettl.martin@gmx.de>,
linux-arm <linux-arm-kernel@lists.infradead.org>,
Tony <tony@atomide.com>
Subject: Re: [PATCH] OMAP4: PM: remove redundant #ifdef CONFIG_PM
Date: Thu, 17 Mar 2011 14:43:31 -0700 [thread overview]
Message-ID: <878vwdv2ws.fsf@ti.com> (raw)
In-Reply-To: <1299987443-27275-1-git-send-email-nm@ti.com> (Nishanth Menon's message of "Sun, 13 Mar 2011 09:07:23 +0530")
Nishanth Menon <nm@ti.com> writes:
> pm44xx.c is built only when CONFIG_PM is setup,
> remove redundant CONFIG_PM check.
>
> This also fixes:
> https://bugzilla.kernel.org/show_bug.cgi?id=25022
>
> Reported-by: Martin Etti <ettl.martin@gmx.de>
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
Thanks, queuing for 2.6.39-rc fixes cycle (branch: for_2.6.39/pm-fixes)
Kevin
> ---
> arch/arm/mach-omap2/pm44xx.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm44xx.c b/arch/arm/mach-omap2/pm44xx.c
> index 76cfff2..59a870b 100644
> --- a/arch/arm/mach-omap2/pm44xx.c
> +++ b/arch/arm/mach-omap2/pm44xx.c
> @@ -105,13 +105,11 @@ static int __init omap4_pm_init(void)
>
> pr_err("Power Management for TI OMAP4.\n");
>
> -#ifdef CONFIG_PM
> ret = pwrdm_for_each(pwrdms_setup, NULL);
> if (ret) {
> pr_err("Failed to setup powerdomains\n");
> goto err2;
> }
> -#endif
>
> #ifdef CONFIG_SUSPEND
> suspend_set_ops(&omap_pm_ops);
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] OMAP4: PM: remove redundant #ifdef CONFIG_PM
Date: Thu, 17 Mar 2011 14:43:31 -0700 [thread overview]
Message-ID: <878vwdv2ws.fsf@ti.com> (raw)
In-Reply-To: <1299987443-27275-1-git-send-email-nm@ti.com> (Nishanth Menon's message of "Sun, 13 Mar 2011 09:07:23 +0530")
Nishanth Menon <nm@ti.com> writes:
> pm44xx.c is built only when CONFIG_PM is setup,
> remove redundant CONFIG_PM check.
>
> This also fixes:
> https://bugzilla.kernel.org/show_bug.cgi?id=25022
>
> Reported-by: Martin Etti <ettl.martin@gmx.de>
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
Thanks, queuing for 2.6.39-rc fixes cycle (branch: for_2.6.39/pm-fixes)
Kevin
> ---
> arch/arm/mach-omap2/pm44xx.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm44xx.c b/arch/arm/mach-omap2/pm44xx.c
> index 76cfff2..59a870b 100644
> --- a/arch/arm/mach-omap2/pm44xx.c
> +++ b/arch/arm/mach-omap2/pm44xx.c
> @@ -105,13 +105,11 @@ static int __init omap4_pm_init(void)
>
> pr_err("Power Management for TI OMAP4.\n");
>
> -#ifdef CONFIG_PM
> ret = pwrdm_for_each(pwrdms_setup, NULL);
> if (ret) {
> pr_err("Failed to setup powerdomains\n");
> goto err2;
> }
> -#endif
>
> #ifdef CONFIG_SUSPEND
> suspend_set_ops(&omap_pm_ops);
next prev parent reply other threads:[~2011-03-17 21:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-13 3:37 [PATCH] OMAP4: PM: remove redundant #ifdef CONFIG_PM Nishanth Menon
2011-03-13 3:37 ` Nishanth Menon
2011-03-17 21:43 ` Kevin Hilman [this message]
2011-03-17 21:43 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878vwdv2ws.fsf@ti.com \
--to=khilman@ti.com \
--cc=ettl.martin@gmx.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.