All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@ti.com>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 10/17] omap4: pm: Add L2 cache lowpower support
Date: Wed, 02 Mar 2011 14:36:18 -0800	[thread overview]
Message-ID: <878vwx40bh.fsf@ti.com> (raw)
In-Reply-To: <1298112158-28469-11-git-send-email-santosh.shilimkar@ti.com> (Santosh Shilimkar's message of "Sat, 19 Feb 2011 16:12:31 +0530")

Santosh Shilimkar <santosh.shilimkar@ti.com> writes:

> When MPUSS hits off-mode e, L2 cache is lost. This patch adds L2X0
> necessary maintenance operations and context restoration in the
> low power code.
>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Reviewed-by: Kevin Hilman <khilman@ti.com>
> ---
>  arch/arm/mach-omap2/omap4-mpuss-lowpower.c |   11 +++++
>  arch/arm/mach-omap2/omap4-sar-layout.h     |    2 +
>  arch/arm/mach-omap2/sleep44xx.S            |   64 ++++++++++++++++++++++++++++
>  3 files changed, 77 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap4-mpuss-lowpower.c b/arch/arm/mach-omap2/omap4-mpuss-lowpower.c
> index a30f19b..bff768f 100644
> --- a/arch/arm/mach-omap2/omap4-mpuss-lowpower.c
> +++ b/arch/arm/mach-omap2/omap4-mpuss-lowpower.c
> @@ -49,6 +49,7 @@
>  #include <asm/system.h>
>  #include <asm/irq.h>
>  #include <asm/hardware/gic.h>
> +#include <asm/hardware/cache-l2x0.h>
>  
>  #include <plat/omap44xx.h>
>  #include <mach/omap4-common.h>
> @@ -341,6 +342,7 @@ int __init omap4_mpuss_init(void)
>  {
>  	struct omap4_cpu_pm_info *pm_info;
>  	u8 i;
> +	u32 val;

This will cause an 'unused variable' compiler warning when
!CONFIG_CACHE_L2X0

[...]

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 10/17] omap4: pm: Add L2 cache lowpower support
Date: Wed, 02 Mar 2011 14:36:18 -0800	[thread overview]
Message-ID: <878vwx40bh.fsf@ti.com> (raw)
In-Reply-To: <1298112158-28469-11-git-send-email-santosh.shilimkar@ti.com> (Santosh Shilimkar's message of "Sat, 19 Feb 2011 16:12:31 +0530")

Santosh Shilimkar <santosh.shilimkar@ti.com> writes:

> When MPUSS hits off-mode e, L2 cache is lost. This patch adds L2X0
> necessary maintenance operations and context restoration in the
> low power code.
>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Reviewed-by: Kevin Hilman <khilman@ti.com>
> ---
>  arch/arm/mach-omap2/omap4-mpuss-lowpower.c |   11 +++++
>  arch/arm/mach-omap2/omap4-sar-layout.h     |    2 +
>  arch/arm/mach-omap2/sleep44xx.S            |   64 ++++++++++++++++++++++++++++
>  3 files changed, 77 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap4-mpuss-lowpower.c b/arch/arm/mach-omap2/omap4-mpuss-lowpower.c
> index a30f19b..bff768f 100644
> --- a/arch/arm/mach-omap2/omap4-mpuss-lowpower.c
> +++ b/arch/arm/mach-omap2/omap4-mpuss-lowpower.c
> @@ -49,6 +49,7 @@
>  #include <asm/system.h>
>  #include <asm/irq.h>
>  #include <asm/hardware/gic.h>
> +#include <asm/hardware/cache-l2x0.h>
>  
>  #include <plat/omap44xx.h>
>  #include <mach/omap4-common.h>
> @@ -341,6 +342,7 @@ int __init omap4_mpuss_init(void)
>  {
>  	struct omap4_cpu_pm_info *pm_info;
>  	u8 i;
> +	u32 val;

This will cause an 'unused variable' compiler warning when
!CONFIG_CACHE_L2X0

[...]

Kevin

  reply	other threads:[~2011-03-02 22:36 UTC|newest]

Thread overview: 110+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-19 10:42 [PATCH 00/17] omap4: pm: suspend, hotplug and cpuilde support Santosh Shilimkar
2011-02-19 10:42 ` Santosh Shilimkar
2011-02-19 10:42 ` [PATCH 01/17] omap4: pm: Add omap WakeupGen module support Santosh Shilimkar
2011-02-19 10:42   ` Santosh Shilimkar
2011-03-02 21:47   ` Kevin Hilman
2011-03-02 21:47     ` Kevin Hilman
2011-03-03 16:04     ` Santosh Shilimkar
2011-03-03 16:04       ` Santosh Shilimkar
2011-02-19 10:42 ` [PATCH 02/17] omap4: pm: Add SAR RAM support Santosh Shilimkar
2011-02-19 10:42   ` Santosh Shilimkar
2011-03-02 21:56   ` Kevin Hilman
2011-03-02 21:56     ` Kevin Hilman
2011-03-03 16:08     ` Santosh Shilimkar
2011-03-03 16:08       ` Santosh Shilimkar
2011-02-19 10:42 ` [PATCH 03/17] omap4: Export scu base address Santosh Shilimkar
2011-02-19 10:42   ` Santosh Shilimkar
2011-03-02 21:58   ` Kevin Hilman
2011-03-02 21:58     ` Kevin Hilman
2011-03-03 16:09     ` Santosh Shilimkar
2011-03-03 16:09       ` Santosh Shilimkar
2011-02-19 10:42 ` [PATCH 04/17] omap4: pm: Add CPUx OFF mode support Santosh Shilimkar
2011-02-19 10:42   ` Santosh Shilimkar
2011-03-02 22:12   ` Kevin Hilman
2011-03-02 22:12     ` Kevin Hilman
2011-03-03 16:14     ` Santosh Shilimkar
2011-03-03 16:14       ` Santosh Shilimkar
2011-02-19 10:42 ` [PATCH 05/17] omap4: pm: Initialise all the clockdomains to supported states Santosh Shilimkar
2011-02-19 10:42   ` Santosh Shilimkar
2011-03-02 22:17   ` Kevin Hilman
2011-03-02 22:17     ` Kevin Hilman
2011-03-03 16:14     ` Santosh Shilimkar
2011-03-03 16:14       ` Santosh Shilimkar
2011-02-19 10:42 ` [PATCH 06/17] omap4: pm: Program CPU1 to hit OFF when off-lined Santosh Shilimkar
2011-02-19 10:42   ` Santosh Shilimkar
2011-02-19 10:42 ` [PATCH 07/17] omap4: pm: CPU1 wakeup workaround form Low power modes Santosh Shilimkar
2011-02-19 10:42   ` Santosh Shilimkar
2011-03-02 22:23   ` Kevin Hilman
2011-03-02 22:23     ` Kevin Hilman
2011-03-03 16:15     ` Santosh Shilimkar
2011-03-03 16:15       ` Santosh Shilimkar
2011-03-02 23:44   ` Kevin Hilman
2011-03-02 23:44     ` Kevin Hilman
2011-02-19 10:42 ` [PATCH 08/17] omap4: pm: Add GIC save/restore support Santosh Shilimkar
2011-02-19 10:42   ` Santosh Shilimkar
2011-03-02 22:29   ` Kevin Hilman
2011-03-02 22:29     ` Kevin Hilman
2011-03-03 16:29     ` Santosh Shilimkar
2011-03-03 16:29       ` Santosh Shilimkar
2011-03-03 17:03       ` Kevin Hilman
2011-03-03 17:03         ` Kevin Hilman
2011-03-04  8:39     ` Santosh Shilimkar
2011-03-04  8:39       ` Santosh Shilimkar
2011-03-04 16:11       ` Kevin Hilman
2011-03-04 16:11         ` Kevin Hilman
2011-03-04 16:14         ` Santosh Shilimkar
2011-03-04 16:14           ` Santosh Shilimkar
2011-02-19 10:42 ` [PATCH 09/17] omap4: pm: Add WakeupGen " Santosh Shilimkar
2011-02-19 10:42   ` Santosh Shilimkar
2011-03-02 22:34   ` Kevin Hilman
2011-03-02 22:34     ` Kevin Hilman
2011-02-19 10:42 ` [PATCH 10/17] omap4: pm: Add L2 cache lowpower support Santosh Shilimkar
2011-02-19 10:42   ` Santosh Shilimkar
2011-03-02 22:36   ` Kevin Hilman [this message]
2011-03-02 22:36     ` Kevin Hilman
2011-03-03 16:30     ` Santosh Shilimkar
2011-03-03 16:30       ` Santosh Shilimkar
2011-02-19 10:42 ` [PATCH 11/17] omap4: suspend: Add MPUSS RET and OFF support Santosh Shilimkar
2011-02-19 10:42   ` Santosh Shilimkar
2011-03-02 22:45   ` Kevin Hilman
2011-03-02 22:45     ` Kevin Hilman
2011-03-03 16:31     ` Santosh Shilimkar
2011-03-03 16:31       ` Santosh Shilimkar
2011-02-19 10:42 ` [PATCH 12/17] omap4: pm-debug: Add wakeup timer and debug counters Santosh Shilimkar
2011-02-19 10:42   ` Santosh Shilimkar
2011-03-02 22:51   ` Kevin Hilman
2011-03-02 22:51     ` Kevin Hilman
2011-03-03 16:34     ` Santosh Shilimkar
2011-03-03 16:34       ` Santosh Shilimkar
2011-03-03 17:05       ` Kevin Hilman
2011-03-03 17:05         ` Kevin Hilman
2011-03-04  6:26         ` Santosh Shilimkar
2011-03-04  6:26           ` Santosh Shilimkar
2011-02-19 10:42 ` [PATCH 13/17] omap4: cpuidle: Basic CPUidle support Santosh Shilimkar
2011-02-19 10:42   ` Santosh Shilimkar
2011-03-02 22:55   ` Kevin Hilman
2011-03-02 22:55     ` Kevin Hilman
2011-02-19 10:42 ` [PATCH 14/17] omap4: cpuidle: Add MPUSS RET OFF states Santosh Shilimkar
2011-02-19 10:42   ` Santosh Shilimkar
2011-02-21 10:19   ` Jean Pihet
2011-02-21 10:19     ` Jean Pihet
2011-02-21 10:26     ` Santosh Shilimkar
2011-02-21 10:26       ` Santosh Shilimkar
2011-02-21 14:01       ` Santosh Shilimkar
2011-02-21 14:01         ` Santosh Shilimkar
2011-03-02 23:32   ` Kevin Hilman
2011-03-02 23:32     ` Kevin Hilman
2011-02-19 10:42 ` [PATCH 15/17] omap4: cpuidle: Switch to gptimer from twd in deeper C-states Santosh Shilimkar
2011-02-19 10:42   ` Santosh Shilimkar
2011-02-19 10:42 ` [PATCH 16/17] omap4: cpuidle: Allow debugfs control through enable_off_mode Santosh Shilimkar
2011-02-19 10:42   ` Santosh Shilimkar
2011-03-02 23:43   ` Kevin Hilman
2011-03-02 23:43     ` Kevin Hilman
2011-02-19 10:42 ` [PATCH 17/17] omap4: Remove un-used do_wfi() macro Santosh Shilimkar
2011-02-19 10:42   ` Santosh Shilimkar
2011-03-02 23:46 ` [PATCH 00/17] omap4: pm: suspend, hotplug and cpuilde support Kevin Hilman
2011-03-02 23:46   ` Kevin Hilman
2011-03-03  7:20   ` Santosh Shilimkar
2011-03-03  7:20     ` Santosh Shilimkar
2011-03-04 17:20   ` Santosh Shilimkar
2011-03-04 17:20     ` Santosh Shilimkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878vwx40bh.fsf@ti.com \
    --to=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=santosh.shilimkar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.