From: Kevin Hilman <khilman@deeprootsystems.com>
To: Thara Gopinath <thara@ti.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] OMAP: pm.c correct the initcall for an early init.
Date: Thu, 02 Dec 2010 14:33:15 +0100 [thread overview]
Message-ID: <878w0847vo.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1291201283-21185-1-git-send-email-thara@ti.com> (Thara Gopinath's message of "Wed, 1 Dec 2010 16:31:23 +0530")
Thara Gopinath <thara@ti.com> writes:
> omap2_common_pm_init is the API where generic system devices like
> mpu, l3 etc get initialized. This has to happen really early on
> during the boot and not at a later time. This is especially important
> with the new opp changes as these devices need to be built before the
> opp tables init happen. Today both are device initcalls and it works
> just because of the order of compilation
Why postcore? there are several other inicalls earlier than
device_initcall.
Also, does this actually work? Is the driver core initialized at
postcore_initcall time such that omap_devices w/platform_device
creation actually works?
Kevin
> Signed-off-by: Thara Gopinath <thara@ti.com>
> ---
> arch/arm/mach-omap2/pm.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c
> index 59ca03b..6ec2ee1 100644
> --- a/arch/arm/mach-omap2/pm.c
> +++ b/arch/arm/mach-omap2/pm.c
> @@ -143,5 +143,5 @@ static int __init omap2_common_pm_init(void)
>
> return 0;
> }
> -device_initcall(omap2_common_pm_init);
> +postcore_initcall(omap2_common_pm_init);
next prev parent reply other threads:[~2010-12-02 13:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 11:01 [PATCH] OMAP: pm.c correct the initcall for an early init Thara Gopinath
2010-12-02 13:33 ` Kevin Hilman [this message]
2010-12-03 8:47 ` Gopinath, Thara
2010-12-14 1:06 ` Kevin Hilman
2010-12-15 15:38 ` Gopinath, Thara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878w0847vo.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=thara@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.