Re: [PATCH] OMAP: pm.c correct the initcall for an early init.

[Kevin Hilman <khilman@deeprootsystems.com>]

"Gopinath, Thara" <thara@ti.com> writes:

>>>-----Original Message-----
>>>From: Kevin Hilman [mailto:khilman@deeprootsystems.com]
>>>Sent: Thursday, December 02, 2010 7:03 PM
>>>To: Gopinath, Thara
>>>Cc: linux-omap@vger.kernel.org
>>>Subject: Re: [PATCH] OMAP: pm.c correct the initcall for an early init.
>>>
>>>Thara Gopinath <thara@ti.com> writes:
>>>
>>>> omap2_common_pm_init is the API where generic system devices like
>>>> mpu, l3 etc get initialized. This has to happen really early on
>>>> during the boot and not at a later time. This is especially important
>>>> with the new opp changes as these devices need to be built before the
>>>> opp tables init happen. Today both are device initcalls and it works
>>>> just because of the order of compilation
>>>
>>>Why postcore?  there are several other inicalls earlier than
>>>device_initcall.
>
> Because the init in omap_device is a core_initcall. With respect
> to opp layer, making this anything above device_initcall will work. But
> then tomorrow some other module needs these generic devices in their init,
> we will again have to bump up the init priority of this fn.
> It is a good thing to do this early on in the boot cycle rather
> than later.

OK, please describe this in more detail the changelog.

Thanks,

Kevin