All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@deeprootsystems.com>
To: Sergio Aguirre <saaguirre@ti.com>
Cc: linux-omap@vger.kernel.org,
	Vikram Pandita <vikram.pandita@ti.com>,
	Paul Walmsley <paul@pwsan.com>, Tony Lindgren <tony@atomide.com>
Subject: Re: [RFC part1/2 merge v2 RESEND][PATCH 09/10] omap3: zoom 2/3: Change debugboard serial port id
Date: Mon, 08 Mar 2010 09:59:12 -0800	[thread overview]
Message-ID: <878wa2u233.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1268069332-14082-10-git-send-email-saaguirre@ti.com> (Sergio Aguirre's message of "Mon\,  8 Mar 2010 11\:28\:51 -0600")

Sergio Aguirre <saaguirre@ti.com> writes:

> This is now changed to PLAT8250_DEV_PLATFORM (= 0), because
> it is the only port that's going to be initted in Zoom 2/3 boards.
                                         ^^^^^^^

minor nit: not a word.  :) please use the much harder to spell:
initialized.  ;)

Kevin

>
> So, it doesn't make sense to keep the hardcoded 3 value anymore.
>
> Signed-off-by: Sergio Aguirre <saaguirre@ti.com>
> ---
>  arch/arm/mach-omap2/board-zoom-debugboard.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-zoom-debugboard.c b/arch/arm/mach-omap2/board-zoom-debugboard.c
> index bb4018b..e15d2e8 100644
> --- a/arch/arm/mach-omap2/board-zoom-debugboard.c
> +++ b/arch/arm/mach-omap2/board-zoom-debugboard.c
> @@ -96,7 +96,7 @@ static struct plat_serial8250_port serial_platform_data[] = {
>  
>  static struct platform_device zoom_debugboard_serial_device = {
>  	.name			= "serial8250",
> -	.id			= 3,
> +	.id			= PLAT8250_DEV_PLATFORM,
>  	.dev			= {
>  		.platform_data	= serial_platform_data,
>  	},
> -- 
> 1.6.3.3

  reply	other threads:[~2010-03-08 17:59 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-08 17:28 [RFC part1/2 merge v2 RESEND][PATCH 00/10] omap2/3/4: uart4 fixes + zoom2/3 changes Sergio Aguirre
2010-03-08 17:28 ` [RFC part1/2 merge v2 RESEND][PATCH 01/10] OMAP3: serial: Check for zero-based physical addr Sergio Aguirre
2010-03-08 18:24   ` Felipe Balbi
2010-03-08 20:28     ` Aguirre, Sergio
2010-03-08 21:40       ` Kevin Hilman
2010-03-08 17:28 ` [RFC part1/2 merge v2 RESEND][PATCH 02/10] omap2/3/4: serial: Remove condition for getting uart4_phys Sergio Aguirre
2010-03-08 17:28 ` [RFC part1/2 merge v2 RESEND][PATCH 03/10] ARM: OMAP3630: PRCM: Add UART4 control bits Sergio Aguirre
2010-03-08 17:28 ` [RFC part1/2 merge v2 RESEND][PATCH 04/10] OMAP clock: Add uart4_ick/fck definitions for 3630 Sergio Aguirre
2010-03-08 18:28   ` Felipe Balbi
2010-03-08 20:30     ` Aguirre, Sergio
2010-03-08 21:40       ` Kevin Hilman
2010-03-08 17:28 ` [RFC part1/2 merge v2 RESEND][PATCH 05/10] OMAP3: PRCM: Consider UART4 for 3630 chip in prcm_setup_regs Sergio Aguirre
2010-03-08 17:55   ` Kevin Hilman
2010-03-08 18:01     ` Aguirre, Sergio
2010-03-08 17:28 ` [RFC part1/2 merge v2 RESEND][PATCH 06/10] omap3: serial: Fix uart4 handling for 3630 Sergio Aguirre
2010-03-08 17:28 ` [RFC part1/2 merge v2 RESEND][PATCH 07/10] omap3: zoom2/3 / 3630sdp: Don't init always all uarts Sergio Aguirre
2010-03-08 17:28 ` [RFC part1/2 merge v2 RESEND][PATCH 08/10] omap3: 3630sdp: Explicitly enable all UARTs Sergio Aguirre
2010-03-08 17:28 ` [RFC part1/2 merge v2 RESEND][PATCH 09/10] omap3: zoom 2/3: Change debugboard serial port id Sergio Aguirre
2010-03-08 17:59   ` Kevin Hilman [this message]
2010-03-08 18:02     ` Aguirre, Sergio
2010-03-08 17:28 ` [RFC part1/2 merge v2 RESEND][PATCH 10/10] omap3: zoom2/3: Register only 1 8250 port Sergio Aguirre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878wa2u233.fsf@deeprootsystems.com \
    --to=khilman@deeprootsystems.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=saaguirre@ti.com \
    --cc=tony@atomide.com \
    --cc=vikram.pandita@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.