All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet-OfajU3CKLf1/SzgSGea1oA@public.gmane.org>
To: Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
Cc: Mark Brown
	<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>,
	Dongsoo Kim <dongsoo.kim-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	ben-Y5A6D6n0/KfQXOPxS62xeg@public.gmane.org,
	????????? <kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	????????? <bhmin-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	Dongsoo Kim
	<dongsoo45.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	?????? ??? <jsgood.yang-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Subject: Re: About a suspicious msleep during doxfer in s3c2410 i2c bus driver
Date: Fri, 31 Jul 2009 10:05:00 +0200	[thread overview]
Message-ID: <878wi5wa4z.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20090730221841.GG8850-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org> (Ben Dooks's message of "Thu\, 30 Jul 2009 23\:18\:41 +0100")

>>>>> "Ben" == Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org> writes:

Hi,

 >> It wasn't for the client devices, it was for issues with
 >> synchronisation with the controller hardware.  I'm just going on
 >> the basis of recollections of previous conversations with Ben
 >> here; I'm not sure to what extent this might be an issue with the
 >> way the hardware works requiring the driver to jump through hoops.

 Ben> I think this has been in here for a while, and may well not be
 Ben> necessary any more. If anyone else has tested this without the
 Ben> msleep() here, then I'd be interested to know.

I'll test on my 6410 board over the weekend. Notice that I've been
hacking on the uboot drivers/i2c/s3c24x0_i2c.c file to add s3c64xx
support, and I there had to add a udelay before setting the start
condition to get it to work stable.

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2009-07-31  8:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-22  8:12 About a suspicious msleep during doxfer in s3c2410 i2c bus driver Dongsoo, Nathaniel Kim
     [not found] ` <5e9665e10907220112m1dbf4975icf1511bc4ac3a1bf-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-07-22 12:43   ` Mark Brown
     [not found]     ` <20090722124333.GC7622-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2009-07-22 15:58       ` Dongsoo Kim
     [not found]         ` <E724615E-9F06-4406-9852-041261C5DAA6-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-07-22 16:06           ` Mark Brown
     [not found]             ` <20090722160639.GB14026-HF5t3jzXg/6ND3a5+9QAFujbO/Zr0HzV@public.gmane.org>
2009-07-30 22:18               ` Ben Dooks
     [not found]                 ` <20090730221841.GG8850-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
2009-07-31  0:20                   ` Dongsoo Kim
2009-07-31  8:05                   ` Peter Korsgaard [this message]
     [not found]                     ` <878wi5wa4z.fsf-uXGAPMMVk8amE9MCos8gUmSdvHPH+/yF@public.gmane.org>
2009-08-03  8:04                       ` Ben Dooks
2009-07-31 12:32                   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878wi5wa4z.fsf@macbook.be.48ers.dk \
    --to=jacmet-ofaju3cklf1/szgsgea1oa@public.gmane.org \
    --cc=ben-Y5A6D6n0/KfQXOPxS62xeg@public.gmane.org \
    --cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
    --cc=bhmin-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
    --cc=dongsoo.kim-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=dongsoo45.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=jsgood.yang-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.