Re: [PATCH] Fix color problem the grub-emu

[Marco Gerards <mgerards@xs4all.nl>]

Bean <bean123ch@gmail.com> writes:

> On Tue, Aug 5, 2008 at 6:15 PM, Marco Gerards <mgerards@xs4all.nl> wrote:
>> Hi,
>>
>> Bean <bean123ch@gmail.com> writes:
>>
>>> Currently, the color handling in grub-emu is broken, sometimes you see
>>> nothing on screen. This patch fix it, now variable menu_color_normal
>>> and menu_color_highlight works properly in grub-emu.
>>>
>>> 2008-08-02  Bean  <bean123ch@gmail.com>
>>>
>>>       * util/console.c (grub_console_cur_color): New variable.
>>>       (grub_console_standard_color): Likewise.
>>>       (grub_console_normal_color): Likewise.
>>>       (grub_console_highlight_color): Likewise.
>>>       (color_map): Likewise.
>>>       (use_color): Likewise.
>>>       (NUM_COLORS): New macro.
>>>       (grub_ncurses_setcolorstate): Handle color properly.
>>>       (grub_ncurses_setcolor): Don't change color here, just remember the
>>>       settings, color will be set in grub_ncurses_setcolorstate.
>>>       (grub_ncurses_getcolor): New function.
>>>       (grub_ncurses_init): Initialize color pairs.
>>>       (grub_term grub_ncurses_term): New member grub_ncurses_getcolor.
>>
>> This should be:
>>
>>        (grub_ncurses_term): New member grub_ncurses_getcolor.
>>
>>> --
>>> Bean
>>>
>>> diff --git a/util/console.c b/util/console.c
>>> index 8c9401c..53fc5d0 100644
>>> --- a/util/console.c
>>> +++ b/util/console.c
>>> @@ -41,6 +41,28 @@
>>>
>>>  static int grub_console_attr = A_NORMAL;
>>>
>>> +grub_uint8_t grub_console_cur_color = 7;
>>
>> Any reason why this is not static?
>
> Hi,
>
> This files include <grub/i386/pc/console.h>, which define
> grub_console_cur_color as global variable. Although grub-emu doesn't
> use this variable itself, but if I define it as static, it will
> generate a warning message.

Ah, ok :-)

--
Marco