All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marco Gerards <mgerards@xs4all.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] don't assume floppy device exists
Date: Thu, 14 Sep 2006 20:40:53 +0200	[thread overview]
Message-ID: <878xkmthoq.fsf@xs4all.nl> (raw)
In-Reply-To: <20060914182803.GA20575@khazad.dyndns.org> (Robert Millan's message of "Thu, 14 Sep 2006 20:28:03 +0200")

Robert Millan <rmh@aybabtu.com> writes:

> grub-install used to fail with "/dev/fd0 not found" errors.  See attached patch.

Thanks for the patch.  Just keep sending them. ;-)

> 2006-09-14  Robert Millan  <rmh@aybabtu.com>
>
> 	* util/i386/pc/grub-mkdevicemap.c:  Make sure floppy device exists
> 	before adding it to device.map.

I think it would be better to say "the floppy drive", no?

> +      if (stat (name, &st) < 0)
> +	break;

The indentation looks a bit weird in my mailclient.  Please make sure
the b of break is below the space after if.

After that, feel free to commit it.

--
Marco




  reply	other threads:[~2006-09-14 18:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-14 18:28 [PATCH] don't assume floppy device exists Robert Millan
2006-09-14 18:40 ` Marco Gerards [this message]
2006-09-14 18:56   ` Robert Millan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878xkmthoq.fsf@xs4all.nl \
    --to=mgerards@xs4all.nl \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.