From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Matheus Alves de Almeida <matheus.aalmeida@inf.ufrgs.br>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] fat: batch synchronous mirror writes
Date: Mon, 26 Oct 2026 16:39:40 +0900 [thread overview]
Message-ID: <87a4o0hpvn.fsf@mail.parknet.co.jp> (raw)
In-Reply-To: <87ecdchpzr.fsf@mail.parknet.co.jp>
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> writes:
> Matheus Alves de Almeida <matheus.aalmeida@inf.ufrgs.br> writes:
>
>> diff --git a/fs/fat/misc.c b/fs/fat/misc.c
>> index e79762cf1975..f8f89b947baf 100644
>> --- a/fs/fat/misc.c
>> +++ b/fs/fat/misc.c
>> @@ -365,3 +365,9 @@ int fat_sync_bhs(struct buffer_head **bhs, int nr_bhs)
>> }
>> return err;
>> }
>> +
>> +void fat_brelse_array(struct buffer_head *bhs[], int n)
>> +{
>> + while (--n >= 0)
>> + brelse(bhs[n]);
>> +}
>
> I'd like this is noop if n == 0, possibly easier to use and safer in future.
Ouch, it works as is.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2026-10-26 7:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-25 19:10 [PATCH 0/2] fat: improve synchronous mount performance Matheus Alves de Almeida
2026-10-25 19:10 ` [PATCH 1/2] fat: batch synchronous mirror writes Matheus Alves de Almeida
2026-10-26 7:37 ` OGAWA Hirofumi
2026-10-26 7:39 ` OGAWA Hirofumi [this message]
2026-10-25 19:10 ` [PATCH 2/2] fat: improve fat_sync_bhs() write submission Matheus Alves de Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a4o0hpvn.fsf@mail.parknet.co.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matheus.aalmeida@inf.ufrgs.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.