All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@kernel.org>
To: Anup Patel <anup@brainfault.org>
Cc: Yingjun Ni <yingjun.ni@riscv-computing.com>,
	pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu,
	alex@ghiti.fr, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org, Marc Zyngier <maz@kernel.org>
Subject: [PATCH] irqchip/msi-lib: Refuse initialization when irq_write_msi_msg() is missing
Date: Tue, 03 Feb 2026 22:05:44 +0100	[thread overview]
Message-ID: <87a4xp35cn.ffs@tglx> (raw)
In-Reply-To: <87ldh93cn1.ffs@tglx>

MSI parent domains rely on the fact that the top level device domain
provides a irq_write_msi_msg() callback.

Check for that and if missing warn and refuse to initialize the device domain.

Signed-off-by: Thomas Gleixner <tglx@kernel.org>
---
 drivers/irqchip/irq-msi-lib.c |    3 +++
 1 file changed, 3 insertions(+)

--- a/drivers/irqchip/irq-msi-lib.c
+++ b/drivers/irqchip/irq-msi-lib.c
@@ -48,6 +48,9 @@ bool msi_lib_init_dev_msi_info(struct de
 		return false;
 	}
 
+	if (WARN_ON_ONCE(!chip->irq_write_msi_msg))
+		return false;
+
 	required_flags = pops->required_flags;
 
 	/* Is the target domain bus token supported? */

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@kernel.org>
To: Anup Patel <anup@brainfault.org>
Cc: Yingjun Ni <yingjun.ni@riscv-computing.com>,
	pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu,
	alex@ghiti.fr, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org, Marc Zyngier <maz@kernel.org>
Subject: [PATCH] irqchip/msi-lib: Refuse initialization when irq_write_msi_msg() is missing
Date: Tue, 03 Feb 2026 22:05:44 +0100	[thread overview]
Message-ID: <87a4xp35cn.ffs@tglx> (raw)
In-Reply-To: <87ldh93cn1.ffs@tglx>

MSI parent domains rely on the fact that the top level device domain
provides a irq_write_msi_msg() callback.

Check for that and if missing warn and refuse to initialize the device domain.

Signed-off-by: Thomas Gleixner <tglx@kernel.org>
---
 drivers/irqchip/irq-msi-lib.c |    3 +++
 1 file changed, 3 insertions(+)

--- a/drivers/irqchip/irq-msi-lib.c
+++ b/drivers/irqchip/irq-msi-lib.c
@@ -48,6 +48,9 @@ bool msi_lib_init_dev_msi_info(struct de
 		return false;
 	}
 
+	if (WARN_ON_ONCE(!chip->irq_write_msi_msg))
+		return false;
+
 	required_flags = pops->required_flags;
 
 	/* Is the target domain bus token supported? */

  reply	other threads:[~2026-02-03 21:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-03  8:02 [PATCH] irqchip/riscv-imsic: Fix irq migration failure issue when cpu hotplug Yingjun Ni
2026-02-03  8:02 ` Yingjun Ni
2026-02-03 13:35 ` Thomas Gleixner
2026-02-03 13:35   ` Thomas Gleixner
2026-02-03 17:09   ` Anup Patel
2026-02-03 17:09     ` Anup Patel
2026-02-03 18:28     ` Thomas Gleixner
2026-02-03 18:28       ` Thomas Gleixner
2026-02-03 21:05       ` Thomas Gleixner [this message]
2026-02-03 21:05         ` [PATCH] irqchip/msi-lib: Refuse initialization when irq_write_msi_msg() is missing Thomas Gleixner
2026-02-24  7:20         ` [tip: irq/msi] " tip-bot2 for Thomas Gleixner
2026-04-30  3:26         ` [PATCH] " patchwork-bot+linux-riscv
2026-04-30  3:26           ` patchwork-bot+linux-riscv
2026-02-04  1:59   ` [PATCH] irqchip/riscv-imsic: Fix irq migration failure issue when cpu hotplug Yingjun Ni
2026-02-04  1:59     ` Yingjun Ni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a4xp35cn.ffs@tglx \
    --to=tglx@kernel.org \
    --cc=alex@ghiti.fr \
    --cc=anup@brainfault.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=maz@kernel.org \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=yingjun.ni@riscv-computing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.